[Bug 562785] New: Package Review: perl-Debug-Client - client side code for perl debugger
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Package Review: perl-Debug-Client - client side code for perl debugger
https://bugzilla.redhat.com/show_bug.cgi?id=562785
Summary: Package Review: perl-Debug-Client - client side code for perl debugger Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmaslano@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
SRPM: http://mmaslano.fedorapeople.org/review/perl-Debug-Client-0.11-1.fc13.src.rp... Spec: http://mmaslano.fedorapeople.org/review/perl-Debug-Client.spec Description: client side code for perl debugger
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562785
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cweyl@alumni.drew.edu
--- Comment #1 from Chris Weyl cweyl@alumni.drew.edu 2010-02-13 15:15:51 EST --- %description might need a bit of work :) And using DESTDIR rather than PERL_INSTALL_ROOT is probably a good idea, given the recent issues around it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562785
--- Comment #2 from Marcela Mašláňová mmaslano@redhat.com 2010-03-19 10:38:28 EDT --- http://mmaslano.fedorapeople.org/review/perl-Debug-Client.spec http://mmaslano.fedorapeople.org/review/perl-Debug-Client-0.11-2.fc14.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562785
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |emmanuel.seyman@club-intern | |et.fr AssignedTo|nobody@fedoraproject.org |emmanuel.seyman@club-intern | |et.fr Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562785
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Emmanuel Seyman emmanuel.seyman@club-internet.fr 2010-04-18 17:22:05 EDT ---
- = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: dist-f14 http://koji.fedoraproject.org/koji/taskinfo?taskID=2123952
[x] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings. [x] Package is not relocatable. [x] Buildroot is correct %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 9204796d0c884bbc8c504f821a7c2ee2 Debug-Client-0.11.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [x] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: rawhide.x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: dist-f14 http://koji.fedoraproject.org/koji/taskinfo?taskID=2123952
[?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=14, Tests=185, 21 wallclock secs ( 0.07 usr 0.03 sys + 0.94 cusr 0.16 csys = 1.20 CPU) Result: PASS
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562785
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Marcela Mašláňová mmaslano@redhat.com 2010-04-19 01:44:09 EDT --- New Package CVS Request ======================= Package Name: perl-Debug-Client Short Description: client side code for perl debugger Owners: mmaslano Branches: F-13 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562785
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2010-04-21 00:00:44 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562785
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla