[Bug 1497539] New: Review Request: vid.stab - Video stabilize library for fmpeg, mlt or transcode
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
Bug ID: 1497539 Summary: Review Request: vid.stab - Video stabilize library for fmpeg, mlt or transcode Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@online.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vid.stab.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vid.stab-1.1-120170830gitafc8...
Description: Vidstab is a video stabilization library which can be plugged-in with Ffmpeg and Transcode.
Fedora Account System Username: martinkg
rpmlint E: incorrect-fsf-address is already reported upstream https://github.com/georgmartius/vid.stab/issues/49
rpmlint -i -v vid.stab.spec /home/martin/rpmbuild/SRPMS/vid.stab-1.1-120170830gitafc8ea9.fc26.src.rpm /home/martin/rpmbuild/RPMS/x86_64/vid.stab-1.1-120170830gitafc8ea9.fc26.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vid.stab-devel-1.1-120170830gitafc8ea9.fc26.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vid.stab-debuginfo-1.1-120170830gitafc8ea9.fc26.x86_64.rpm vid.stab.spec: I: checking vid.stab.spec: I: checking-url https://github.com/georgmartius/vid.stab/archive/afc8ea9fb0632e0cdf781725a77... (timeout 10 seconds) vid.stab.src: I: checking vid.stab.src: W: spelling-error Summary(en_US) fmpeg -> MPEG The value of this tag appears to be misspelled. Please double-check.
vid.stab.src: W: spelling-error Summary(en_US) mlt -> ml, mt, melt The value of this tag appears to be misspelled. Please double-check.
vid.stab.src: W: spelling-error Summary(en_US) transcode -> trans code, trans-code, transcendent The value of this tag appears to be misspelled. Please double-check.
vid.stab.src: W: spelling-error %description -l en_US Vidstab -> Vista The value of this tag appears to be misspelled. Please double-check.
vid.stab.src: E: description-line-too-long C Vidstab is a video stabilization library which can be plugged-in with Ffmpeg and Transcode. Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines.
vid.stab.src: I: checking-url http://public.hronopik.de/vid.stab (timeout 10 seconds) vid.stab.src: I: checking-url https://github.com/georgmartius/vid.stab/archive/afc8ea9fb0632e0cdf781725a77... (timeout 10 seconds) vid.stab.x86_64: I: checking vid.stab.x86_64: W: spelling-error Summary(en_US) fmpeg -> MPEG The value of this tag appears to be misspelled. Please double-check.
vid.stab.x86_64: W: spelling-error Summary(en_US) mlt -> ml, mt, melt The value of this tag appears to be misspelled. Please double-check.
vid.stab.x86_64: W: spelling-error Summary(en_US) transcode -> trans code, trans-code, transcendent The value of this tag appears to be misspelled. Please double-check.
vid.stab.x86_64: W: spelling-error %description -l en_US Vidstab -> Vista The value of this tag appears to be misspelled. Please double-check.
vid.stab.x86_64: E: description-line-too-long C Vidstab is a video stabilization library which can be plugged-in with Ffmpeg and Transcode. Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines.
vid.stab.x86_64: I: checking-url http://public.hronopik.de/vid.stab (timeout 10 seconds) vid.stab.x86_64: E: incorrect-fsf-address /usr/share/licenses/vid.stab/LICENSE The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: I: checking vid.stab-devel.x86_64: W: spelling-error Summary(en_US) vid -> div, bid, vi The value of this tag appears to be misspelled. Please double-check.
vid.stab-devel.x86_64: I: checking-url http://public.hronopik.de/vid.stab (timeout 10 seconds) vid.stab-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
vid.stab-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/boxblur.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/frameinfo.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/libvidstab.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/localmotion2transform.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect_internal.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect_opt.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/serialize.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transform.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transform_internal.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformfixedpoint.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformfloat.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformtype.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformtype_operations.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/vidstabdefines.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/vsvector.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: I: checking vid.stab-debuginfo.x86_64: W: spelling-error Summary(en_US) vid -> div, bid, vi The value of this tag appears to be misspelled. Please double-check.
vid.stab-debuginfo.x86_64: W: spelling-error %description -l en_US vid -> div, bid, vi The value of this tag appears to be misspelled. Please double-check.
vid.stab-debuginfo.x86_64: I: checking-url http://public.hronopik.de/vid.stab (timeout 10 seconds) vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/boxblur.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/boxblur.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/frameinfo.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/frameinfo.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/libvidstab.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/localmotion2transform.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/localmotion2transform.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/motiondetect.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/motiondetect.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/motiondetect_internal.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/motiondetect_opt.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/motiondetect_opt.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/serialize.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/serialize.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/transform.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/transform.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/transformfixedpoint.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/transformfixedpoint.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/transformtype.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/transformtype.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/transformtype_operations.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/vidstabdefines.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/vsvector.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
vid.stab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/vid.stab-afc8ea9fb0632e0cdf781725a770edb1de788fed/src/vsvector.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
4 packages and 1 specfiles checked; 43 errors, 13 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
mgansser@alice.de mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/georgmar | |tius/vid.stab CC| |sergio@serjux.com
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |anto.trande@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #1 from mgansser@alice.de mgansser@online.de --- There seems to be a bug somewhere in tests suite:
https://forums.fedoraforum.org/showpost.php?p=1795399&postcount=3
<mock-chroot> sh-4.3# ./tests/tests *** UNIT TEST generateFrames(&testdata, 5) *** testframe transforms 1: Trans 5.000000 -5.000000 0.000000 0.000000 0 2: Trans -10.000000 -10.000000 0.000000 0.000000 0 3: Trans 15.000000 15.000000 0.052360 0.000000 0 4: Trans -20.000000 -20.000000 0.069813 0.000000 0 ----> Tests checks succeeded: 13/13 PASSED *********** SUMMARY ************** UNIT TESTs succeeded: 1/1 <mock-chroot> sh-4.3# echo $?
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #2 from mgansser@alice.de mgansser@online.de --- test suite gives now correct exit code back.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vid.stab.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vid.stab-1.1-2.20170830gitafc...
%changelog * Sat Oct 01 2017 Martin Gansser martinkg@fedoraproject.org - 1.1-2.20170830gitafc8ea9 - use macros EXIT_SUCCESS and EXIT_FAILURE instead for portability reasons
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #3 from Antonio Trande anto.trande@gmail.com ---
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
- Fix '#warning _FORTIFY_SOURCE requires compiling with optimization (-O)'; you are using double level of optimization.
- I don't see files licensed under GPLv3, GPLv2+ only.
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "CC by-nc- sa (v2.5) GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 41 files have unknown license. Detailed output of licensecheck in /home/sagitter/1497539-vid.stab/licensecheck.txt [?]: License file installed when any subpackage combination is installed. [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vid .stab-devel , vid.stab-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: vid.stab-1.1-2.20170830gitafc8ea9.fc28.x86_64.rpm vid.stab-devel-1.1-2.20170830gitafc8ea9.fc28.x86_64.rpm vid.stab-debuginfo-1.1-2.20170830gitafc8ea9.fc28.x86_64.rpm vid.stab-1.1-2.20170830gitafc8ea9.fc28.src.rpm vid.stab.x86_64: W: spelling-error Summary(en_US) fmpeg -> MPEG vid.stab.x86_64: W: spelling-error Summary(en_US) mlt -> ml, mt, melt vid.stab.x86_64: W: spelling-error Summary(en_US) transcode -> trans code, trans-code, transcendent vid.stab.x86_64: W: spelling-error %description -l en_US Vidstab -> Vista vid.stab.x86_64: E: incorrect-fsf-address /usr/share/licenses/vid.stab/LICENSE vid.stab-devel.x86_64: W: spelling-error Summary(en_US) vid -> div, bid, vi vid.stab-devel.x86_64: W: only-non-binary-in-usr-lib vid.stab-devel.x86_64: W: no-documentation vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/boxblur.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/frameinfo.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/libvidstab.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/localmotion2transform.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect_internal.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect_opt.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/serialize.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transform.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transform_internal.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformfixedpoint.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformfloat.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformtype.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformtype_operations.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/vidstabdefines.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/vsvector.h vid.stab-debuginfo.x86_64: W: spelling-error Summary(en_US) vid -> div, bid, vi vid.stab-debuginfo.x86_64: W: spelling-error %description -l en_US vid -> div, bid, vi vid.stab.src: W: spelling-error Summary(en_US) fmpeg -> MPEG vid.stab.src: W: spelling-error Summary(en_US) mlt -> ml, mt, melt vid.stab.src: W: spelling-error Summary(en_US) transcode -> trans code, trans-code, transcendent vid.stab.src: W: spelling-error %description -l en_US Vidstab -> Vista 4 packages and 0 specfiles checked; 17 errors, 13 warnings.
Rpmlint (debuginfo) ------------------- Checking: vid.stab-debuginfo-1.1-2.20170830gitafc8ea9.fc28.x86_64.rpm vid.stab-debuginfo.x86_64: W: spelling-error Summary(en_US) vid -> div, bid, vi vid.stab-debuginfo.x86_64: W: spelling-error %description -l en_US vid -> div, bid, vi 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory vid.stab-debuginfo.x86_64: W: spelling-error Summary(en_US) vid -> div, bid, vi vid.stab-debuginfo.x86_64: W: spelling-error %description -l en_US vid -> div, bid, vi vid.stab-debuginfo.x86_64: W: invalid-url URL: http://public.hronopik.de/vid.stab <urlopen error [Errno -2] Name or service not known> vid.stab-devel.x86_64: W: spelling-error Summary(en_US) vid -> div, bid, vi vid.stab-devel.x86_64: W: invalid-url URL: http://public.hronopik.de/vid.stab <urlopen error [Errno -2] Name or service not known> vid.stab-devel.x86_64: W: only-non-binary-in-usr-lib vid.stab-devel.x86_64: W: no-documentation vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/boxblur.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/frameinfo.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/libvidstab.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/localmotion2transform.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect_internal.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/motiondetect_opt.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/serialize.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transform.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transform_internal.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformfixedpoint.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformfloat.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformtype.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/transformtype_operations.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/vidstabdefines.h vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/vsvector.h vid.stab.x86_64: W: spelling-error Summary(en_US) fmpeg -> MPEG vid.stab.x86_64: W: spelling-error Summary(en_US) mlt -> ml, mt, melt vid.stab.x86_64: W: spelling-error Summary(en_US) transcode -> trans code, trans-code, transcendent vid.stab.x86_64: W: spelling-error %description -l en_US Vidstab -> Vista vid.stab.x86_64: W: invalid-url URL: http://public.hronopik.de/vid.stab <urlopen error [Errno -2] Name or service not known> vid.stab.x86_64: E: incorrect-fsf-address /usr/share/licenses/vid.stab/LICENSE 3 packages and 0 specfiles checked; 17 errors, 12 warnings.
Requires -------- vid.stab-debuginfo (rpmlib, GLIBC filtered):
vid.stab-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libvidstab.so.1.1()(64bit) vid.stab(x86-64)
vid.stab (rpmlib, GLIBC filtered): /sbin/ldconfig glibc libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libm.so.6()(64bit) rtld(GNU_HASH)
Provides -------- vid.stab-debuginfo: debuginfo(build-id) vid.stab-debuginfo vid.stab-debuginfo(x86-64)
vid.stab-devel: pkgconfig(vidstab) vid.stab-devel vid.stab-devel(x86-64)
vid.stab: libvidstab.so.1.1()(64bit) vid.stab vid.stab(x86-64)
Source checksums ---------------- https://github.com/georgmartius/vid.stab/archive/afc8ea9fb0632e0cdf781725a77... : CHECKSUM(SHA256) this package : 3d29256e4ead4a51c8a45e0656264a10afe02fd19d25a8ea1d1aafc1aa7d02ef CHECKSUM(SHA256) upstream package : 3d29256e4ead4a51c8a45e0656264a10afe02fd19d25a8ea1d1aafc1aa7d02ef
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1497539 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #4 from mgansser@alice.de mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vid.stab.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vid.stab-1.1-3.20170830gitafc...
%changelog * Wed Oct 04 2017 Martin Gansser martinkg@fedoraproject.org - 1.1-3.20170830gitafc8ea9 - change license tag to GPLv2 - fix warning _FORTIFY_SOURCE requires compiling with optimization (-O)
Is this ok, or should i create a patch for tests/CMakeLists.txt ?
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Antonio Trande anto.trande@gmail.com --- (In reply to mgansser@alice.de from comment #4)
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vid.stab.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vid.stab-1.1-3. 20170830gitafc8ea9.fc26.src.rpm
%changelog
- Wed Oct 04 2017 Martin Gansser martinkg@fedoraproject.org -
1.1-3.20170830gitafc8ea9
- change license tag to GPLv2
GPLv2+
- fix warning _FORTIFY_SOURCE requires compiling with optimization (-O)
Is this ok, or should i create a patch for tests/CMakeLists.txt ?
It's okay now.
Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #6 from mgansser@alice.de mgansser@online.de --- ok, will fix it to GPLv2+ Thanks for reviewing it.
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #7 from mgansser@alice.de mgansser@online.de --- the package request fails due the name of the package, i will contact the maintaner of fedrepo-req.
$ fedrepo-req vid.stab -t 1497539 Error: The repository name "vid.stab" is invalid. It must be at least two characters long with only letters, numbers, hyphens, and/or underscores. [martin@f26 package-updates]$ fedrepo-req "vid.stab" -t 1497539 Error: The repository name "vid.stab" is invalid. It must be at least two characters long with only letters, numbers, hyphens, and/or underscores.
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #8 from Sergio Monteiro Basto sergio@serjux.com --- You got my bless :) , i.e , I also approve the package . Thanks
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #9 from mgansser@alice.de mgansser@online.de --- @Antonio,
i read this in the fedora packaging naming guide [1]:
When naming packages for Fedora, the maintainer must use the dash '-' as the delimiter for name parts. The maintainer must NOT use an underscore '_', a plus '+', or a period '.' as a delimiter.
[1] https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuideline...
this means we have to rename the package name into vid-stab. Is this correct ?
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #10 from mgansser@alice.de mgansser@online.de --- That's the answer from the maintainer:
Hi Martin, Unfortunately there is still some discussion going on in https://pagure.io /fedrepo_req/issue/110. There are two things to resolve here, the first is modifying Pagure to accept those names, and then modifying fedrepo-req* to accept those names.
I will try to get this resolved shortly, but I don't control the changes on Pagure, so the overall fix is very dependent on how fast Pagure is fixed.
MATT PRAHL SOFTWARE ENGINEER, PNT DEVOPS
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #11 from Sergio Monteiro Basto sergio@serjux.com --- (In reply to mgansser@alice.de from comment #9)
this means we have to rename the package name into vid-stab. Is this correct ?
Yes , that is what I was thinking , we need rename package to avoid have one dot, so something like "-" is the best replacement , IMHO .
Martin , please repost Spec URL and SRPM URL with correct and final name to be mention that is approved .
Thanks. Best regards
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #12 from mgansser@alice.de mgansser@online.de --- (In reply to Sergio Monteiro Basto from comment #11)
(In reply to mgansser@alice.de from comment #9)
this means we have to rename the package name into vid-stab. Is this correct ?
Yes , that is what I was thinking , we need rename package to avoid have one dot, so something like "-" is the best replacement , IMHO .
Martin , please repost Spec URL and SRPM URL with correct and final name to be mention that is approved .
Thanks. Best regards
I think we should wait until fedrepo-req allows package name with dot, hopefully in the next version.
https://pagure.io/fedrepo_req/pull-request/111#c-f670dfbc93820b42bc4452ce0b1...
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #13 from Sergio Monteiro Basto sergio@serjux.com --- OK
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
--- Comment #14 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vid.stab
https://bugzilla.redhat.com/show_bug.cgi?id=1497539
mgansser@alice.de mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2017-10-08 16:38:22
--- Comment #15 from mgansser@alice.de mgansser@online.de --- package has been built successfully on f25, f26, f27 and rawhide.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com