https://bugzilla.redhat.com/show_bug.cgi?id=2118078
Bug ID: 2118078 Summary: Review Request: rust-attohttpc - Small and lightweight HTTP client Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-attohttpc/rust-attohttpc.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-attohttpc/rust-attohttpc-0.22....
Description: Small and lightweight HTTP client.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
--- Comment #1 from Davide Cavalca dcavalca@fb.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=90772919
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Blocks| |1990712
--- Comment #2 from Davide Cavalca dcavalca@fb.com --- This will need to be unretired on rawhide and f37 once approved: https://src.fedoraproject.org/rpms/rust-attohttpc
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1990712 [Bug 1990712] Review Request: rust-emuman - Utility for managing emulator ROM files
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- I recommend dropping the Rustls support features entirely rather than downgrading the dependencies.
I'm currently in the process of removing the Rustls crates from Fedora, because they are unused, and the ring + rustls upstream projects are pretty dead - or at least dormant (which is concerning for a crypto library and TLS implementation).
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |michel@michel-slm.name Flags| |needinfo?(dcavalca@fb.com) CC| |michel@michel-slm.name QA Contact|extras-qa@fedoraproject.org |michel@michel-slm.name
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- Will review once Davide addressed Fabio's comment
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NOTABUG |--- Keywords| |Reopened
--- Comment #6 from Davide Cavalca dcavalca@fb.com --- I looked at this quite a bit and I don't see a sane way to disable rustls and keep the tests working -- unfortunately the test suite relies on it pretty heavily. We could turn the tests off of course, but that seems suboptimal...
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- If not all dependencies for tests are available (in this case, not on all architectures), then that's a perfectly good reason to disable tests. It's not optimal, but it's definitely not a blocker for packaging something.
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |needinfo?(dcavalca@fb.com) Blocks|201449 (FE-DEADREVIEW) |
--- Comment #8 from Michel Alexandre Salim michel@michel-slm.name --- This has a broken dependency:
Error: Problem 1: conflicting requests - nothing provides (crate(multipart/client) >= 0.18.0 with crate(multipart/client) < 0.19.0~) needed by rust-attohttpc+multipart-devel-0.22.0-1.fc38.noarch Problem 2: package rust-attohttpc+multipart-form-devel-0.22.0-1.fc38.noarch requires crate(attohttpc/multipart) = 0.22.0, but none of the providers can be installed - conflicting requests - nothing provides (crate(multipart/client) >= 0.18.0 with crate(multipart/client) < 0.19.0~) needed by rust-attohttpc+multipart-devel-0.22.0-1.fc38.noarch (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
--- Comment #9 from Michel Alexandre Salim michel@michel-slm.name --- It got retired, you need to unretire it - https://src.fedoraproject.org/rpms/rust-multipart
https://bugzilla.redhat.com/show_bug.cgi?id=2118078
--- Comment #10 from Fabio Valentini decathorpe@gmail.com --- (In reply to Michel Alexandre Salim from comment #9)
It got retired, you need to unretire it - https://src.fedoraproject.org/rpms/rust-multipart
Please don't. I retired it intentionally. The "multipart" crate is obsolete and shouldn't be used any longer, "multer" seems to be the modern replacement. Instead, just disable the "multipart" feature in attohttpc.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com