[Bug 1730711] New: Review Request: ptxdist - Professional Embedded Linux Made Easy

https://bugzilla.redhat.com/show_bug.cgi?id=1730711

Bug ID: 1730711
           Summary: Review Request: ptxdist - Professional Embedded Linux
                    Made Easy
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Description:

PTXdist is a build system for firmware images.  It is developed
  by an Open Source Community including Pengutronix since 2001.
  The configuration system Kconfig, known from the Linux kernel,
  is used to select and configure each package.  The collection
  of recipes is based on GNU Make and Bash.

Issues:

fedora-review shows no obvious issues.
  rpmlint rants about some (needed, but empty or hidden) files.

FAS-User:

besser82

Urls:

Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/ptxdist.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/ptxdist-2019.07.0-0.1...

Temporary COPR for testing:

https://copr.fedorainfracloud.org/coprs/besser82/ptxdist

Thanks for review in advance!

[Bug 1730711] Review Request: ptxdist - Professional Embedded Linux Made Easy

https://bugzilla.redhat.com/show_bug.cgi?id=1730711

Björn 'besser82' Esser  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |ptxdist

--- Comment #1 from Björn 'besser82' Esser  ---
Scratch build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=36299199

[Bug 1730711] Review Request: ptxdist - Professional Embedded Linux Made Easy

https://bugzilla.redhat.com/show_bug.cgi?id=1730711

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Robert-André Mauchin  ---
 - Use macros

Source0:       
https://public.pengutronix.de/software/ptxdist/ptxdist-%%7Bversion%7D.tar.bz...

- BuildRequires:  python2-devel

Python 2 is now obsoleted, you need an FPC exception to depend on it.

[Bug 1730711] Review Request: ptxdist - Professional Embedded Linux Made Easy

https://bugzilla.redhat.com/show_bug.cgi?id=1730711

--- Comment #3 from Björn 'besser82' Esser  ---
(In reply to Robert-André Mauchin from comment #2)
> Use macros
>
> Source0:       
> https://public.pengutronix.de/software/ptxdist/ptxdist-%%7Bversion%7D.tar.bz...

Fixed.  I overlooked to change that before I uploaded the package.
> BuildRequires:  python2-devel
>
> Python 2 is now obsoleted, you need an FPC exception to depend on it.

If you refer to this [1], I suppose it will be needed for fc32+.  I cannot find
any guideline that enforces an exception during the current development cycle. 
Anyways, I've filed a ticket [2] with FESCo for such an exception.

[1]  https://fedoraproject.org/wiki/Changes/RetirePython2#FESCo_exceptions
[2]  https://pagure.io/fesco/issue/2179

***

Updated package:

Changelog:

* Thu Jul 18 2019 Björn Esser  - 2019.07.0-0.2
  - Several spec file improvements

Scratch build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=36316313

Urls:

Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/ptxdist.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/ptxdist-2019.07.0-0.2...

[Bug 1730711] Review Request: ptxdist - Professional Embedded Linux Made Easy

https://bugzilla.redhat.com/show_bug.cgi?id=1730711

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Miro Hrončok  ---
There is no python27-devel, just python27.

You need an exception to package something for Python 2 since Fedora 30,
because it is already against the guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

You *also* need an exception to keep the package in Fedora 32 once it is
branched because of Python 2 retirement:
https://fedoraproject.org/wiki/Changes/RetirePython2#FESCo_exceptions

needinfo canceled: [Bug 1730711] Review Request: ptxdist - Professional Embedded Linux Made Easy

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Björn 'besser82'
Esser 's needinfo:
Bug 1730711: Review Request: ptxdist - Professional Embedded Linux Made Easy
https://bugzilla.redhat.com/show_bug.cgi?id=1730711

--- Comment #6 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.