[Bug 1519906] New: Review Request: CodeReview - Application to perform code review on local Git repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
Bug ID: 1519906 Summary: Review Request: CodeReview - Application to perform code review on local Git repositories Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: fabrice.salvaire@orange.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Successful Copr build: https://copr-be.cloud.fedoraproject.org/results/fabricesalvaire/code-review/... Spec URL: https://github.com/FabriceSalvaire/CodeReview/blob/master/distro/fedora/Code... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/fabricesalvaire/code-review/... Description: Application to perform code review on local Git repositories Fedora Account System Username: fabricesalvaire
Listed on https://git-scm.com/download/gui/linux
https://github.com/FabriceSalvaire/CodeReview http://fabricesalvaire.github.io/CodeReview
https://copr.fedorainfracloud.org/coprs/fabricesalvaire/code-review
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
Fabrice Salvaire fabrice.salvaire@orange.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |williamjmorenor@gmail.com Assignee|nobody@fedoraproject.org |williamjmorenor@gmail.com Flags| |fedora-review?
--- Comment #1 from William Moreno williamjmorenor@gmail.com --- Hello and thanks for the interest to help with Fedora packaging.
Quick check of previus steps to become a packager:
Are suscrived at less to the devel-announce and packaging mainling list? Do you have a proper profile in the Fedora Wiki? A self introduction to devel is always nice to see.
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
--- Comment #2 from Fabrice Salvaire fabrice.salvaire@orange.fr --- I subscribed to devel and packging.
I cannot log in https://fedoraproject.org/wiki/Fedora_Project_Wiki
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
--- Comment #3 from William Moreno williamjmorenor@gmail.com --- Spec URL: https://raw.githubusercontent.com/FabriceSalvaire/CodeReview/master/distro/f... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/fabricesalvaire/code-review/...
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
Omar Berroteran omarberroteranlkf@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |omarberroteranlkf@gmail.com
--- Comment #4 from Omar Berroteran omarberroteranlkf@gmail.com --- To be recommended use lowercase filenames.
Package Review ==============
Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/lkf/1519906-CodeReview/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL
===== MUST items =====
C/C++: [X]: Package does not contain kernel modules. [X]: Package contains no static executables. [X]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [X]: Package does not contain any libtool archives (.la) [X]: Rpath absent or only used for internal libs.
Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (unspecified)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 88 files have unknown license. Detailed output of licensecheck in /home/lkf/1519906-CodeReview/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(iputils, efivar-libs, gd, gc, libtomcrypt, gdbm, gpgme, rpm-plugin-selinux, python3-sqlalchemy, libmcpp, libnfsidmap, libimagequant, lua-libs, trousers, bzip2-libs, unzip, libdb-utils, xorg-x11-font-utils, gtk2, gtk3, OpenEXR-libs, libcom_err, pycryptopp, libseccomp, gnutls, npth, p11-kit, libyaml, iptables-libs, rpm-build, cryptsetup-libs, ykpers, libmodman, libselinux-utils, perl-Scalar-List-Utils, parted, zstd, mozjs17, mesa-libwayland-egl, ghostscript-x11, lua-posix, libwebp, libxslt, libpkgconf, libunistring, keyutils-libs, perl-Encode, elfutils, python2-cryptography, libgpg-error, perl-Digest-SHA, audit- libs-python3, nss-tools, perl-Data-Dumper, gawk, python2-rpm, libbasicobjects, c-ares, lua-lpeg, python2-cairo, python3-crypto, jansson, e2fsprogs-libs, libdwarf, librsvg2, lcms2, apr, libsss_nss_idmap, annobin, deltarpm, file-libs, grub2-tools, libxcb, trousers-lib, libyubikey, python3-pycurl, mokutil, zip, python3-gobject, m4, gdb-headless, vim-enhanced, libusbx, python3-psutil, compat-openssl10, qrencode-libs, libICE, drpm, libwmf- lite, createrepo_c-libs, libtasn1, python3-coverage, openssh, sqlite, http-parser, tar, diffstat, sudo, freetype, openssl, dhcp-client, libarchive, gcc, systemd-bootchart, dwz, python2-gobject, avahi-libs, pyliblzma, ncurses-libs, polkit, pigz, checkpolicy, libpsl, python2-tornado, python3-rpm, libini_config, openssh-clients, libuser, python3-tornado, perl-libs, libX11, systemtap-devel, kbd, graphviz, htop, boost-date-time, python3-cryptography, systemd, libacl, gts, libwayland-cursor, libnl3, libsecret, libSM, policycoreutils, pixman, libidn, libXxf86misc, grubby, libatomic_ops, python2-kerberos, pango, libss, libbabeltrace, systemtap-client, libpath_utils, dbus, polkit- libs, python3-systemd, perl-threads, perl-Params-Validate, libsss_certmap, python2-libcomps, rpm-plugin-systemd-inhibit, cairo, audit-libs, nss-sysinit, libgcc, ilmbase, gettext-libs, p11-kit-trust, libref_array, python2-krbv, python3-cffi, libstemmer, dbus-libs, syslinux-extlinux, cairo-gobject, fftw-libs-double, at-spi2-core, usermode, bash, glibc-common, linux-atm-libs, libedit, libidn2, enchant, libuuid, subversion-libs, atk, python3-cairo, openldap, isl, ImageMagick, harfbuzz, xz, libXcomposite, mtools, gtk-update-icon- cache, vim-minimal, python3-wrapt, pcre-cpp, python2-libs, python3-markupsafe, libcrypt, groff-base, libdatrie, python3-lazy- object-proxy, gdk-pixbuf2, dhcp-libs, python2-cccolutils, libtalloc, libldb, grep, guile, pcre-utf16, libepoxy, cronie-anacron, libserf, xfsprogs, man-db, libcroco, libgcrypt, grub2-tools-efi, ipcalc, libart_lgpl, dconf, xz-libs, dbus-glib, timedatex, perl-Package-Stash- XS, colord-libs, which, boost-chrono, libcap, sssd-nfs-idmap, libdb, passwd, libgcab1, python3-bcrypt, desktop-file-utils, libXdamage, libsmartcols, rpm-libs, nano, libthai, createrepo_c, fakeroot, python2-markupsafe, libproxy, libpipeline, python2-sqlalchemy, iproute, python2-gpg, findutils, popt, python2-xpyb, fakeroot-libs, libsss_idmap, gobject-introspection, libpwquality, lua, boost-atomic, fontconfig, patchutils, krb5-workstation, python3-hawkey, os-prober, jbigkit-libs, python3-dbus, info, iproute-tc, systemd-libs, libjpeg- turbo, cpio, libpng, rest, lz4-libs, util-linux, libXfont, patch, krb5-libs, sqlite-libs, net-tools, python3-librepo, pkgconf, json-c, python3-libselinux, libwayland-client, sed, libipt, libsss_autofs, perl-threads-shared, glib-networking, kmod, initscripts, device- mapper, python2-librepo, libXtst, kpartx, xapian-core-libs, ghostscript-core, python3-pillow, sssd-client, GeoIP, hardlink, libcollection, libXrandr, doxygen, libsolv, libxkbcommon, perl- Unicode-UTF8, libzstd, nss-softokn, lasi, libXft, binutils, libattr, perl-Variable-Magic, gnupg2-smime, rpm, xorg-x11-server-utils, libssh2, syslinux, python3-libcomps, gnupg2, libXcursor, libverto, dracut, glib2-devel, cracklib, procps-ng, python3-lxml, ncurses, libdnf, python3-libs, graphite2, python3-kerberos, perl-version, appstream, perl-PathTools, libtdb, zlib, netpbm, libselinux, libassuan, python3-gpg, libxml2, expat, python3-setools, perl- interpreter, chkconfig, libargon2, libcurl, make, hostname, coreutils, libcap-ng, libsoup, pam, libgomp, python2-cffi, pinentry, fuse-sshfs, fuse, perl-Net-SSLeay, perl-Filter, librepo, lua-filesystem, audit, cups-libs, libappstream-glib, python2-coverage, gdk-pixbuf2-modules, at-spi2-atk, libsepol, gzip, libtevent, nss-pem, vim-common, lzo, less, libfdisk, tcl, rpm-build-libs, libnghttp2, python2-lxml, openssl-libs, gobject-introspection-devel, boost-system, libpcap, subversion, docker-rhel-push-plugin, systemtap-runtime, gmp, perl- Unicode-Normalize, perl-Socket, apr-util, polkit-pkla-compat, pcre2, python3, python2, cyrus-sasl-lib, gpm-libs, nspr, fuse-libs, python3 -gobject-base, perl-TermReadKey, libpng-devel, python3-PyYAML, libXfixes, shared-mime-info, libblkid, libsigsegv, json-glib, libsss_sudo, libfontenc, boost-thread, rsync, sssd-common, glibc, btrfs-progs, shadow-utils, perl-IO, bind99-libs, libcgroup, perl- Params-Util, libXaw, libXau, fipscheck, libXinerama, wget, kmod-libs, libtommath, elfutils-libs, perl-MIME-Base64, acl, libmount, libkadm5, libgusb, glib2, libtiff, ImageMagick-libs, python3-libsemanage, libstdc++, libtool-ltdl, libmnl, nss, libXxf86vm, pcre, git, cronie, ima-evm-utils, tcp_wrappers-libs, systemd-pam, git-core, python2 -gobject-base, perl-Storable, perl-Digest-MD5, grub2-tools-extra, libmpc, openssh-server, libXi, dyninst, openjpeg2, libXt, libXext, mcpp, python2-hawkey, perl-Sort-Key, nss-util, hunspell, libsemanage, libXrender, systemd-container, libcomps, systemd-udev, file, curl, nettle, bzip2, python2-pillow, libXmu, gettext, elfutils-libelf, nss- softokn-freebl, fipscheck-lib, jasper-libs, python2-pycurl, libutempter, device-mapper-libs, libmetalink, libffi, readline, pcre- utf32, ustr, diffutils, cryptopp, e2fsprogs, chrony, grub2-tools- minimal, libdhash, cpp, libXpm, libksba, hello, mpfr), /usr/lib /.build-id/ef(librsvg2, elfutils-libs, libdb-utils, glibc, libX11, libfdisk, graphviz, fuse), /usr/lib/.build-id/c0(glibc, python2-cryptography, python3-libs, pam, coreutils, file-libs, sed, graphviz, trousers-lib, libXxf86misc, libselinux-utils) [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [!]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Useful -debuginfo package or justification otherwise. [X]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: CodeReview-0.3.6-1.fc28.x86_64.rpm CodeReview-debuginfo-0.3.6-1.fc28.x86_64.rpm CodeReview-debugsource-0.3.6-1.fc28.x86_64.rpm CodeReview-0.3.6-1.fc28.src.rpm CodeReview.x86_64: W: spelling-error %description -l en_US paches -> paces, aches, peaches CodeReview.x86_64: W: spelling-error %description -l en_US unstage -> onstage, upstage, stage CodeReview.x86_64: W: no-documentation CodeReview.x86_64: E: wrong-script-interpreter /usr/lib64/python3.6/site-packages/CodeReview/PatienceDiff/_patiencediff_py.py /usr/bin/env python CodeReview.x86_64: E: non-executable-script /usr/lib64/python3.6/site-packages/CodeReview/PatienceDiff/_patiencediff_py.py 644 /usr/bin/env python CodeReview.x86_64: W: no-manual-page-for-binary diff-viewer CodeReview.x86_64: W: no-manual-page-for-binary pyqgit CodeReview-debuginfo.x86_64: E: useless-provides debuginfo(build-id) CodeReview-debugsource.x86_64: W: no-documentation CodeReview.src: W: spelling-error %description -l en_US pyqgit -> pyrite CodeReview.src: W: spelling-error %description -l en_US paches -> paces, aches, peaches CodeReview.src: W: spelling-error %description -l en_US unstage -> onstage, upstage, stage CodeReview.src: W: file-size-mismatch CodeReview-0.3.6.tar.gz = 627073, https://files.pythonhosted.org/packages/source/C/CodeReview/CodeReview-0.3.6... = 529750 4 packages and 0 specfiles checked; 3 errors, 10 warnings.
Rpmlint (debuginfo) ------------------- Checking: CodeReview-debuginfo-0.3.6-1.fc28.x86_64.rpm CodeReview-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory CodeReview.x86_64: W: spelling-error %description -l en_US paches -> paces, aches, peaches CodeReview.x86_64: W: spelling-error %description -l en_US unstage -> onstage, upstage, stage CodeReview.x86_64: W: invalid-url URL: https://github.com/FabriceSalvaire/CodeReview <urlopen error [Errno -2] Name or service not known> CodeReview.x86_64: W: no-documentation CodeReview.x86_64: E: wrong-script-interpreter /usr/lib64/python3.6/site-packages/CodeReview/PatienceDiff/_patiencediff_py.py /usr/bin/env python CodeReview.x86_64: E: non-executable-script /usr/lib64/python3.6/site-packages/CodeReview/PatienceDiff/_patiencediff_py.py 644 /usr/bin/env python CodeReview.x86_64: W: no-manual-page-for-binary diff-viewer CodeReview.x86_64: W: no-manual-page-for-binary pyqgit CodeReview-debugsource.x86_64: W: invalid-url URL: https://github.com/FabriceSalvaire/CodeReview <urlopen error [Errno -2] Name or service not known> CodeReview-debugsource.x86_64: W: no-documentation CodeReview-debuginfo.x86_64: W: invalid-url URL: https://github.com/FabriceSalvaire/CodeReview <urlopen error [Errno -2] Name or service not known> CodeReview-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 3 packages and 0 specfiles checked; 3 errors, 9 warnings.
Requires -------- CodeReview (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) libpthread.so.0()(64bit) libpython3.6m.so.1.0()(64bit) python(abi) python3-PyQt5 python3-PyYAML python3-pygit2 python3-pygments rtld(GNU_HASH)
CodeReview-debugsource (rpmlib, GLIBC filtered):
CodeReview-debuginfo (rpmlib, GLIBC filtered):
Provides -------- CodeReview: CodeReview CodeReview(x86-64) python3.6dist(codereview) python3dist(codereview)
CodeReview-debugsource: CodeReview-debugsource CodeReview-debugsource(x86-64)
CodeReview-debuginfo: CodeReview-debuginfo CodeReview-debuginfo(x86-64) debuginfo(build-id)
Unversioned so-files -------------------- CodeReview: /usr/lib64/python3.6/site-packages/CodeReview/PatienceDiff/_patiencediff_c.cpython-36m-x86_64-linux-gnu.so CodeReview: /usr/lib64/python3.6/site-packages/CodeReview/TextDistance/levenshtein_distance_c.cpython-36m-x86_64-linux-gnu.so
Source checksums ---------------- https://files.pythonhosted.org/packages/source/C/CodeReview/CodeReview-0.3.6... : CHECKSUM(SHA256) this package : 07d31d2b91bb8bc013c4d3c33c3d49f7bbe1e80d1424b63bd4b86aefd011674c CHECKSUM(SHA256) upstream package : 700d81adb6ad93d108a8af26652b79d7ceec9996a271e675168e09edbd6b5380 diff -r also reports differences
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabrice.salvaire@orange.fr Flags| |needinfo?(fabrice.salvaire@ | |orange.fr)
--- Comment #5 from William Moreno williamjmorenor@gmail.com --- Hello any update to continue with this review?
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
--- Comment #6 from William Moreno williamjmorenor@gmail.com --- Hello any update here? Some comments? if not I will need to close this ticket as a DEADREVIEW
https://bugzilla.redhat.com/show_bug.cgi?id=1519906
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(fabrice.salvaire@ | |orange.fr)
--- Comment #7 from William Moreno williamjmorenor@gmail.com --- Final ping
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com