[Bug 621242] New: Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gyp - Generate Your Projects

https://bugzilla.redhat.com/show_bug.cgi?id=621242

Summary: Review Request: gyp - Generate Your Projects
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp.spec
SRPM URL:
http://tagoh.fedorapeople.org/reviews/gyp/gyp-0.1-0.1.839svn.fc12.src.rpm
Description:
GYP is a tool to generates native Visual Studio, Xcode and SCons
and/or make build files from a platform-independent input format.

Its syntax is a universal cross-platform build representation
that still allows sufficient per-platform flexibility to accommodate
irreconcilable differences.

[Bug 621242] Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=621242

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|                            |619395
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Mamoru Tasaka  2010-08-04 14:34:36 EDT ---
Some notes:

! Unneeded macros
  - You can remove %python_sitearch definition because it is uses nowhere.

* Release
--------------------------------------------------------
Release: 0.1.%{?revision:%{revision}svn}%{?dist}
--------------------------------------------------------
  - Well, I guess you meant "0.1%{?revision:.%{revision}svn}%{?dist}"

* BuildRoot
  - BuildRoot tag is no longer needed on Fedora and EPEL6:
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* BR for python
  - Please specify python2 or python3. ref:
    https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

- Build fails on F-12 without BR: python2-devel:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2379955

* %{__python} setup.py install
  - Maybe there is only small difference, however I guess we usually
    add "--skip-build" to "python setup.py install".

[Bug 621242] Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=621242

--- Comment #2 from Akira TAGOH  2010-08-04 23:00:53 EDT ---
(In reply to comment #1)
> Some notes:
>
> ! Unneeded macros
> You can remove %python_sitearch definition because it is uses nowhere.

It was necessary to build on f12:
https://fedoraproject.org/wiki/Packaging:Python#Macros
> Release
> Release: 0.1.%{?revision:%{revision}svn}%{?dist}
> Well, I guess you meant "0.1%{?revision:.%{revision}svn}%{?dist}"

You're right. fixed.
> BuildRoot
> BuildRoot tag is no longer needed on Fedora and EPEL6:
> https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

fixed.
> BR for python
>
> Please specify python2 or python3. ref:
> https://fedoraproject.org/wiki/Packaging/Python#BuildRequires
>
> Build fails on F-12 without BR: python2-devel:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2379955

Okay, fixed.
> %{__python} setup.py install
> Maybe there is only small difference, however I guess we usually
> add "--skip-build" to "python setup.py install".

Sure. updated with:
Spec URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp.spec
SRPM URL:
http://tagoh.fedorapeople.org/reviews/gyp/gyp-0.1-0.2.839svn.fc12.src.rpm

[Bug 621242] Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=621242

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Mamoru Tasaka  2010-08-05 03:44:22 EDT ---
Okay.

(In reply to comment #2)
> (In reply to comment #1)
> > Some notes:
> >
> > ! Unneeded macros
> > You can remove %python_sitearch definition because it is uses nowhere.
>
> It was necessary to build on f12:
> https://fedoraproject.org/wiki/Packaging:Python#Macros

- Well, what I meant here is while %python_sitelib definition is
  needed for F=12, %python_sitearch definition is unneeded (because
  this is noarch), however not a blocker.

---------------------------------------------------------------
    This package (gyp) is APPROVED by mtasaka
---------------------------------------------------------------

[Bug 621242] Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=621242

Akira TAGOH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Akira TAGOH  2010-08-05 04:17:53 EDT ---
Ah, yep. just copy and paste that there. anyway, thank you for the review.

New Package SCM Request
=======================
Package Name: gyp
Short Description: Generate Your Projects
Owners: tagoh
Branches: f12 f13 f14
InitialCC:

[Bug 621242] Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=621242

--- Comment #5 from Kevin Fenzi  2010-08-05 13:12:04 EDT ---
Git done (by process-git-requests).

[Bug 621242] Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=621242

Akira TAGOH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #6 from Akira TAGOH  2010-08-06 03:08:13 EDT ---
Thanks. the packages has been built.

[Bug 621242] Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=621242

Akira TAGOH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #7 from Akira TAGOH  2011-08-23 23:35:46 EDT ---
Package Change Request
======================
Package Name: gyp
New Branches: el5 el6
Owners: tagoh
InitialCC:

[Bug 621242] Review Request: gyp - Generate Your Projects

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=621242

--- Comment #8 from Jon Ciesla  2011-08-24 05:58:59 EDT ---
Git done (by process-git-requests).