[Bug 2267876] New: Review Request: qt6-qtquick3dphysics- Qt6 - Quick3D Physics Libraries and utilities
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
Bug ID: 2267876 Summary: Review Request: qt6-qtquick3dphysics- Qt6 - Quick3D Physics Libraries and utilities Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loise@kde.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/loise/update-testing/fedo... SRPM URL: https://download.copr.fedorainfracloud.org/results/loise/update-testing/fedo... Description: Qt6 - Quick3D Physics Libraries and utilities Fedora Account System Username:loise
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Cannot find any valid SRPM URL for this ticket. Common causes are:
- You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
loise@kde.org loise@kde.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from loise@kde.org loise@kde.org --- SPEC: https://download.copr.fedorainfracloud.org/results/loise/update-testing/fedo... SRPM: https://download.copr.fedorainfracloud.org/results/loise/update-testing/fedo...
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
--- Comment #3 from loise@kde.org loise@kde.org --- Spec URL:https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysic... SRPM URL:https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysic... Description: Qt6 - Quick3D Physics Libraries and utilities Fedora Account System Username:loise
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jgrulich@redhat.com Assignee|nobody@fedoraproject.org |jgrulich@redhat.com Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@bachelot.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(loise@kde.org)
--- Comment #4 from Jan Grulich jgrulich@redhat.com --- 1) Looks like BR: qt6-qtbase-static and qt6-qtdeclarative-static are not needed? At least I can build it without it and don't see any complain 2) The commented workaround can be dropped if the issue was fixed in GCC? 3) Was there an alternative of the cooker binary in Qt5? If not, we might not need to add the -qt6 suffix? 4) I think the thing checking "QMAKE_PRL_BUILD_DIR" is not needed? I guess it's not needed in any of Qt6 package we have and should be perhaps removed? I'm guessing because it's qmake related and we don't use qmake anymore. I also don't see any *.la library being installed. 5) Shouldn't this package own %{_qt6_libdir}/cmake/Qt6Quick3DPhysics and similar directories?
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
loise@kde.org loise@kde.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(loise@kde.org) |
--- Comment #5 from loise@kde.org loise@kde.org --- (In reply to Jan Grulich from comment #4)
- Looks like BR: qt6-qtbase-static and qt6-qtdeclarative-static are not
needed? At least I can build it without it and don't see any complain
Well, then drop them :)
- The commented workaround can be dropped if the issue was fixed in GCC?
Yes
- Was there an alternative of the cooker binary in Qt5? If not, we might
not need to add the -qt6 suffix?
That's already a presumption that we will end up with a -qt7 version in the future. The package is new, so you're right, it's not needed really. Drop it if you want :)
- I think the thing checking "QMAKE_PRL_BUILD_DIR" is not needed? I guess
it's not needed in any of Qt6 package we have and should be perhaps removed? I'm guessing because it's qmake related and we don't use qmake anymore. I also don't see any *.la library being installed.
yes, we're using cmake, not qmake. I simply copied that from another qt6 package :) so drop it if we drop it everywhere ?
- Shouldn't this package own %{_qt6_libdir}/cmake/Qt6Quick3DPhysics and
similar directories?
ah yes, I'm sorry I forgot that. It's owned only by this package, yes.
Do you want me to fix this or are you doing it while at it and just import so we get this out the door ? admin will be kde-sig anyway, so there's not necessity for me to own the package at all.
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
--- Comment #6 from Jan Grulich jgrulich@redhat.com --- Please, fix it and post here updated SPEC file :).
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
--- Comment #7 from loise@kde.org loise@kde.org --- Spec URL: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysic... SRPM URL: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysic...
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
--- Comment #8 from Jan Grulich jgrulich@redhat.com --- I think we need to use "%dir path" for every directory owned by the package.
E.g. %dir %{_qt6_libdir}/cmake/Qt6Quick3DPhysics/ %{_qt6_libdir}/cmake/Qt6Quick3DPhysics/*.cmake
At least that's my understanding of this macro and that without it, when uninstalling, it would remove all the files in that directory, except the directory itself.
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
--- Comment #9 from loise@kde.org loise@kde.org --- Spec URL: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysic... SRPM Url: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysic...
Sorry, I forgot about that part :) fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
--- Comment #10 from Jan Grulich jgrulich@redhat.com --- Doesn't it report now that files are listed twice? :)
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
--- Comment #11 from loise@kde.org loise@kde.org --- Spec URL: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysic... SRPM Url: https://download.copr.fedorainfracloud.org/results/loise/qt6-qtquick3dphysic...
Now they don't anymore :)
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #12 from Jan Grulich jgrulich@redhat.com --- Looks good to me now. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
loise@kde.org loise@kde.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |qt6-qtquick3dphysics- Qt6 - |qt6-qtquick3dphysics - Qt6 |Quick3D Physics Libraries |- Quick3D Physics Libraries |and utilities |and utilities
https://bugzilla.redhat.com/show_bug.cgi?id=2267876
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #13 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtquick3dphysics
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com