[Bug 817022] New: Review Request: perl-Test-Apocalypse - Apocalypse's favorite tests bundled into a simple interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Test-Apocalypse - Apocalypse's favorite tests bundled into a simple interface
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Summary: Review Request: perl-Test-Apocalypse - Apocalypse's favorite tests bundled into a simple interface Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ppisar@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://ppisar.fedorapeople.org/perl-Test-Apocalypse/perl-Test-Apocalypse.spe... SRPM URL: http://ppisar.fedorapeople.org/perl-Test-Apocalypse/perl-Test-Apocalypse-1.0... Description: This module greatly simplifies common author tests for modules heading towards CPAN. I was sick of copy/pasting the tons of t/foo.t scripts + managing them in every distribution. I thought it would be nice to bundle all of it into one module and toss it on CPAN :) That way, every time I update this module all of my distributions would be magically updated!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |816501, 816488, 816547, | |816538, 816656, 816571, | |816990
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Bug 817022 depends on bug 816488, which changed state.
Bug 816488 Summary: Review Request: perl-Test-Dir - Some simple tests on directories and folders https://bugzilla.redhat.com/show_bug.cgi?id=816488
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Bug 817022 depends on bug 816990, which changed state.
Bug 816990 Summary: Review Request: perl-Test-Pod-Spelling-CommonMistakes - Checks POD for common spelling mistakes https://bugzilla.redhat.com/show_bug.cgi?id=816990
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Bug 817022 depends on bug 816501, which changed state.
Bug 816501 Summary: Review Request: perl-Test-AutoLoader - Testing utility for autosplit/autoloaded modules https://bugzilla.redhat.com/show_bug.cgi?id=816501
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Bug 817022 depends on bug 816538, which changed state.
Bug 816538 Summary: Review Request: perl-Test-NoPlan - Check perl test files for no_plan https://bugzilla.redhat.com/show_bug.cgi?id=816538
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Bug 817022 depends on bug 816571, which changed state.
Bug 816571 Summary: Review Request: perl-Test-Pod-No404s - Checks POD for HTTP 404 links https://bugzilla.redhat.com/show_bug.cgi?id=816571
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Bug 817022 depends on bug 816547, which changed state.
Bug 816547 Summary: Review Request: perl-Test-NoBreakpoints - Test that files do not contain soft breakpoints https://bugzilla.redhat.com/show_bug.cgi?id=816547
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Bug 817022 depends on bug 816656, which changed state.
Bug 816656 Summary: Review Request: perl-Test-Pod-LinkCheck - Tests POD for invalid links https://bugzilla.redhat.com/show_bug.cgi?id=816656
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Flags| |fedora-review?
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- There is newer version 1.002 on cpan.org.
test t/apocalypse.t failed due to missing build require Test::NoWarnings.
Can't locate Test/NoWarnings.pm in @INC (@INC contains: /builddir/build/BUILD/Test-Apocalypse-1.001/blib/lib /builddir/build/BUILD/Test-Apocalypse-1.001/blib/arch /usr/local/lib/perl5 /usr/local/share/perl5 /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5 /usr/share/perl5 .) at t/apocalypse.t line 19. t/apocalypse.t ..
https://koji.fedoraproject.org/koji/taskinfo?taskID=4212311
https://bugzilla.redhat.com/show_bug.cgi?id=817022
--- Comment #2 from Petr Pisar ppisar@redhat.com --- Upgraded package is available on:
Spec URL: http://ppisar.fedorapeople.org/perl-Test-Apocalypse/perl-Test-Apocalypse.spe... SRPM URL: http://ppisar.fedorapeople.org/perl-Test-Apocalypse/perl-Test-Apocalypse-1.0...
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Jitka Plesnikova jplesnik@redhat.com --- Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 [-]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [-]: MUST Large documentation files are in a -doc subpackage, if required. [-]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
Generated by fedora-review 0.2.0git External plugins:
Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=817022
--- Comment #4 from Petr Pisar ppisar@redhat.com --- New Package SCM Request ======================= Package Name: perl-Test-Apocalypse Short Description: Apocalypse's favorite tests bundled into a simple interface Owners: ppisar jplesnik mmaslano pssabata Branches: InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=817022
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Corrected pssabata->psabata.
https://bugzilla.redhat.com/show_bug.cgi?id=817022
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Test-Apocalypse-1.002- | |1.fc18 Resolution|--- |RAWHIDE Last Closed| |2012-07-03 08:37:29
--- Comment #6 from Petr Pisar ppisar@redhat.com --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla