[Bug 2292943] New: Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

Bug ID: 2292943
           Summary: Review Request: polylabel - A fast algorithm for
                    finding the pole of inaccessibility of a polygon
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://tomh.fedorapeople.org/polylabel.spec
SRPM URL: https://tomh.fedorapeople.org/polylabel-1.1.0-1.fc40.src.rpm

Description:
A fast algorithm for finding polygon pole of inaccessibility, the most
distant internal point from the polygon outline.

Useful for optimal placement of a text label on a polygon.

Fedora Account System Username: tomh

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

--- Comment #1 from Tom Hughes  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=119249914

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

Tom Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2275243
           Doc Type|---                         |If docs needed, set a value

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2275243
[Bug 2275243] mapnik-4.0.0 is available

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/mapbox/p
                   |                            |olylabel/
           Keywords|                            |AutomationTriaged

--- Comment #2 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7625356
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

Tom Rix  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

Tom Rix  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
              Flags|                            |fedora-review+

--- Comment #3 from Tom Rix  ---
Could update to v2.0.0 - came out this week.
Also add %dir %{_includedir}/mapbox to %files devel

Pretty simple header only package.
test passes

approved

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

--- Comment #4 from Tom Hughes  ---
Thanks for the review.

I'll update the version but I'm not clear why you think adding %dir would be
helpful? The directory is already added along with the files it contained and
the only thing %dir does it to make rpm package the directory without any files
it contains meaning they would then have to be listed separately, or is that
what you're suggesting?

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

--- Comment #5 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/polylabel

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

Tom Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2024-07-05 16:01:18

[Bug 2292943] Review Request: polylabel - A fast algorithm for finding the pole of inaccessibility of a polygon

https://bugzilla.redhat.com/show_bug.cgi?id=2292943

--- Comment #6 from Tom Rix  ---
(In reply to Tom Hughes from comment #4)
> Thanks for the review.
>
> I'll update the version but I'm not clear why you think adding %dir would be
> helpful? The directory is already added along with the files it contained
> and the only thing %dir does it to make rpm package the directory without
> any files it contains meaning they would then have to be listed separately,
> or is that what you're suggesting?

the fedora-review output had some (maybe spurious) warnings about dir
ownership.
i have used the %dir squash these warnings in my own spec files.