https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Bug ID: 1480973 Summary: Review Request: golang-github-alecthomas-kingpin - A Go command line and flag parser Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Description: A Go command line and flag parser
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1476589
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1476589 [Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1476590
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1476590 [Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE session settings
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1421046
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 [Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Hello,
- The _examples/ folder should go in %doc:
%doc _examples
And remove it from devel.file-list:
for file in $(find . -iname "*.go" ! -iname "*_test.go" ! -path "./_examples/*") ; do
- Change:
%dir %{gopath}/src/%{import_path}
to
%dir %{gopath}/src/%{import_path}/cmd
And remove: %{gopath}/src/%{import_path2}
(The import_path was already listed but the subdirectory cmd was not)
- Missing dependency:
DEBUG util.py:450: No matching package to install: 'golang(github.com/alecthomas/assert)' → Bug #1480971: accepted but not yet built. It seems you haven't yet requested the repo to be created with fedrepo-req. Please do it so we can move forward.
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
--- Comment #2 from sensor.wen@gmail.com --- Diff: https://github.com/FZUG/repo/commit/bba881590a66a510dbf653210ac5b23c96f0da0e
Fixed. the github-alecthomas-assert package is build passed, but it is not included in the rawhide. Maybe we need to wait some time.
https://src.fedoraproject.org/rpms/golang-github-alecthomas-assert
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- This is okay for me, package accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-kingpin
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |athoscribeiro@gmail.com
--- Comment #5 from Athos Ribeiro athoscribeiro@gmail.com --- Should this be closed?
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sztsian@gmail.com Alias| |golang-github-alecthomas-ki | |ngpin
https://bugzilla.redhat.com/show_bug.cgi?id=1480973
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:32:07
--- Comment #6 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org