Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=416471
Summary: Review Request: XSel -- manipulate the X selection Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nospam@thenerdshow.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://thenerdshow.com/rpm/xsel.spec SRPM URL: http://thenerdshow.com/rpm/xsel-0.9.6-1.fc8.src.rpm Description: XSel is a command-line program for getting and setting the contents of the X selection. Normally this is only accessible by manually highlighting information and pasting it with the middle mouse button.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: XSel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From wolfy@nobugconsulting.ro 2007-12-10 08:47 EST ------- - the URL is wrong. Nothing in xmms-pulse's page speaks about xsel. The correct one is http://www.vergenet.net/~conrad/software/xsel/ - Source0 should be http://www.vergenet.net/~conrad/software/xsel/download/xsel-0.9.6.tar.gz - you have duplicate BRs: libICE-devel (by libSM-devel), libX11-devel (by libXext-devel) -mock build fails: + make install DESTDIR=/var/tmp/xsel-0.9.6-1.fc9-root-mockbuild source='xsel.c' object='xsel.o' libtool=no \ DEPDIR=.deps depmode=none /bin/sh ./depcomp \ gcc -DHAVE_CONFIG_H -I. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=gene ric -fno-strict-aliasing -Wall -Werror -g -std=gnu99 -Wdeclaration-after-statement -Wno-unused -c xsel.c /bin/sh: ./depcomp: No such file or directory make: *** [xsel.o] Error 127 error: Bad exit status from /var/tmp/rpm-tmp.32486 (%install)
- please try to use parallel build make if possible ( http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b... ) -"Miscellaneous command line tools" is not one of the standard groups accepted in Fedora
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: XSel -- |Review Request: xsel -- |manipulate the X selection |manipulate the X selection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
nospam@thenerdshow.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.vergenet.net/~con | |rad/software/xsel/
------- Additional Comments From nospam@thenerdshow.com 2007-12-12 00:26 EST ------- That file was old. I don't know how it got in there.
Rebuilt from svn.
Got sources from here svn co http://svn.kfish.org/xsel/trunk/
This test spec uses GNU Autoconf. See changelog. http://thenerdshow.com/rpm/xsel-0.9.6-1.svn20071211.fc8.src.rpm http://thenerdshow.com/rpm/xsel.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From wolfy@nobugconsulting.ro 2007-12-12 05:20 EST ------- Nothing wrong in using a svn version if this is needed, but if doing so the script (or at least of a command) needed to recreate the tarball should be included in the spec. For instance something along #use "svn co http://svn.kfish.org/xsel/trunk/" to download this branch && mv trunk xsel-0.9.6 && tar cjf xsel-0.9.6.tar.bz2 xsel-0.9.6" to recreate the archive.Note that this is the only existing branch, there is no additional revision information available. However using xsel-0.9.6 as name for the tarball (as you have done ) is a bit confusing, since one might believe this is the stable version (which - on the URL page - has the same name). It would be better in my opinion to name the tarball xsel-0.9.6-svnsomething, as you have done for the src.rpm itself. It would also be useful to explain why are you packing the development version instead of the stable one listed on the project page, especially since the Changelog and NEWS files are identical in the two versions. And maybe poke upstream to update the stable version, 6 years for a devel version is long enough...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From pertusus@free.fr 2007-12-12 05:35 EST ------- How url should look like is also explained on: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a9...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From nospam@thenerdshow.com 2007-12-12 15:27 EST ------- Yes, there is a reason to build from svn. The release tarball has man in /usr/man instead of /usr/share/man
error: Installed (but unpackaged) file(s) found: /usr/man/man1/xsel.1x.gz
ls /usr/man ls: cannot access /usr/man: No such file or directory
I will re-write the spec file and change tarball name today. Thanks. Contacting the author re. this bug report and differences in /usr/man and /usr/share/man and maybe he can poke upstream since I don't have access.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From nospam@thenerdshow.com 2007-12-12 17:38 EST ------- Revised files are in http://thenerdshow.com/rpm/
%changelog * Wed Dec 12 2007 Henry Kroll <nospam[AT]thenerdshow.com> - 0.9.6-svn20071212 - Version upgrade svn due to differing man dir locations in configure script (and missing autogen.sh). Fix duplicate BuildRequires. Parallel make.
User Comment: I find xsel to be extremely handy when used with simple scripts that are bound to hot keys or mouse gestures.
<ctrl><alt><shift>d dictionary lookup on highlighted word(s) <ctrl><alt><shift>s search the web for highlighted word(s) <ctrl><alt><shift>t festival -tts (text to speech) on highlighted word(s)...
I have been using it for 2 months with no problems that I am aware of.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From wolfy@nobugconsulting.ro 2008-01-07 18:44 EST ------- WRT your suggested method to recreate the tarball: I see no real need to include the .svn folder. You need to add libtool as a BR, otherwise mock build fails. running rpmlint over your src.rpm gives: [wolfy@wolfy tmp]$ rpmlint xsel-0.9.6-1.svn20071212.fc8.src.rpm xsel.src:36: E: configure-without-libdir-spec xsel.src:37: E: configure-without-libdir-spec xsel.src: W: non-standard-group Miscellaneous command line tools In this case we can probably ignore the first two (I'll check tomorrow if this is true) but the last one should be fixed by picking a proper group. I'll try to do tomorrow a more thorough verification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From nospam@thenerdshow.com 2008-01-07 19:33 EST ------- Interesting. It builds on my mock without libtool but I am on x86_64 (shouldn't make a difference) there is a new version of mock out today for me to try out also. It doesn't seem to hurt to add libtool so I'll go ahead and add that.
I went ahead and changed the group to "User Interface/X" which is where other useful tools are, such as xrandr. The author has said version 0.9.7 will be out soon but until then svn should work fine. SVN updated to 20080107
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From wolfy@nobugconsulting.ro 2008-01-08 05:40 EST ------- I am building on x86_64, too, using [wolfy@wolfy tmp]$ repoquery --envra mock 0:mock-0.8.19-1.fc7.x86_64
Could you please provide the links for the new src.rpm/spec ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From nospam@thenerdshow.com 2008-01-08 21:05 EST ------- Same location. File date should reflect changes. My rpm junk bin: http://thenerdshow.com/rpm/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From pertusus@free.fr 2008-03-18 09:02 EST ------- Each time you do a new, please post the full url, it helps when getting it by mail and using for example wget from the command line to get it.
Without looking at the content, it looks like the release is wrong. It should be along 0.1.svn20080107
See http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From nospam@thenerdshow.com 2008-03-18 17:24 EST ------- New version is out. See http://www.vergenet.net/~conrad/software/xsel/ for tar.gz
Busy with work. Will update rpm tomorrow.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From nospam@thenerdshow.com 2008-03-20 19:22 EST ------- Updated xsel rpm to version 1.1.0 http://www.vergenet.net/~conrad/software/xsel/
Now using standard configure; make
http://thenerdshow.com/rpm http://thenerdshow.com/rpm/xsel.spec http://thenerdshow.com/rpm/xsel-1.1.0-1.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From pertusus@free.fr 2008-04-12 08:29 EST ------- The Source should be the url leading to the real file, like
Source0: http://www.vergenet.net/~conrad/software/xsel/download/xsel-%%7Bversion%7D.t...
Also the Url should better be like:
Url: http://www.vergenet.net/~conrad/software/xsel/ which leads to the package home page and description.
License looks like MIT (old style), looking at the web page http://fedoraproject.org/wiki/Licensing/MIT
For packaged releases (unlike snapshots), you shouldn't have the BuildRequires libtool, autoamke and autoconf (you can simply comment them out in case using svn snapshots is often useful for that package).
The requires for the Xserver is certainly wrong, unless this program requires a real X server and not the X abstraction (like the one provided by the ssh X redirection or vnc, or a real X server).
You should use the rpm macro %configure instead of doing it yourself.
The make call that does the compilation should be done in the %build and not in %install.
You should remove the package name from the summary, all the tools should use the name if needed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
nospam@thenerdshow.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |FutureFeature, OtherQA
------- Additional Comments From nospam@thenerdshow.com 2008-04-12 21:33 EST ------- New xsel rpm for version, 1.2.0 is available:
http://thenerdshow.com/rpm/xsel.spec http://thenerdshow.com/rpm/xsel-1.2.0-1.fc8.src.rpm
Other stuff, for the curious: http://thenerdshow.com/rpm/
%changelog * Sat Apr 12 2008 Henry Kroll <nospam[AT]thenerdshow.com> - 1.2.0 - Version upgrade. Change license to MIT. Fix URL, Requires, BuildRequires. Change group to Applications/System re: xclip. Include keywords in the description to make it easier to find.
I noticed another program, xclip, in the update repo that provides many of the same features as xsel. There are some important differences, however.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From pertusus@free.fr 2008-04-19 10:13 EST ------- Issues:
CFLAGS="$RPM_OPT_FLAGS", and --prefix=%{_prefix} --libdir=%{_libdir} are automatically set in %configure.
The CDEBUGFLAGS setting doesn't seems to be useful.
I suggest to break %changelog lines at about 80 columns and use - signs to create lists: - Version upgrade. - Change license to MIT Old Style. - Fix URL, Requires, BuildRequires. - Change group to Applications/System like xclip. Include keywords in the description to make it easier to find.
Remarks:
The application compile flags are still present, but they don't look harmful to me.
rpmlint says (wrongly) xsel.i386: W: no-version-in-last-changelog xsel-debuginfo.i386: W: no-version-in-last-changelog
It works well.
Match upstream 75983f143ce83dc259796c6eaf85c8f5 xsel-1.2.0.tar.gz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From nospam@thenerdshow.com 2008-04-19 15:40 EST ------- Thanks for the review. I'm not sure where the extra flags and options came from. I think I was trying to cross-build the rpm to x86_64 or vice-versa. Anyway, they're gone. rpmlint-0.82-2.fc8 reports nothing.
http://thenerdshow.com/rpm/xsel.spec http://thenerdshow.com/rpm/xsel-1.2.0-2.fc8.src.rpm
%changelog * Sat Apr 19 2008 Henry Kroll <nospam[AT]thenerdshow.com> - 1.2.0-2 - Standardize build section, remove unnecessary CDEBUGFLAGS. - Break up long lines, general cleanup.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From pertusus@free.fr 2008-04-19 16:43 EST ------- * follow guidelines * free software, license included * match upstream 75983f143ce83dc259796c6eaf85c8f5 RPM-fc/SOURCES/xsel-1.2.0.tar.gz * %files section right
1 suggestion: use %{_mandir}/man1/xsel.1x* to catch all compressions and no compressions.
APPROVED
Now you can point a potential sponsor to that submission or you can point me to your works such that I sponsor you (I have seen xmms-pulse).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |pertusus@free.fr Status|NEW |ASSIGNED
------- Additional Comments From pertusus@free.fr 2008-04-19 16:44 EST ------- And Manuel, you can also comment if you like.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From wolfy@nobugconsulting.ro 2008-04-19 21:13 EST ------- Thanks Patrice, but I am focusing on other reviews.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From pertusus@free.fr 2008-06-14 04:38 EST ------- Henry, are you ready to be sponsored?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-06-15 06:20 EST ------- (In reply to comment #21)
Henry, are you ready to be sponsored?
At least I am _not_ sponsoring Henry.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From tibbs@math.uh.edu 2008-07-05 13:54 EST ------- Is someone reviewing this? It's assigned to Patrice but fedora-review is blank so it still shows up as needing a reviewer.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From wolfy@nobugconsulting.ro 2008-07-05 16:29 EST ------- according to #18 this package has been approved, but the submitter was in need of a sponsor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From tibbs@math.uh.edu 2008-07-05 16:37 EST ------- Yes, but the person who approved it is a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
------- Additional Comments From wolfy@nobugconsulting.ro 2008-07-05 16:47 EST ------- Patrice is a sponsor, but at least until comment #18 he was not satisfied enough to sponsor Henry. Hence asking for more details.
I am setting the forgotten "under review" flag.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-05 21:26 EST ------- Perhaps Henry cannot work for Fedora packaging now: https://bugzilla.redhat.com/show_bug.cgi?id=416461#c25
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-14 11:32 EST ------- Anyone, ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
rakesh.pandit@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rakesh.pandit@gmail.com Status|NEEDINFO |ASSIGNED Flag|needinfo? |
------- Additional Comments From rakesh.pandit@gmail.com 2008-07-26 07:58 EST ------- As no one is interested I would like to take up this package further.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsel -- manipulate the X selection
https://bugzilla.redhat.com/show_bug.cgi?id=416471
rakesh.pandit@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |DUPLICATE
------- Additional Comments From rakesh.pandit@gmail.com 2008-07-26 08:42 EST -------
*** This bug has been marked as a duplicate of 456750 ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=416471
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla