[Bug 525274] New: Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Summary: Review Request: eclipse-callgraph - generates function
                    call graph linked to Eclipse CDT
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: https://fedoraproject.org/wiki/File:Eclipse-callgraph.spec
SRPM URL:
https://fedoraproject.org/wiki/File:Eclipse-callgraph-0.0.1-1.fc11.src.rpm
Description: C/C++ Call Graph Visualization Tool

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Andrew Overholt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

--- Comment #1 from Charley Wang   2009-09-23 15:18:17 EDT ---
Additional information:

This is a joint project between myself and Roland Grunberg. It is our first
package, and we are in need of a sponsor :)

Roland will be posting alternate URLs shortly (i.e. URLs that are not hosted on
the Fedora wiki, sorry about that)

-Charley

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Chitlesh GOORAH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Chitlesh GOORAH   2009-09-23 15:22:12 EDT ---
can you please verify if your plugin works under fedora's eclipse 3.5 on
rawhide ?

The plugins that I package are not loading on eclipse 3.5 ,see bug 
https://bugzilla.redhat.com/show_bug.cgi?id=523928

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Roland Grunberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Roland Grunberg   2009-09-23 16:14:01 EDT ---
Updated URLs to the Spec, and SRPM files :

Spec URL : http://akurtakov.fedorapeople.org/stap/Eclipse-callgraph.spec
SRPM URL :
http://akurtakov.fedorapeople.org/stap/Eclipse-callgraph-0.0.1-1.fc11.src.rp...
Description: C/C++ Call Graph Visualization Tool

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

--- Comment #4 from Roland Grunberg   2009-09-24 15:13:14 EDT ---
After some more updates :

URLs to the Spec, and SRPM files :

Spec URL : http://akurtakov.fedorapeople.org/stap/eclipse-callgraph.spec
SRPM URL :
http://akurtakov.fedorapeople.org/stap/eclipse-callgraph-0.0.1-1.fc11.src.rp...

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

--- Comment #5 from Andrew Overholt   2009-09-24 15:26:11 EDT ---
Thanks for the submission.  I know you used RPM Stubby to generate the
.spec from an Eclipse feature.xml and it did a nice job :)  There are
only a few issues with the review and they're listed below on the lines
beginning with an X.  Please fix them, bump the release and add a
comment in your .spec, and post new .spec and SRPM URLs here.  Once I've
verified it's fixed, we can move along with the process.  Thanks.

X please add a comment about the installation location (see below; the
  part about /usr/lib, dependencies, etc.)
X please capitalize the beginning of your changelog entry

Rest of review:
- licensing good
- fetch script is fine (contents match when I generate it myself)
- BRs/Rs okay
- macro usage fine
- %files fine
- builds and runs fine
- rpmlint not okay (but see above):

$ rpmlint eclipse-callgraph-0.0.1-1.fc11.i586.rpm
eclipse-callgraph.i586: E: no-binary
eclipse-callgraph.i586: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

- the warning is fine (we have to have this be arch-dependent due to its
  dependence on the arch-dependent CDT and therefore it must be in
  %{_libdir})
- there is no binary for the same reason as above

$ rpmlint eclipse-callgraph-0.0.1-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

--- Comment #6 from Charley Wang   2009-09-24 16:03:10 EDT ---
Updated srpm and spec URL's:

SRPM:
http://akurtakov.fedorapeople.org/stap/eclipse-callgraph-0.0.1-2.fc11.src.rp...
SPEC: http://akurtakov.fedorapeople.org/stap/eclipse-callgraph.spec

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Andrew Overholt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Andrew Overholt   2009-09-24 16:06:29 EDT ---
Thanks.  The %changelog entries should be more descriptive in the future but
I'll let it slide this time.  Approved.

I think you need to make this block FE-NEEDSPONSOR, right?

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Charley Wang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)
               Flag|fedora-review+              |fedora-review?

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Andrew Overholt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |

--- Comment #8 from Andrew Overholt   2009-09-24 16:24:52 EDT ---
I've sponsored Charley.  Charley, please go ahead with
https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure.

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

--- Comment #9 from Charley Wang   2009-09-24 16:33:13 EDT ---
New Package CVS Request
=======================
Package Name: eclipse-callgraph
Short Description: C/C++ Call Graph Visualization Tool
Owners: chwang rgrunber
Branches: 
InitialCC: chwang rgrunber akurtakov overholt

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

--- Comment #10 from Charley Wang   2009-09-24 16:36:49 EDT ---
New Package CVS Request
=======================
Package Name: eclipse-callgraph
Short Description: C/C++ Call Graph Visualization Tool
Owners: chwang rgrunber
Branches: 
InitialCC: chwang rgrunber akurtakov overholt

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

--- Comment #11 from Charley Wang   2009-09-24 16:39:18 EDT ---
(Modified, sorry for the triple post)

New Package CVS Request
=======================
Package Name: eclipse-callgraph
Short Description: C/C++ Call Graph Visualization Tool
Owners: chwang
Branches: 
InitialCC: chwang rgrunber akurtakov overholt

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Charley Wang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Andrew Overholt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Charley Wang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #12 from Dennis Gilmore   2009-09-25 11:35:00 EDT ---
CVS Done

[Bug 525274] Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525274

Charley Wang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE