Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Summary: Review Request: eclipse-callgraph - generates function call graph linked to Eclipse CDT Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: charley.wang@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: https://fedoraproject.org/wiki/File:Eclipse-callgraph.spec SRPM URL: https://fedoraproject.org/wiki/File:Eclipse-callgraph-0.0.1-1.fc11.src.rpm Description: C/C++ Call Graph Visualization Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Andrew Overholt overholt@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |overholt@redhat.com AssignedTo|nobody@fedoraproject.org |overholt@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
--- Comment #1 from Charley Wang charley.wang@gmail.com 2009-09-23 15:18:17 EDT --- Additional information:
This is a joint project between myself and Roland Grunberg. It is our first package, and we are in need of a sponsor :)
Roland will be posting alternate URLs shortly (i.e. URLs that are not hosted on the Fedora wiki, sorry about that)
-Charley
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Chitlesh GOORAH chitlesh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |chitlesh@gmail.com
--- Comment #2 from Chitlesh GOORAH chitlesh@gmail.com 2009-09-23 15:22:12 EDT --- can you please verify if your plugin works under fedora's eclipse 3.5 on rawhide ?
The plugins that I package are not loading on eclipse 3.5 ,see bug https://bugzilla.redhat.com/show_bug.cgi?id=523928
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Roland Grunberg rgrunber@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rgrunber@redhat.com
--- Comment #3 from Roland Grunberg rgrunber@redhat.com 2009-09-23 16:14:01 EDT --- Updated URLs to the Spec, and SRPM files :
Spec URL : http://akurtakov.fedorapeople.org/stap/Eclipse-callgraph.spec SRPM URL : http://akurtakov.fedorapeople.org/stap/Eclipse-callgraph-0.0.1-1.fc11.src.rp... Description: C/C++ Call Graph Visualization Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
--- Comment #4 from Roland Grunberg rgrunber@redhat.com 2009-09-24 15:13:14 EDT --- After some more updates :
URLs to the Spec, and SRPM files :
Spec URL : http://akurtakov.fedorapeople.org/stap/eclipse-callgraph.spec SRPM URL : http://akurtakov.fedorapeople.org/stap/eclipse-callgraph-0.0.1-1.fc11.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
--- Comment #5 from Andrew Overholt overholt@redhat.com 2009-09-24 15:26:11 EDT --- Thanks for the submission. I know you used RPM Stubby to generate the .spec from an Eclipse feature.xml and it did a nice job :) There are only a few issues with the review and they're listed below on the lines beginning with an X. Please fix them, bump the release and add a comment in your .spec, and post new .spec and SRPM URLs here. Once I've verified it's fixed, we can move along with the process. Thanks.
X please add a comment about the installation location (see below; the part about /usr/lib, dependencies, etc.) X please capitalize the beginning of your changelog entry
Rest of review: - licensing good - fetch script is fine (contents match when I generate it myself) - BRs/Rs okay - macro usage fine - %files fine - builds and runs fine - rpmlint not okay (but see above):
$ rpmlint eclipse-callgraph-0.0.1-1.fc11.i586.rpm eclipse-callgraph.i586: E: no-binary eclipse-callgraph.i586: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
- the warning is fine (we have to have this be arch-dependent due to its dependence on the arch-dependent CDT and therefore it must be in %{_libdir}) - there is no binary for the same reason as above
$ rpmlint eclipse-callgraph-0.0.1-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
--- Comment #6 from Charley Wang charley.wang@gmail.com 2009-09-24 16:03:10 EDT --- Updated srpm and spec URL's:
SRPM: http://akurtakov.fedorapeople.org/stap/eclipse-callgraph-0.0.1-2.fc11.src.rp... SPEC: http://akurtakov.fedorapeople.org/stap/eclipse-callgraph.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Andrew Overholt overholt@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Andrew Overholt overholt@redhat.com 2009-09-24 16:06:29 EDT --- Thanks. The %changelog entries should be more descriptive in the future but I'll let it slide this time. Approved.
I think you need to make this block FE-NEEDSPONSOR, right?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Charley Wang charley.wang@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR) Flag|fedora-review+ |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Andrew Overholt overholt@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #8 from Andrew Overholt overholt@redhat.com 2009-09-24 16:24:52 EDT --- I've sponsored Charley. Charley, please go ahead with https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
--- Comment #9 from Charley Wang charley.wang@gmail.com 2009-09-24 16:33:13 EDT --- New Package CVS Request ======================= Package Name: eclipse-callgraph Short Description: C/C++ Call Graph Visualization Tool Owners: chwang rgrunber Branches: InitialCC: chwang rgrunber akurtakov overholt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
--- Comment #10 from Charley Wang charley.wang@gmail.com 2009-09-24 16:36:49 EDT --- New Package CVS Request ======================= Package Name: eclipse-callgraph Short Description: C/C++ Call Graph Visualization Tool Owners: chwang rgrunber Branches: InitialCC: chwang rgrunber akurtakov overholt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
--- Comment #11 from Charley Wang charley.wang@gmail.com 2009-09-24 16:39:18 EDT --- (Modified, sorry for the triple post)
New Package CVS Request ======================= Package Name: eclipse-callgraph Short Description: C/C++ Call Graph Visualization Tool Owners: chwang Branches: InitialCC: chwang rgrunber akurtakov overholt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Charley Wang charley.wang@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Andrew Overholt overholt@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Charley Wang chwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Dennis Gilmore dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #12 from Dennis Gilmore dennis@ausil.us 2009-09-25 11:35:00 EDT --- CVS Done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525274
Charley Wang chwang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
package-review@lists.fedoraproject.org