[Bug 226000] New: Merge Review: libdv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226000

Summary: Merge Review: libdv
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: libdv

http://cvs.fedora.redhat.com/viewcvs/devel/libdv/
Initial Owner: [e-mail]

[Bug 226000] Merge Review: libdv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libdv

https://bugzilla.redhat.com/show_bug.cgi?id=226000

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-08-31 12:45 EST -------
Please find an updated spec file and a patch to the current spec file containing
some suggested changes and fixes :
http://thias.fedorapeople.org/merge-review/libdv/

- Update License field.
- Remove useless zero epoch.
- Add pkgconfig devel sub-package requirement.

The package was already quite clean overall :-)

[Bug 226000] Merge Review: libdv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libdv

https://bugzilla.redhat.com/show_bug.cgi?id=226000

------- Additional Comments From [e-mail]  2007-09-12 07:24 EST -------
Ping? It would be nice to get this package cleaned up for Fedora 8.

[Bug 226000] Merge Review: libdv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libdv

https://bugzilla.redhat.com/show_bug.cgi?id=226000

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2007-09-12 09:48 EST -------
libdv-1.0.0-2.fc8 built with all suggested updates and a few other minor spec
tweaks of my own.

[Bug 226000] Merge Review: libdv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libdv

https://bugzilla.redhat.com/show_bug.cgi?id=226000

------- Additional Comments From [e-mail]  2007-09-12 10:05 EST -------
Yeah, kill the tabs! :-)

One more minor change I forgot : The man pages in %files aren't listed
consistently, or even right. They should all be foo.1* with no foo.1.gz since
the compression used is an rpm build time option.

I also just double checked a rebuild, and it seems that this package got
affected by the recent rpm/popt split :
checking for poptGetContext in -lpopt... no
configure: WARNING: playdv needs the popt package for command line parsing.
                    The source archive for popt is available at:
                        ftp://ftp.redhat.com/pub/redhat/code/popt
So you need to add "BuildRequires: popt-devel".

Apart from this, the package looks good.

[Bug 226000] Merge Review: libdv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libdv

https://bugzilla.redhat.com/show_bug.cgi?id=226000

------- Additional Comments From [e-mail]  2007-09-12 10:23 EST -------
Okay, files list fixed up, as well as BR: on popt-devel, conditional on fedora
> = 8 added. Good catch on the popt-devel, I've mostly had my head in the sand

wrt fedora the past month or so focused on rhel5.1 work, had no clue there'd
been a change there.

[Bug 226000] Merge Review: libdv

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libdv

https://bugzilla.redhat.com/show_bug.cgi?id=226000

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-09-12 11:12 EST -------
(OT: Good to know, I'm impatient for RHEL5.1 to come out :-))

Thanks for fixing so quickly, review finished!