Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213765
Summary: Review Request: alex4 - Alex the Allegator 4 - Platform game Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: fedora-package-review@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/alex4.spec SRPM URL: http://people.atrpms.net/~hdegoede/alex4-1.0-1.src.rpm Description: In the latest installment of the series Alex travels through the jungle in search of his kidnapped girlfriend. Plenty of classic platforming in four nice colors guaranteed!
---
Hmm I just realised this needs work to work properly on PPC (I had to fix some file loading issues on x86_64, but there are endian issues in there too I realise now).
I'll report back here with an updated version for PPC soon.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: alex4 - Alex the Allegator 4 - Platform game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213765
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |paul@all-the-johnsons.co.uk OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: alex4 - Alex the Allegator 4 - Platform game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213765
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-11-02 17:31 EST ------- Two quickies.
1. why no _smp_mflags on the make? If it's down to a race condition, can you comment it please
2. --add-category X-Fedora is causing problems for me big style on rawhide. if you enclose it with a conditional that the branch of fedora is < "7", then I'm happy
rpmlint is quiet, so that's good :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: alex4 - Alex the Allegator 4 - Platform game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213765
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-11-03 03:23 EST ------- rpmlint is quiet builds fine in mock
Review - note, that you'll need something for #1 before it's approved (though you can ignore my first comment - I've just seen the smp_mflags!)
Good spec file clear and in US English upstream md5 and package md5 are the same license good consistent use of macros permissions fine update-icon-cache fine files permissions good package includes documentation no-devel package required package installs and runs fine (x86 and x86_64) - minimal test though
needs work --add-category X-Fedora annoys the buildsys for rawhide
Fix the needs work and it's good to go.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: alex4 - Alex the Allegator 4 - Platform game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213765
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-03 08:37 EST ------- Thanks for the review!
(In reply to comment #2)
needs work --add-category X-Fedora annoys the buildsys for rawhide
That is no longer a problem as there has been a new desktop-file-utils system in rawhide for a few days now which fixes this.
Fix the needs work and it's good to go.
Well what did really need fixing where the endian issues I already reported, here is a new version with those fixed (no other changes were made): Spec URL: http://people.atrpms.net/~hdegoede/alex4.spec SRPM URL: http://people.atrpms.net/~hdegoede/alex4-1.0-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: alex4 - Alex the Allegator 4 - Platform game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213765
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-11-03 09:59 EST ------- It looks good at this end.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: alex4 - Alex the Allegator 4 - Platform game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213765
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-03 10:52 EST ------- Thanks! Imported and build, closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla