8:18 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
Bug ID: 2186489
Summary: Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
Product: Fedora
Version: rawhide
Status: NEW
Component: Package Review
Assignee: nobody(a)fedoraproject.org
Reporter: topazus(a)outlook.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
SPEC URL:
https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-ra...
Description:
Quantum chemistry program executor and IO standardizer (QCSchema) for quantum
chemistry.
Fedora Account System Username: topazus
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
8:29 a.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
Jakub Kadlčík <jkadlcik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://github.com/MolSSI/Q
| |CEngine
--- Comment #1 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5778866
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...
Please take a look if any issues were found.
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
9:29 a.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
Felix Wang <topazus(a)outlook.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
--- Comment #2 from Felix Wang <topazus(a)outlook.com> ---
SPEC URL:
https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/topazus/test/fedora-ra...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
9:39 a.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
--- Comment #3 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
Created attachment 1957354
--> https://bugzilla.redhat.com/attachment.cgi?id=1957354&action=edit
The .spec file difference from Copr build 5778866 to 5779074
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
9:39 a.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
--- Comment #4 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5779074
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...
Please take a look if any issues were found.
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
12:54 p.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
Jonathan Wright <jonathan(a)almalinux.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
Assignee|nobody(a)fedoraproject.org |jonathan(a)almalinux.org
CC| |jonathan(a)almalinux.org
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
1:16 p.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
Jonathan Wright <jonathan(a)almalinux.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Flags|fedora-review? |fedora-review+
--- Comment #5 from Jonathan Wright <jonathan(a)almalinux.org> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 3-Clause License", "Unknown or generated", "*No
copyright*
Public domain", "*No copyright* [generated file]". 114 files have
unknown license. Detailed output of licensecheck in
/home/jonathan/fedora-review/2186489-python-qcengine/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: python3-qcengine-0.26.0-1.fc39.noarch.rpm
python-qcengine-0.26.0-1.fc39.src.rpm
==========================================================================================================
rpmlint session starts
=========================================================================================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpir3hg5r0')]
checks: 31, packages: 2
python3-qcengine.noarch: W: no-manual-page-for-binary qcengine
=========================================================================== 2
packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken
0.5 s
==========================================================================
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1
python3-qcengine.noarch: W: no-manual-page-for-binary qcengine
1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken
0.1 s
Source checksums
----------------
https://files.pythonhosted.org/packages/source/q/qcengine/qcengine-0.26.0...
:
CHECKSUM(SHA256) this package :
8c10377b11ffab311a2997ae9af80a0f4b4a9c3a6d65d96fd4aca4c941ecf018
CHECKSUM(SHA256) upstream package :
8c10377b11ffab311a2997ae9af80a0f4b4a9c3a6d65d96fd4aca4c941ecf018
Requires
--------
python3-qcengine (rpmlib, GLIBC filtered):
(python3.11dist(qcelemental) < 0.26~~ with python3.11dist(qcelemental) >=
0.24)
/usr/bin/python3
python(abi)
python3.11dist(psutil)
python3.11dist(py-cpuinfo)
python3.11dist(pydantic)
python3.11dist(pyyaml)
Provides
--------
python3-qcengine:
python-qcengine
python3-qcengine
python3.11-qcengine
python3.11dist(qcengine)
python3dist(qcengine)
Package is approved!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
7:22 p.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
--- Comment #6 from Felix Wang <topazus(a)outlook.com> ---
Thank you for taking the package review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
7:23 p.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
--- Comment #7 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org> ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-qcengine
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
7:42 p.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |MODIFIED
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2023-4557b255f0 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-4557b255f0
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
7:44 p.m.
New subject: [Bug 2186489] Review Request: python-qcengine - A compute wrapper
for Quantum Chemistry.
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |ERRATA
Last Closed| |2023-04-14 00:44:49
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2023-4557b255f0 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2186489
438
days inactive
439
days old
package-review@lists.fedoraproject.org
10 comments
1 participants
participants (1)
-
bugzilla＠redhat.com