https://bugzilla.redhat.com/show_bug.cgi?id=1677079
Bug ID: 1677079 Summary: Review Request: cros-guest-tools - Tools for Chromium OS integration Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jmontleo@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jmontleon/crostini/fedora-29... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jmontleon/crostini/fedora-29... Description: Packages necessary forChromium OS integration when running fedora under crostini Fedora Account System Username: jmontleon
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Group: System is not used in Fedora
- If you package a dev snapshot, you must include the snapshot date in Release and the Release should stast with 0.x:
%global hash bf01129 %global snapshotdate 20190213
Release: 0.3.%{snapshotdate}git%{hash}%{?dist}
- Shouldn't be needed as everything is noarch:
%global debug_package %{nil}
- Use macros here:
Source0: https://chromium.googlesource.com/chromiumos/containers/cros-container-guest...
- You need to validate the .desktop file you install: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_ins...
- You are using the wrong SystemD scriptlets, you must be using the *user* scriptlets systemd_user_post in %post and systemd_user_preun in %preun for *user* service files:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_...
- Own this directory:
[!]: Package requires other packages for directories it uses. Note: No known owner of /etc/gtk-3.0
- Remove dots at the end of Summaries:
- Split description lines to stay below 80 characters per line
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in cros-garcon, cros-pulse- config, cros-sftp, cros-sommelier, cros-sommelier-config See: https://fedoraproject.org/wiki/Packaging:Scriptlets#User_units - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-clause "New" or "Revised" License", "Unknown or generated". 106 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/cros-guest-tools/review- cros-guest-tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/gtk-3.0 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cros- systemd-overrides , cros-adapta , cros-garcon , cros-notificationd , cros-pulse-config , cros-sftp , cros-sommelier , cros-sommelier-config , cros-ui-config , cros-wayland [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: cros-guest-tools-1.0-3.bf01129.fc30.noarch.rpm cros-systemd-overrides-1.0-3.bf01129.fc30.noarch.rpm cros-adapta-1.0-3.bf01129.fc30.noarch.rpm cros-garcon-1.0-3.bf01129.fc30.noarch.rpm cros-notificationd-1.0-3.bf01129.fc30.noarch.rpm cros-pulse-config-1.0-3.bf01129.fc30.noarch.rpm cros-sftp-1.0-3.bf01129.fc30.noarch.rpm cros-sommelier-1.0-3.bf01129.fc30.noarch.rpm cros-sommelier-config-1.0-3.bf01129.fc30.noarch.rpm cros-ui-config-1.0-3.bf01129.fc30.noarch.rpm cros-wayland-1.0-3.bf01129.fc30.noarch.rpm cros-guest-tools-1.0-3.bf01129.fc30.src.rpm cros-guest-tools.noarch: W: no-documentation cros-guest-tools.noarch: W: hidden-file-or-dir /etc/skel/.config cros-systemd-overrides.noarch: W: summary-not-capitalized C systemd overrides for running under Chromium OS. cros-systemd-overrides.noarch: W: summary-ended-with-dot C systemd overrides for running under Chromium OS. cros-systemd-overrides.noarch: W: no-documentation cros-adapta.noarch: W: spelling-error %description -l en_US symlinks -> slinks cros-adapta.noarch: E: description-line-too-long C This package provides symlinks which link the bind-mounted theme into the correct location in the container. cros-adapta.noarch: W: no-documentation cros-adapta.noarch: W: dangling-symlink /usr/share/themes/CrosAdapta /opt/google/cros-containers/cros-adapta cros-garcon.noarch: W: summary-ended-with-dot C Chromium OS Garcon Bridge. cros-garcon.noarch: E: description-line-too-long C This package provides the systemd unit files for Garcon, the bridge to Chromium OS. cros-garcon.noarch: W: no-documentation cros-garcon.noarch: W: non-conffile-in-etc /etc/skel/.config/cros-garcon.conf cros-garcon.noarch: W: no-manual-page-for-binary garcon-terminal-handler cros-garcon.noarch: W: no-manual-page-for-binary garcon-url-handler cros-garcon.noarch: E: invalid-desktopfile /usr/share/applications/garcon_host_browser.desktop value "Never" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Never"; values extending the format should start with "X-" cros-garcon.noarch: W: desktopfile-without-binary /usr/share/applications/garcon_host_browser.desktop /opt/google/cros-containers/bin/garcon cros-notificationd.noarch: W: summary-ended-with-dot C Chromium OS Notification Bridge. cros-notificationd.noarch: W: no-documentation cros-pulse-config.noarch: W: summary-ended-with-dot C This package installs a helper systemd unit for PulseAudio support. cros-pulse-config.noarch: E: description-line-too-long C This is required as a workaround for the lack of udev in unprivileged containers. cros-pulse-config.noarch: W: no-documentation cros-sftp.noarch: W: spelling-error %description -l en_US unitfiles -> unit files, unit-files, unities cros-sftp.noarch: E: description-line-too-long C This package installs unitfiles and support scripts for enabling SFTP integration with Chromium OS. cros-sftp.noarch: W: no-documentation cros-sommelier.noarch: W: spelling-error Summary(en_US) unitfiles -> unit files, unit-files, unities cros-sommelier.noarch: W: summary-ended-with-dot C This package installs unitfiles and support scripts for sommelier. cros-sommelier.noarch: W: spelling-error %description -l en_US unitfiles -> unit files, unit-files, unities cros-sommelier.noarch: W: no-documentation cros-sommelier.noarch: W: non-conffile-in-etc /etc/profile.d/sommelier.sh cros-sommelier.noarch: W: non-conffile-in-etc /etc/sommelierrc cros-sommelier.noarch: E: non-executable-script /etc/sommelierrc 644 /bin/sh cros-sommelier.noarch: W: dangling-symlink /usr/bin/sommelier /opt/google/cros-containers/bin/sommelier cros-sommelier.noarch: W: no-manual-page-for-binary sommelier cros-sommelier-config.noarch: W: summary-not-capitalized C sommelier config for Chromium OS integration. cros-sommelier-config.noarch: W: summary-ended-with-dot C sommelier config for Chromium OS integration. cros-sommelier-config.noarch: E: description-line-too-long C This package installs default configuration for sommelier that is ideal for integration with Chromium OS. cros-sommelier-config.noarch: W: no-documentation cros-ui-config.noarch: E: description-line-too-long C This package installs default configuration for GTK+ that is ideal for integration with Chromium OS. cros-ui-config.noarch: W: no-documentation cros-ui-config.noarch: W: non-conffile-in-etc /etc/dconf/db/local.d/01-cros-ui cros-ui-config.noarch: W: non-conffile-in-etc /etc/gtk-2.0/gtkrc cros-ui-config.noarch: W: non-conffile-in-etc /etc/gtk-3.0/settings.ini cros-ui-config.noarch: W: non-conffile-in-etc /etc/xdg/Trolltech.conf cros-wayland.noarch: W: spelling-error Summary(en_US) virtwl -> virtual cros-wayland.noarch: W: summary-ended-with-dot C Wayland extras for virtwl in Chromium OS. cros-wayland.noarch: E: description-line-too-long C This package provides config files and udev rules to improve the Wayland experience under CrOS. cros-wayland.noarch: W: no-documentation cros-wayland.noarch: W: non-conffile-in-etc /etc/skel/.config/weston.ini cros-wayland.noarch: W: udev-rule-in-etc /etc/udev/rules.d/10-cros-virtwl.rules cros-wayland.noarch: W: non-conffile-in-etc /etc/udev/rules.d/10-cros-virtwl.rules cros-guest-tools.src: W: file-size-mismatch cros-guest-tools-bf01129.tar.gz = 58555, https://chromium.googlesource.com/chromiumos/containers/cros-container-guest... = 58553 12 packages and 0 specfiles checked; 9 errors, 43 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
--- Comment #2 from Jason Montleon jmontleo@redhat.com --- Thank you, I made corrections and have an updated build:
https://copr-be.cloud.fedoraproject.org/results/jmontleon/crostini/fedora-29... https://copr-be.cloud.fedoraproject.org/results/jmontleon/crostini/fedora-29...
- Removed the group. From what I can see similar packages are either Unspecified or Applications/System, but https://fedoraproject.org/wiki/RPMGroups says that group is deprecated. - Added the snapshot date and updated the release as described, preceded with a '0.' and including the snapshot date. - Removed the debug_package global - Used macros in the Source0 line as described - Used desktop-file-validate to install the desktop file - Used systemd_user_post and systemd_user_preun scriptlets for systemd user service files - Owned /etc/gtk-3.0 - Removed dots from end of summary lines - Wrapped descriptions at 80 or less characters.
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
--- Comment #3 from Jason Montleon jmontleo@redhat.com --- Further clean up of lint warnings and errors.
https://copr-be.cloud.fedoraproject.org/results/jmontleon/crostini/fedora-29... https://copr-be.cloud.fedoraproject.org/results/jmontleon/crostini/fedora-29...
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- - Don't add ".fc29.x86_64" at the end of your %changelog entries, the dist tag should not be included here.
Seens ok otherwise, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
--- Comment #5 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cros-guest-tools
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- (In reply to Robert-André Mauchin from comment #1)
- Own this directory:
[!]: Package requires other packages for directories it uses. Note: No known owner of /etc/gtk-3.0
This is definitely a bug in our gtk3 package, because it should definitely be owned by that package, and this package requires it at runtime...
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- cros-guest-tools-1.0-0.6.20190213gitbf01129.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d88521f81b
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- cros-guest-tools-1.0-0.6.20190213gitbf01129.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d88521f81b
https://bugzilla.redhat.com/show_bug.cgi?id=1677079
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-02-27 03:28:33
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- cros-guest-tools-1.0-0.6.20190213gitbf01129.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com