https://bugzilla.redhat.com/show_bug.cgi?id=865997
Bug ID: 865997 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: caledonia-kde-theme - a dark theme for KDE plasma Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: brendan.jones.it@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
This is a dark theme for KDE plasma
SRPM: http://bsjones.fedorapeople.org/caledonia-kde-theme-1.2.0-1.fc18.src.rpm SPEC: http://bsjones.fedorapeople.org/caledonia-kde-theme.spec
caledonia-kde-theme.src: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out caledonia-kde-theme.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out 2 packages and 0 specfiles checked; 0 errors, 2 warnings
https://bugzilla.redhat.com/show_bug.cgi?id=865997
Brendan Jones brendan.jones.it@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |805236 (FedoraAudio)
https://bugzilla.redhat.com/show_bug.cgi?id=865997
Jørn Lomax northlomax@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |northlomax@gmail.com Assignee|nobody@fedoraproject.org |northlomax@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=865997
Jørn Lomax northlomax@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|northlomax@gmail.com |nobody@fedoraproject.org
--- Comment #1 from Jørn Lomax northlomax@gmail.com --- The fedora-review script is failing me a little on this one, so i'm going through the steps manually.
$ rpmlint caledonia-kde-theme-1.2.0-1.fc17.noarch.rpm caledonia-kde-theme.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint caledonia-kde-theme-1.2.0-1.fc17.src.rpm caledonia-kde-theme.src: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint caledonia-kde-theme.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
No problems there
great to see in the .spec where the licence can be found. The licence checks out (from the README FILE):
[...] Some rights reserved. This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.
It builds cleanly, no issues found in the build log, and it installs locally without any issues. No issues found in the mock build log either
Great package!
***************** PACKAGE APPROVED* *****************
https://bugzilla.redhat.com/show_bug.cgi?id=865997
Jørn Lomax northlomax@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=865997
Jørn Lomax northlomax@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |northlomax@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=865997
Brendan Jones brendan.jones.it@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Brendan Jones brendan.jones.it@gmail.com --- Thanks for the review!
New Package SCM Request ======================= Package Name: caledonia-kde-theme Short Description: Desktop theme for plasma Owners: bsjones Branches:f16 f17 f18 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=865997
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=865997
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=865997
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- caledonia-kde-theme-1.2.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/caledonia-kde-theme-1.2.0-1.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=865997
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- caledonia-kde-theme-1.2.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/caledonia-kde-theme-1.2.0-1.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=865997
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- caledonia-kde-theme-1.2.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/caledonia-kde-theme-1.2.0-1.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=865997
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=865997
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- caledonia-kde-theme-1.2.0-1.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=865997
Brendan Jones brendan.jones.it@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-11-18 23:26:24
package-review@lists.fedoraproject.org