https://bugzilla.redhat.com/show_bug.cgi?id=2127450
Bug ID: 2127450 Summary: Review Request: haruna - video player built with Qt/QML and libmpv Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: zawertun@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://zawertun.fedorapeople.org/haruna.spec SRPM URL: https://zawertun.fedorapeople.org/haruna-0.9.1-1.fc36.src.rpm Description: Open source video player built with Qt/QML and libmpv Fedora Account System Username: zawertun
https://bugzilla.redhat.com/show_bug.cgi?id=2127450
Yaroslav Sidlovsky zawertun@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Yaroslav Sidlovsky zawertun@gmail.com --- Test build for Rawhide: https://copr.fedorainfracloud.org/coprs/zawertun/haruna/build/4840087/
https://bugzilla.redhat.com/show_bug.cgi?id=2127450
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vitaly@easycoding.org Flags| |fedora-review? Assignee|nobody@fedoraproject.org |vitaly@easycoding.org
--- Comment #2 from Vitaly Zaitsev vitaly@easycoding.org ---
BuildRequires: qt5-qtbase-private-devel
%{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}
BuildRequires: ffmpeg-free-devel
BuildRequires: pkgconfig(libavcodec) BuildRequires: pkgconfig(libavdevice) BuildRequires: pkgconfig(libavfilter) BuildRequires: pkgconfig(libavformat) BuildRequires: pkgconfig(libavutil) BuildRequires: pkgconfig(libpostproc) BuildRequires: pkgconfig(libswresample) BuildRequires: pkgconfig(libswscale)
https://bugzilla.redhat.com/show_bug.cgi?id=2127450
--- Comment #3 from Yaroslav Sidlovsky zawertun@gmail.com --- Thanks, new build with updated ffmpeg deps: https://copr.fedorainfracloud.org/coprs/zawertun/haruna/build/4840187/
https://bugzilla.redhat.com/show_bug.cgi?id=2127450
--- Comment #4 from Vitaly Zaitsev vitaly@easycoding.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Creative Commons CC0 1.0", "*No copyright* GNU General Public License, Version 3", "*No copyright* Creative Commons Attribution 4.0", "Unknown or generated", "BSD 3-Clause License", "GNU General Public License, Version 2", "GNU Library General Public License, Version 2.0", "*No copyright* BSD 3-Clause License", "GNU General Public License, Version 3", "Creative Commons Attribution 4.0", "*No copyright* Creative Commons Attribution-ShareAlike 4.0", "*No copyright* GNU General Public License, Version 2", "*No copyright* GNU Library General Public License, Version 2.0". 49 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/haruna/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://download.kde.org/stable/haruna/haruna-0.9.1.tar.xz.sig : CHECKSUM(SHA256) this package : 92bce14a98758c291978fd7ceea1cfedbe517ae173929db596db2364620645a8 CHECKSUM(SHA256) upstream package : 92bce14a98758c291978fd7ceea1cfedbe517ae173929db596db2364620645a8 https://download.kde.org/stable/haruna/haruna-0.9.1.tar.xz : CHECKSUM(SHA256) this package : 9131f2d3a44332ff65c15c77b243a9897cd7acc1d7fe77d75180bb519344840d CHECKSUM(SHA256) upstream package : 9131f2d3a44332ff65c15c77b243a9897cd7acc1d7fe77d75180bb519344840d
Requires -------- haruna (rpmlib, GLIBC filtered): hicolor-icon-theme kde-filesystem libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5ConfigWidgets.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5FileMetaData.so.3()(64bit) libKF5I18n.so.5()(64bit) libKF5KIOCore.so.5()(64bit) libKF5XmlGui.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Quick.so.5(Qt_5_PRIVATE_API)(64bit) libQt5QuickControls2.so.5()(64bit) libQt5QuickControls2.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5X11Extras.so.5()(64bit) libQt5X11Extras.so.5(Qt_5)(64bit) libavcodec.so.59()(64bit) libavcodec.so.59(LIBAVCODEC_59)(64bit) libavfilter.so.8()(64bit) libavfilter.so.8(LIBAVFILTER_8)(64bit) libavformat.so.59()(64bit) libavformat.so.59(LIBAVFORMAT_59)(64bit) libavutil.so.57()(64bit) libavutil.so.57(LIBAVUTIL_57)(64bit) libc.so.6()(64bit) libmpv.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libswscale.so.6()(64bit) libswscale.so.6(LIBSWSCALE_6)(64bit) rtld(GNU_HASH)
haruna-debuginfo (rpmlib, GLIBC filtered):
haruna-debugsource (rpmlib, GLIBC filtered):
Provides -------- haruna: application() application(org.kde.haruna.desktop) haruna haruna(x86-64) metainfo() metainfo(org.kde.haruna.metainfo.xml) mimehandler(application/mxf) mimehandler(application/ogg) mimehandler(application/sdp) mimehandler(application/smil) mimehandler(application/streamingmedia) mimehandler(application/vnd.apple.mpegurl) mimehandler(application/vnd.ms-asf) mimehandler(application/vnd.rn-realmedia) mimehandler(application/vnd.rn-realmedia-vbr) mimehandler(application/x-cue) mimehandler(application/x-extension-m4a) mimehandler(application/x-extension-mp4) mimehandler(application/x-matroska) mimehandler(application/x-mpegurl) mimehandler(application/x-ogg) mimehandler(application/x-ogm) mimehandler(application/x-ogm-audio) mimehandler(application/x-ogm-video) mimehandler(application/x-shorten) mimehandler(application/x-smil) mimehandler(application/x-streamingmedia) mimehandler(audio/3gpp) mimehandler(audio/3gpp2) mimehandler(audio/AMR) mimehandler(audio/aac) mimehandler(audio/ac3) mimehandler(audio/aiff) mimehandler(audio/amr-wb) mimehandler(audio/dv) mimehandler(audio/eac3) mimehandler(audio/flac) mimehandler(audio/m3u) mimehandler(audio/m4a) mimehandler(audio/mp1) mimehandler(audio/mp2) mimehandler(audio/mp3) mimehandler(audio/mp4) mimehandler(audio/mpeg) mimehandler(audio/mpeg2) mimehandler(audio/mpeg3) mimehandler(audio/mpegurl) mimehandler(audio/mpg) mimehandler(audio/musepack) mimehandler(audio/ogg) mimehandler(audio/opus) mimehandler(audio/rn-mpeg) mimehandler(audio/scpls) mimehandler(audio/vnd.dolby.heaac.1) mimehandler(audio/vnd.dolby.heaac.2) mimehandler(audio/vnd.dts) mimehandler(audio/vnd.dts.hd) mimehandler(audio/vnd.rn-realaudio) mimehandler(audio/vorbis) mimehandler(audio/wav) mimehandler(audio/webm) mimehandler(audio/x-aac) mimehandler(audio/x-adpcm) mimehandler(audio/x-aiff) mimehandler(audio/x-ape) mimehandler(audio/x-m4a) mimehandler(audio/x-matroska) mimehandler(audio/x-mp1) mimehandler(audio/x-mp2) mimehandler(audio/x-mp3) mimehandler(audio/x-mpegurl) mimehandler(audio/x-mpg) mimehandler(audio/x-ms-asf) mimehandler(audio/x-ms-wma) mimehandler(audio/x-musepack) mimehandler(audio/x-pls) mimehandler(audio/x-pn-au) mimehandler(audio/x-pn-realaudio) mimehandler(audio/x-pn-wav) mimehandler(audio/x-pn-windows-pcm) mimehandler(audio/x-realaudio) mimehandler(audio/x-scpls) mimehandler(audio/x-shorten) mimehandler(audio/x-tta) mimehandler(audio/x-vorbis) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-wav) mimehandler(audio/x-wavpack) mimehandler(video/3gp) mimehandler(video/3gpp) mimehandler(video/3gpp2) mimehandler(video/avi) mimehandler(video/divx) mimehandler(video/dv) mimehandler(video/fli) mimehandler(video/flv) mimehandler(video/mkv) mimehandler(video/mp2t) mimehandler(video/mp4) mimehandler(video/mp4v-es) mimehandler(video/mpeg) mimehandler(video/msvideo) mimehandler(video/ogg) mimehandler(video/quicktime) mimehandler(video/vnd.divx) mimehandler(video/vnd.mpegurl) mimehandler(video/vnd.rn-realvideo) mimehandler(video/webm) mimehandler(video/x-avi) mimehandler(video/x-flc) mimehandler(video/x-flic) mimehandler(video/x-flv) mimehandler(video/x-m4v) mimehandler(video/x-matroska) mimehandler(video/x-mpeg2) mimehandler(video/x-mpeg3) mimehandler(video/x-ms-afs) mimehandler(video/x-ms-asf) mimehandler(video/x-ms-wmv) mimehandler(video/x-ms-wmx) mimehandler(video/x-ms-wvxvideo) mimehandler(video/x-msvideo) mimehandler(video/x-ogm) mimehandler(video/x-ogm+ogg) mimehandler(video/x-theora) mimehandler(video/x-theora+ogg)
haruna-debuginfo: debuginfo(build-id) haruna-debuginfo haruna-debuginfo(x86-64)
haruna-debugsource: haruna-debugsource haruna-debugsource(x86-64)
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name haruna --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: PHP, Python, Haskell, Ocaml, Java, fonts, SugarActivity, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2127450
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Vitaly Zaitsev vitaly@easycoding.org --- LGTM. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2127450
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/haruna
https://bugzilla.redhat.com/show_bug.cgi?id=2127450
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-6e750c3ffd has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6e750c3ffd
https://bugzilla.redhat.com/show_bug.cgi?id=2127450
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2022-09-18 00:18:35
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-6e750c3ffd has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org