[Bug 1043157] New: Review Request: gnome-kra-ora-thumbnailer - Thumbnailer for Krita and MyPaint images
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
Bug ID: 1043157 Summary: Review Request: gnome-kra-ora-thumbnailer - Thumbnailer for Krita and MyPaint images Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: yaneti@declera.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://declera.com/~yaneti/gnome-kra-ora-thumbnailer/gnome-kra-ora-thumbnail... SRPM URL: http://declera.com/~yaneti/gnome-kra-ora-thumbnailer/gnome-kra-ora-thumbnail... Description: Thumbnailer for Krita and MyPaint images Fedora Account System Username: yaneti
gnome-kra-ora-thumbnailer.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/gnome-kra-ora-thumbnailer/COPYING I don't think this on is worth "fixing". The original of the license is probably CRLF terminated.... gnome-kra-ora-thumbnailer.x86_64: W: no-manual-page-for-binary gnome-openraster-thumbnailer gnome-kra-ora-thumbnailer.x86_64: W: no-manual-page-for-binary gnome-kra-thumbnailer 3 packages and 0 specfiles checked; 0 errors, 3 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
David King amigadave@amigadave.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |amigadave@amigadave.com Assignee|nobody@fedoraproject.org |amigadave@amigadave.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
David King amigadave@amigadave.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Whiteboard| |AwaitingSubmitter
--- Comment #1 from David King amigadave@amigadave.com --- Tested and works well, just a small licensing nitpick to fix. There are a couple of files in the sources that are GPLv2+ (gnome-thumbnailer-skeleton.c and gnome-thumbnailer-skeleton.h), so that needs to be mentioned in the spec and should be added to COPYING.GPL2 (or similar) upstream.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "WTFPL", "GPL (v2 or later)". Detailed output of licensecheck in /home/david/checkout/rpms/1043157-gnome-kra-ora- thumbnailer/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/thumbnailers(libgsf) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gnome-kra-ora-thumbnailer-1.2-1.fc21.x86_64.rpm gnome-kra-ora-thumbnailer-1.2-1.fc21.src.rpm gnome-kra-ora-thumbnailer.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/gnome-kra-ora-thumbnailer/COPYING gnome-kra-ora-thumbnailer.x86_64: W: no-manual-page-for-binary gnome-openraster-thumbnailer gnome-kra-ora-thumbnailer.x86_64: W: no-manual-page-for-binary gnome-kra-thumbnailer 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint gnome-kra-ora-thumbnailer gnome-kra-ora-thumbnailer.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/gnome-kra-ora-thumbnailer/COPYING gnome-kra-ora-thumbnailer.x86_64: W: no-manual-page-for-binary gnome-openraster-thumbnailer gnome-kra-ora-thumbnailer.x86_64: W: no-manual-page-for-binary gnome-kra-thumbnailer 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:'
Requires -------- gnome-kra-ora-thumbnailer (rpmlib, GLIBC filtered): libarchive.so.13()(64bit) libc.so.6()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) rtld(GNU_HASH)
Provides -------- gnome-kra-ora-thumbnailer: gnome-kra-ora-thumbnailer gnome-kra-ora-thumbnailer(x86-64)
Source checksums ---------------- http://download.gnome.org/sources/gnome-kra-ora-thumbnailer/1.2/gnome-kra-or... : CHECKSUM(SHA256) this package : c18f262d75df9c1fa05330b3347bc8a5420cebeb94398d60aa97a8abd77ef1b8 CHECKSUM(SHA256) upstream package : c18f262d75df9c1fa05330b3347bc8a5420cebeb94398d60aa97a8abd77ef1b8
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1043157 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
--- Comment #2 from Yanko Kaneti yaneti@declera.com --- Thanks a lot for the review. hadess released the next version relicensed to GPLv2+
Spec URL: http://declera.com/~yaneti/gnome-kra-ora-thumbnailer/gnome-kra-ora-thumbnail... SRPM URL: http://declera.com/~yaneti/gnome-kra-ora-thumbnailer/gnome-kra-ora-thumbnail...
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|AwaitingSubmitter |
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
David King amigadave@amigadave.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from David King amigadave@amigadave.com --- Looks good to go with the licensing problem fixed. Sorry for the delay.
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
--- Comment #4 from Yanko Kaneti yaneti@declera.com --- New Package SCM Request ======================= Package Name: gnome-kra-ora-thumbnailer Short Description: Thumbnailer for Krita and MyPaint images Owners: yaneti hadess Branches: f20 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- gnome-kra-ora-thumbnailer-1.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/gnome-kra-ora-thumbnailer-1.3-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- gnome-kra-ora-thumbnailer-1.3-1.fc20 has been pushed to the Fedora 20 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1043157
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |gnome-kra-ora-thumbnailer-1 | |.3-1.fc20 Resolution|--- |ERRATA Last Closed| |2014-01-02 17:00:24
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- gnome-kra-ora-thumbnailer-1.3-1.fc20 has been pushed to the Fedora 20 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla