https://bugzilla.redhat.com/show_bug.cgi?id=1373004
Bug ID: 1373004 Summary: Review Request: rubygem-tzinfo-data - Timezone Data for TZInfo Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: yguenane@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://gist.githubusercontent.com/Spredzy/81e5463da34aa4b13166eb4abed9b7b9/... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9145/15499145/rubygem-tzinfo-... Description: Timezone Data for TZInfo Fedora Account System Username: spredzy
https://bugzilla.redhat.com/show_bug.cgi?id=1373004
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #1 from Vít Ondruch vondruch@redhat.com --- I don't think we need this library on Fedora, since rubygem-tzinfo (as the only possible user of this package to my knowledge) is using system tzdata.
https://bugzilla.redhat.com/show_bug.cgi?id=1373004
--- Comment #2 from Yanis Guenane yguenane@redhat.com --- This package was initially created in order to be able to build fluentd[1], which has it as a dependency.
Per your command and after looking at the TZInfo documentation,
TZInfo requires a source of timezone data. There are two built-in options:
The separate TZInfo::Data library (the tzinfo-data gem). TZInfo::Data contains a set of Ruby modules that are generated from the IANA Time Zone Database. A zoneinfo directory. Most Unix-like systems include a zoneinfo directory containing timezone definitions. These are also generated from the IANA Time Zone Database.
By default, TZInfo::Data will be used. If TZInfo::Data is not available, then TZInfo will search for a zoneinfo directory instead.
So I will hold-on this one and see if I can proceed further without the need of this one. Thank you for pointing it out.
[1] https://rubygems.org/gems/fluentd/versions/0.12.5
https://bugzilla.redhat.com/show_bug.cgi?id=1373004
Sandro Bonazzola sbonazzo@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@redhat.com, | |rmeggins@redhat.com External Bug ID| |RDO 10682 Blocks| |1460625 (oVirt_on_Fedora) Flags| |needinfo?(mrunge@redhat.com | |)
--- Comment #3 from Sandro Bonazzola sbonazzo@redhat.com --- Bump to 1.2017.3 Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sbonazzo/ovirt-fluentd/rubyge... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sbonazzo/ovirt-fluentd/fedor...
Matthias can you please review? Also pushed to https://review.rdoproject.org/r/#/c/10682/
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1460625 [Bug 1460625] [Tracker] Fedora support
https://bugzilla.redhat.com/show_bug.cgi?id=1373004
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mrunge@redhat.com | |) |
--- Comment #4 from Matthias Runge mrunge@redhat.com --- For requirements discussion, see https://github.com/fluent/fluentd/issues/1761
https://bugzilla.redhat.com/show_bug.cgi?id=1373004
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- I still suggest drop the dependency in fluentd.spec. You can use something like:
~~~ %gemspec_remove_dep -g tzinfo-data "~> 1.0" ~~~
https://bugzilla.redhat.com/show_bug.cgi?id=1373004
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed| |2018-02-05 06:18:41
--- Comment #6 from Matthias Runge mrunge@redhat.com --- closing this.
package-review@lists.fedoraproject.org