[Bug 1111691] Review Request: qore - multithreaded programming/scripting language

https://bugzilla.redhat.com/show_bug.cgi?id=1111691

--- Comment #47 from Andy Mender  ---
> $ grep -e ^%package -e ^Requires: -e ^Recommends: -e ^BuildArch: qore.spec
> Requires: libqore%{?_isa} = %{version}-%{release}
> Requires: %{name}-stdlib%{?_isa} = %{version}-%{release}

Looks good.
> %package stdlib
> Requires: libqore%{?_isa} = %{version}-%{release}
> Recommends: %{name} = %{version}

Good.
> %package doc
> BuildArch: noarch
> Recommends: %{name} = %{version}

Good.
> %package devel
> Requires: libqore%{?_isa} = %{version}-%{release}
> Recommends: %{name} = %{version}

Hmm in the spec file I see the following:
%package devel
Summary: The header files needed to compile programs using the qore library
Requires: libqore%{?_isa} = %{version}-%{release}
Recommends: %{name}%{?_isa} = %{version}
> %package devel-doc
> BuildArch: noarch
> Recommends: %{name}-devel = %{version}

Good.
> %package misc-tools
> Requires: %{name} = %{version}-%{release}
> BuildArch: noarch

Good.
> They have been dropped from all noarch pkgs; do you mean that I should also drop the {%?_isa} from the libqore dependencies?

I think it's enough for the noarch packages.
> My take on the above guideline is based on a possibly more liberal interpretation of "base package".  For me the base package is libqore.  This is the fundamental package that has no other dependencies from the project and is usable by itself.  The qore package will be required for most use cases but not all.  libqore will always be required and is usable without qore and also without qore-stdlib, even if in the majority of realistic use cases, qore and qore-stdlib will be what users really want, and libqore will get installed in the background to support those.
>
> Possible installations in increasing order of capabilities:
>
> libqore
> An absolute minimum installation for embedded code support only - assuming an external custom API - no standard Qore runtime
>
> libqore + qore-stdlib 
> A more realistic minimal installation for embedded code support only, including the Qore standard runtime libraries
>
> libqore + qore-stdlib + qore
> The most common installation for normal scripting + embedded code.

Alright, I think this makes sense then. I'm simply not very experienced with
multi-package SPEC files.

I'm a little bothered by the mismatch in the source archive sizes as shown by
fedora-review:
> https://github.com/qorelanguage/qore/releases/download/release-0.9.4.6/qore-... :
>   CHECKSUM(SHA256) this package     : 6afbc3128bd0d67e81b736f167b1b1c710966f8fb48bd7ecb3f9608ea5a61220
>   CHECKSUM(SHA256) upstream package : 852141f7b3e1c6fdbc72fafa71e6b624a3963fa5d29de5d1b638098a8bef579a

I checked myself and the archive inside the SRPM indeed has a different size
than the one downloaded from GitHub. Could you maybe try switching to the
tar.gz source tarball instead?
https://github.com/qorelanguage/qore/archive/release-0.9.4.6.tar.gz
You would need to modify the URL line a bit.