[Bug 214057] New: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057

           Summary: Review Request: beneath-a-steel-sky - Beneath a Steel
                    Sky - Adventure Game
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: j.w.r.degoede(a)hhs.nl
         QAContact: fedora-package-review(a)redhat.com


Spec URL: http://people.atrpms.net/~hdegoede/beneath-a-steel-sky.spec
SRPM URL: http://people.atrpms.net/~hdegoede/beneath-a-steel-sky-0.0348-1.src.rpm
Description:
After the Dungeons and Dragons fantasy setting of Revolution's first game, Lure
of the Temptress, Revolution decided to go down a completely different avenue  
with its second adventure game, Beneath a Steel Sky, that of Science Fiction.  
A bleak vision of the future was imagined, where mind control and medical
science combined forces to repress the populace. Leading comic artist, Dave
Gibbons, joined the design team to visualise this desperate landscape. The 
result is the cult classic Beneath a Steel Sky.

Notice that this package contains the floppy version, the CD version is also
available in the %{name}-cd package. The CD version contains additional /   
longer cutscenes and voice acting, but also is much larger: the CD version ways
in at 70 MB where as this version is only 8 MB.

---

Note that this package requires scummvm, whose review request is here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055

I'll also be submitting the cd version sometime today. See the scummvm review
for all scummvm games which I'm submitting.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057


j.w.r.degoede(a)hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |214055




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057


chris.stone(a)gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody(a)fedoraproject.org    |chris.stone(a)gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |
              Alias|                            |scummvm-bass




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057





------- Additional Comments From chris.stone(a)gmail.com  2006-11-07 20:25 EST -------
Shouldn't this package Obsolete/Providess "bass" from Livna?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057





------- Additional Comments From j.w.r.degoede(a)hhs.nl  2006-11-08 02:31 EST -------
I see no bass in livna, atleast not for the development branch.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057


Bug 214057 depends on bug 214055, which changed state.

Bug 214055 Summary: Review Request: scummvm - Interpreter for several adventure games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057





------- Additional Comments From chris.stone(a)gmail.com  2006-11-08 12:21 EST -------
It's available for FC5:
http://rpm.livna.org/fedora/5/i386/repodata/repoview/bass-0-0-7.20030801....

And some people such as myself still have it installed.  That is, an upgrade to
FC6 or rawhide does not necessarily remove the bass package.

Therefore, I think this package should Obsolete/Provides bass.  I will do a
formal review later today, so hold off on fixing this until I've finished the
formal review incase I spot something else.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057





------- Additional Comments From chris.stone(a)gmail.com  2006-11-08 18:18 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output
W: beneath-a-steel-sky no-%build-section

rpmlint says you should add this section even if empty.  See rpmlint -I
no-%build-section.  I tend to agree.  While it might not make a difference now
(no debuginfo package is built but we dont care) there may be something in the
future which checks for this and there is no harm in adding it, so unless you
have a specific technical reason to comment it, id say just uncomment it.
- package named according to package naming guidelines (although a provides bass
might make it easier to install)
- spec filename matches package %{name}
- package meets packaging guidelines
- package is licensed as "Distributable"
FOR FURTHER DISCUSSION ON DISTRIBUTION RIGHTS SEE:
https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00030...
- License file included in %doc
- spec written in American english
- spec file is legible
- sources match upstream (however source0 location needs fixing)
cb968b4cfdde8491069915bf15d275b3  BASS-Floppy.zip
- package successfully compiles and builds on FC5 X86_64
- all dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- file permissions set properly
- package has proper %clean section
- macro usage is consistent
- package contains permissible content
- no large documentation
- no header files or static libraries
- no pkgconfig files
- no devel subpackage required
- no .la files
- package contains proper .desktop file
- package does not own files or directories owned by other packages

==== MUST ====
- Change location of Source0, this file is *NOT* located on sourceforge

==== SHOULD ====
- Add Obsolete/Provides for "bass"
- Uncomment %build
- Add in a comment above the License tag the URL pointing to the discussion on
the distribution:
https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00010...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057





------- Additional Comments From j.w.r.degoede(a)hhs.nl  2006-11-09 04:24 EST -------
(In reply to comment #4)
>  ==== MUST ====
>  - Change location of Source0, this file is *NOT* located on sourceforge
>  
>  ==== SHOULD ====
>  - Add Obsolete/Provides for "bass"
>  - Uncomment %build
>  - Add in a comment above the License tag the URL pointing to the discussion on
>  the distribution:
>  https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00010...
>   
Thanks!

All fixed / done, new version is here:
Spec URL: http://people.atrpms.net/~hdegoede/beneath-a-steel-sky.spec
SRPM URL: http://people.atrpms.net/~hdegoede/beneath-a-steel-sky-0.0348-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057


chris.stone(a)gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris.stone(a)gmail.com  2006-11-09 13:13 EST -------
All MUST and SHOULD items fixed.  APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 214057] Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: beneath-a-steel-sky - Beneath a Steel Sky - Adventure Game
Alias: scummvm-bass

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214057


j.w.r.degoede(a)hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE




------- Additional Comments From j.w.r.degoede(a)hhs.nl  2006-11-09 14:34 EST -------
Thanks! Imported and Build, closing.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.