https://bugzilla.redhat.com/show_bug.cgi?id=1828565
Bug ID: 1828565 Summary: Review Request: lcms - Color Management System Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: vitaly@easycoding.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://xvitaly.fedorapeople.org/for-review/lcms.spec SRPM URL: https://xvitaly.fedorapeople.org/for-review/lcms-1.19-29.fc32.src.rpm Description: LittleCMS intends to be a small-footprint, speed optimized color management engine in open source form. Fedora Account System Username: xvitaly
https://bugzilla.redhat.com/show_bug.cgi?id=1828565
Artem ego.cordatus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |ego.cordatus@gmail.com Assignee|nobody@fedoraproject.org |ego.cordatus@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review+
--- Comment #1 from Artem ego.cordatus@gmail.com --- This is re-review. You should mention this.
---
Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/lcms See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names
Not issue since this is re-review of retired package. Package approved.
---
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 151 files have unknown license. Detailed output of licensecheck in /mnt/data- linux/tmp/review/1828565-lcms/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 194560 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lcms- libs , lcms-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: lcms-1.19-29.fc33.x86_64.rpm lcms-libs-1.19-29.fc33.x86_64.rpm lcms-devel-1.19-29.fc33.x86_64.rpm lcms-debuginfo-1.19-29.fc33.x86_64.rpm lcms-debugsource-1.19-29.fc33.x86_64.rpm lcms-1.19-29.fc33.src.rpm lcms.x86_64: W: manual-page-warning /usr/share/man/man1/icc2ps.1.gz 22: warning: macro `p' not defined lcms.x86_64: W: manual-page-warning /usr/share/man/man1/jpegicc.1.gz 40: warning: macro `p' not defined lcms.x86_64: W: manual-page-warning /usr/share/man/man1/tifficc.1.gz 52: warning: macro `p' not defined lcms.x86_64: W: no-manual-page-for-binary icctrans lcms.x86_64: W: no-manual-page-for-binary tiffdiff lcms-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liblcms.so.1.0.19 exit@GLIBC_2.2.5 6 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (debuginfo) ------------------- Checking: lcms-libs-debuginfo-1.19-29.fc33.x86_64.rpm lcms-debuginfo-1.19-29.fc33.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- lcms.x86_64: W: no-manual-page-for-binary icctrans lcms.x86_64: W: no-manual-page-for-binary tiffdiff lcms-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liblcms.so.1.0.19 exit@GLIBC_2.2.5 6 packages and 0 specfiles checked; 0 errors, 3 warnings.
Source checksums ---------------- https://downloads.sourceforge.net/lcms/lcms-1.19.tar.gz : CHECKSUM(SHA256) this package : 80ae32cb9f568af4dc7ee4d3c05a4c31fc513fc3e31730fed0ce7378237273a9 CHECKSUM(SHA256) upstream package : 80ae32cb9f568af4dc7ee4d3c05a4c31fc513fc3e31730fed0ce7378237273a9
Requires -------- lcms (rpmlib, GLIBC filtered): lcms-libs(x86-64) libc.so.6()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblcms.so.1()(64bit) libm.so.6()(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) rtld(GNU_HASH)
lcms-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH)
lcms-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config lcms-libs(x86-64) liblcms.so.1()(64bit)
lcms-debuginfo (rpmlib, GLIBC filtered):
lcms-debugsource (rpmlib, GLIBC filtered):
Provides -------- lcms: lcms lcms(x86-64) littlecms(x86-64)
lcms-libs: lcms-libs lcms-libs(x86-64) liblcms.so.1()(64bit) littlecms-libs(x86-64)
lcms-devel: lcms-devel lcms-devel(x86-64) littlecms-devel(x86-64) pkgconfig(lcms)
lcms-debuginfo: debuginfo(build-id) lcms-debuginfo lcms-debuginfo(x86-64)
lcms-debugsource: lcms-debugsource lcms-debugsource(x86-64)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1828565 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: SugarActivity, PHP, R, Java, Haskell, Perl, Python, Ocaml, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1828565
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #2 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-ce7e64c65a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ce7e64c65a
https://bugzilla.redhat.com/show_bug.cgi?id=1828565
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2020-05-01 04:06:27
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-ce7e64c65a has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com