[Bug 241483] New: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

Summary: Review Request: ocaml-expat - OCaml wrapper for the
                    Expat XML parsing library
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://annexia.org/tmp/ocaml-expat.spec
SRPM URL: http://annexia.org/tmp/ocaml-expat-0.9.1-1.src.rpm
Description: This is a wrapper around the expat library.

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |240557

------- Additional Comments From [e-mail]  2007-06-09 19:55 EST -------
Added bug dependency which must be review first.

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |241487
              nThis|                            |

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

------- Additional Comments From [e-mail]  2007-06-11 15:45 EST -------
Spec URL: http://annexia.org/tmp/ocaml-expat.spec
SRPM URL: http://annexia.org/tmp/ocaml-expat-0.9.1-2.src.rpm

Updated to latest OCaml packaging guidelines.
Built against OCaml 3.10.
Tested against bytecode-only architectures.

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

------- Additional Comments From [e-mail]  2007-06-11 15:46 EST -------
Spec URL: http://annexia.org/tmp/ocaml/ocaml-expat.spec
SRPM URL: http://annexia.org/tmp/ocaml/ocaml-expat-0.9.1-2.src.rpm

(URLs fixed)

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

------- Additional Comments From [e-mail]  2007-06-20 07:03 EST -------
This is missing a BuildRequires of expat-devel.  Updated files here:

http://annexia.org/tmp/ocaml/ocaml-expat.spec
http://annexia.org/tmp/ocaml/ocaml-expat-0.9.1-3.src.rpm

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

Bug 241483 depends on bug 240557, which changed state.

Bug 240557 Summary: Review Request: ocaml-findlib - Objective CAML package manager and build helper
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240557

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

------- Additional Comments From [e-mail]  2007-07-26 23:44 EST -------
Starting review...

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

------- Additional Comments From [e-mail]  2007-08-01 20:20 EST -------
=== REQUIRED ITEMS ===

[ OK ] Package successfully compiles and builds on at least one supported arch.
 [ OK ] Mock built on x86_64 [ F-Devel ]
 [ OK ] Package is named according to the Package Naming and Ocaml Guidelines.
 [ OK ] Spec file name match the packaging naming Ocaml guidelines.
 [ Ok ] Package meets the Packaging Guidelines.
 [ OK ] Package is not relocatable.
 [ OK ] Buildroot is correct
 [ OK ] Package is licensed with an open-source compatible license.
 [ OK ] License field in the package spec file matches the actual license.
     License type: GPL
 [ OK ] Spec file is legible and written in American English.
 [ OK ] Package is not known to require ExcludeArch.
 [ OK ] All build dependencies are listed in BuildRequires.
 [ OK ] The spec file handles locales properly.
 [ OK ] ldconfig called in %post and %postun if required.
 [ OK ] Package must own all directories that it creates.
 [ OK ] Package requires other packages for directories it uses.
 [ OK ] Package does not contain duplicates in %files.
 [ OK ] Permissions on files are set properly.
 [ OK ] Package has a %clean section.
 [ OK ] Package consistently uses macros.
 [ OK ] Package contains code, or permissable content.
 [ SKIP ] Large documentation files are in a -doc subpackage, if required.
 [ OK ] Package uses nothing in %doc for runtime.
 [ SKIP ] Header files in -devel subpackage, if present.
 [ SKIP ] Static libraries in -devel subpackage, if present.
 [ SKIP ] Package requires pkgconfig, if .pc files are present.
 [ SKIP ] Development .so files in -devel subpackage, if present.
 [ CHECK ] Fully versioned dependency in subpackages, if present.
 [ OK ] Package does not contain any libtool archives (.la).
 [ SKIP ] Package contains a properly installed %{name}.desktop file.
 [ OK ] Package does not own files or directories owned by other packages

According to OCaml Packaging Guideline:

[ OK ] OCaml modules / libs should be named ocaml-foo.
 [ OK ] The spec file should still build bytecode libraries and binaries.
 [ OK ] Should Test if the native compiler is present.
 [ OK ] main package should contain files matching all files which mentioned in 
        OCaml guideline if present.
 [ OK ] -devel sub-package Should contains all files which're mentioned in OCaml
        guidelines if present.

[CHECK] Requires:
libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libexpat.so.0()(64bit)
ocaml(Callback) = e5ca1fb5990fac2b7b17cbb1712cffe2 ocaml(Pervasives) =
8ba3d1faa24d659525c9025f41fd0c57 ocaml = 3.10.0-1.fc8

[ ? ] rpmlint:

* on -devel package: silent

* on main package:
----------------------------------------------
W: ocaml-expat devel-file-in-non-devel-package /usr/lib64/ocaml/expat/expat.cmi

According to the OCaml guidelines, those can be ignored.

W: ocaml-expat unstripped-binary-or-object /usr/lib64/ocaml/stublibs/dllmlexpat.so
E: ocaml-expat binary-or-shlib-defines-rpath
/usr/lib64/ocaml/stublibs/dllmlexpat.so ['/usr/local/lib']

However those need some fix.

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

------- Additional Comments From [e-mail]  2007-08-01 20:21 EST -------
typo: lisence is LGPL

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

------- Additional Comments From [e-mail]  2007-08-02 09:04 EST -------
http://annexia.org/tmp/ocaml/ocaml-expat-0.9.1-4.fc8.src.rpm
http://annexia.org/tmp/ocaml/ocaml-expat.spec

Change log:

* Thu Aug  2 2007 Richard W.M. Jones  - 0.9.1-4
- ExcludeArch ppc64
- Remove rpath from the stublibs .so file.
- Strip the stublibs .so file.

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-08-02 11:25 EST -------
well,
All issues has been fixed.

==========
*APPROVED*
==========

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

------- Additional Comments From [e-mail]  2007-08-02 11:44 EST -------
New Package CVS Request
=======================
Package Name: ocaml-expat
Short Description: OCaml wrapper for the Expat XML parsing library
Owners: [e-mail]
Branches: F-7
InitialCC: [e-mail],[e-mail]

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-08-02 12:37 EST -------
cvs done.

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 241483] Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-expat - OCaml wrapper for the Expat XML parsing library

https://bugzilla.redhat.com/show_bug.cgi?id=241483

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide