[Bug 1264656] New: Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

Bug ID: 1264656
           Summary: Review Request: rubygem-ace-rails-ap  - The Ajax.org
                    Cloud9 Editor.
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rub...
SRPM URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ace-ra...
Description: The Ajax.org Cloud9 Editor (Ace) for the Rails 3.1+ asset
pipeline.
Fedora Account System Username: ilgrad

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

--- Comment #1 from Upstream Release Monitoring  ---
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
for f22-candidate and
git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

--- Comment #2 from Ilya Gradina  ---
(In reply to Upstream Release Monitoring from comment #1)
> jgrulich's scratch build of
> kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and
> git://pkgs.fedoraproject.org/
> kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed
> http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

It is mistake?

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Vít Ondruch  ---
Just a few quick points:

* What about test suite?
* How about bundling? This directory looks suspicious: %{gem_instdir}/vendor
* You list several BuildRequires which you definitely don't need ATM, since you
don't execute the test suite.
* We typically try to avoid build time dependency on Bundler as much as
possible. Not sure this will be the case, but its always worth asking.

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

--- Comment #4 from Ilya Gradina  ---
Thx Vit,

unfortunately the tests I have not found. I made the changes according to your
notes.

Spec URL: http://repo.clanwars.org/gitlab/rubygem-ace-rails-ap.spec
SRPM URL:
http://repo.clanwars.org/gitlab/rubygem-ace-rails-ap-4.0.0-2.fc24.src.rpm

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

--- Comment #5 from Upstream Release Monitoring  ---
ilgrad's scratch build of rubygem-ace-rails-ap-4.0.0-2.fc24.src.rpm for f24
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11266095

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

--- Comment #6 from Vít Ondruch  ---
(In reply to Ilya Gradina from comment #4)
> unfortunately the tests I have not found.

I see, no tests in upstream. Have you asked them? And even though there are no
tests, it is a good habit to leave note in the .spec file.

BTW how are you going address the bundling?

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

--- Comment #7 from Ilya Gradina  ---
Hi Vit,

New SPEC:
https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rub...
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ace-ra...

the question is set: https://github.com/codykrieger/ace-rails-ap/issues/22

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656

--- Comment #8 from Vít Ondruch  ---
(In reply to Vít Ondruch from comment #6)
> BTW how are you going address the bundling?

You still have not addressed this concern ^^. If you are going to keep the
bundled library, then you should at minimum:

1) Explain the reasons why.
2) Add the "bundled" provide.
3) Update the license, since the ACE appears to be of some BSD license.

[1] https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle