https://bugzilla.redhat.com/show_bug.cgi?id=2184737
Bug ID: 2184737 Summary: Review Request: R-discretization - Data Preprocessing, Discretization for Classification Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: iztok@iztok-jr-fister.eu QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/firefly-cpp/rpm-reviews/main/R-discretizat... SRPM URL: https://github.com/firefly-cpp/rpm-reviews/raw/main/R-discretization-1.0.1.1... Description: A collection of supervised discretization algorithms. It can also be grouped in terms of top-down or bottom-up, implementing the discretization algorithms. Fedora Account System Username: iztokf
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://CRAN.R-project.org/ | |package=%{packname}
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5746002 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
Iñaki Ucar i.ucar86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i.ucar86@gmail.com Assignee|nobody@fedoraproject.org |i.ucar86@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value
--- Comment #2 from Iñaki Ucar i.ucar86@gmail.com --- The package does not require testthat for checks. Please remove those bits. Relevant issues:
[!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://CRAN.R-project.org/package=discretization&version=1.0.1.1#/discr...
Note that you should use %{ver} instead of %{version} in the URL.
R-discretization.noarch: W: invalid-license GPL
See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
R-discretization.noarch: E: description-line-too-long be grouped in terms of top-down or bottom-up, implementing the discretization algorithms.
See https://fedoraproject.org/wiki/Common_Rpmlint_issues#description-line-too-lo...
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #3 from Iztok Fister Jr. iztok@iztok-jr-fister.eu --- Thanks.
Fixed now. Changes: https://github.com/firefly-cpp/rpm-reviews/commit/79a135ac347ea828149ffe809e...
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #4 from Iñaki Ucar i.ucar86@gmail.com --- Note that:
- GPL v2 is also allowed - Identifiers from the third column are legacy ones. SPDX identifiers are in the first column of the list.
So the license tag should be: GPL-2.0-or-later
Also, please always provide new Spec URL and SRPM URL for any change, so that a new check is automatically triggered.
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #5 from Iztok Fister Jr. iztok@iztok-jr-fister.eu --- SPEC: https://raw.githubusercontent.com/firefly-cpp/rpm-reviews/main/R-discretizat... SRPM: https://github.com/firefly-cpp/rpm-reviews/raw/main/R-discretization-1.0.1.1...
Thanks again for your quick response.
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #6 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1955948 --> https://bugzilla.redhat.com/attachment.cgi?id=1955948&action=edit The .spec file difference from Copr build 5746002 to 5746716
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #7 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5746716 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
Iñaki Ucar i.ucar86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #8 from Iñaki Ucar i.ucar86@gmail.com --- Thanks, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/R-discretization
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-6508fabab6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6508fabab6
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b8b5382510 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b8b5382510
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-6508fabab6 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6508fabab6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6508fabab6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b8b5382510 has been pushed to the Fedora 38 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b8b5382510
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-04-15 02:07:30
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b8b5382510 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2184737
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-6508fabab6 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org