https://bugzilla.redhat.com/show_bug.cgi?id=853692
Bug ID: 853692 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mate-settings-daemon - MATE Desktop settings daemon Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: dan.mashal@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-settings-daemon.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-settings-daemon-1.4.0-1.... Description: MATE Desktop settings daemon
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu Blocks| |840149 (MATE-DE-tracker) Alias| |mate-settings-daemon
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |853694 | |(mate-control-center)
https://bugzilla.redhat.com/show_bug.cgi?id=853692
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@googlemail.co | |m
--- Comment #1 from leigh scott leigh123linux@googlemail.com --- All these files belong in the main package and not in -devel
%{_libdir}/mate-settings-daemon-1.4.0/liba11y-keyboard.so %{_libdir}/mate-settings-daemon-1.4.0/libclipboard.so %{_libdir}/mate-settings-daemon-1.4.0/libfont.so %{_libdir}/mate-settings-daemon-1.4.0/libhousekeeping.so %{_libdir}/mate-settings-daemon-1.4.0/libkeybindings.so %{_libdir}/mate-settings-daemon-1.4.0/libkeyboard.so %{_libdir}/mate-settings-daemon-1.4.0/libmedia-keys.so %{_libdir}/mate-settings-daemon-1.4.0/libmouse.so %{_libdir}/mate-settings-daemon-1.4.0/libsmartcard.so %{_libdir}/mate-settings-daemon-1.4.0/libsound.so %{_libdir}/mate-settings-daemon-1.4.0/libtyping-break.so %{_libdir}/mate-settings-daemon-1.4.0/libxrandr.so %{_libdir}/mate-settings-daemon-1.4.0/libxrdb.so %{_libdir}/mate-settings-daemon-1.4.0/libxsettings.so
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #2 from Dan Mashal dan.mashal@gmail.com --- thanks leigh, but those are shared libaries. how to proceed?
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #3 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #2)
thanks leigh, but those are shared libaries. how to proceed?
Move them to the main package
# rpm -ql gnome-settings-daemon |grep /usr/lib64/gnome-settings-daemon-3.0 /usr/lib64/gnome-settings-daemon-3.0/a11y-keyboard.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/a11y-settings.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/background.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/clipboard.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/color.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/cursor.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/housekeeping.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/keyboard.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/liba11y-keyboard.so /usr/lib64/gnome-settings-daemon-3.0/liba11y-settings.so /usr/lib64/gnome-settings-daemon-3.0/libbackground.so /usr/lib64/gnome-settings-daemon-3.0/libclipboard.so /usr/lib64/gnome-settings-daemon-3.0/libcolor.so /usr/lib64/gnome-settings-daemon-3.0/libcursor.so /usr/lib64/gnome-settings-daemon-3.0/libgsd.so /usr/lib64/gnome-settings-daemon-3.0/libgsdwacom.so /usr/lib64/gnome-settings-daemon-3.0/libhousekeeping.so /usr/lib64/gnome-settings-daemon-3.0/libkeyboard.so /usr/lib64/gnome-settings-daemon-3.0/libmedia-keys.so /usr/lib64/gnome-settings-daemon-3.0/libmouse.so /usr/lib64/gnome-settings-daemon-3.0/liborientation.so /usr/lib64/gnome-settings-daemon-3.0/libpower.so /usr/lib64/gnome-settings-daemon-3.0/libprint-notifications.so /usr/lib64/gnome-settings-daemon-3.0/libsmartcard.so /usr/lib64/gnome-settings-daemon-3.0/libsound.so /usr/lib64/gnome-settings-daemon-3.0/libupdates.so /usr/lib64/gnome-settings-daemon-3.0/libxrandr.so /usr/lib64/gnome-settings-daemon-3.0/libxsettings.so /usr/lib64/gnome-settings-daemon-3.0/media-keys.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/mouse.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/orientation.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/power.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/print-notifications.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/smartcard.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/sound.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/updates.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/wacom.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/xrandr.gnome-settings-plugin /usr/lib64/gnome-settings-daemon-3.0/xsettings.gnome-settings-plugin
You also need to add mate-conf scriptlets
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #4 from Dan Mashal dan.mashal@gmail.com --- Fixed. Please check it.
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-settings-daemon.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-settings-daemon-1.4.0-2.... Description: MATE Desktop settings daemon
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
--- Comment #5 from Rex Dieter rdieter@math.unl.edu --- I can review this (later) today
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #6 from Rex Dieter rdieter@math.unl.edu --- 1. MUST remove BuildRequires: gcc-c++ it's included in http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
naming: ok
licensing: ok
2. sources: not ok Source0: http://vicodan.fedorapeople.org/mate-settings-daemon-1.4.0.tar.gz MUST use verifiable upstream sources or provide justification why you're not doing so.
scriptlets: ok (mostly, except for...)
3. MUST remove ldconfig from %pre,%post,%postun, this package has no shared libraries (just plugins), so it's not needed.
4. MUST own dir %{_libdir}/mate-settings-daemon-1.4.0/ I'd recommend just listing ^^ , instead of all items under that separately.
scriptlets
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |844150 (mate-desktop)
--- Comment #7 from Rex Dieter rdieter@math.unl.edu --- Fixed build with mate-desktop-1.4.1-11, so you can use upstream sources now.
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #8 from Dan Mashal dan.mashal@gmail.com --- OK.
Fixed:
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-settings-daemon.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-settings-daemon-1.4.0-3.... Description: MATE Desktop settings daemon
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #9 from Rex Dieter rdieter@math.unl.edu --- sources: ok $ md5sum *.xz 5d7608bf8b80f4847e6b146379568b83 mate-settings-daemon-1.4.0.tar.xz
5. MUST remove export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/:/usr/local/share/pkgconfig/ but I won't consider it a blocker here, but please do remove prior to doing any official builds
6. SHOULD remove %pre /sbin/ldconfig this scriptlet is only required in %post and %postun
7. SHOULD add Requires: mate-icon-theme for /usr/share/icons/mate parent dir ownership (or can you think of some place lower in the stack to add this dependency?)
8. SHOULD remove rpath hacks chrpath --delete %{buildroot}%{_libdir}/mate-settings-daemon-1.4.0/*.so chrpath --delete %{buildroot}%{_libexecdir}/msd-locate-pointer they're not needed
9. MUST own %{_libdir}/mate-settings-daemon-1.4.0/ I'd suggest simplifying the %files list to just ^^ , and not list each item under it individually.
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #10 from Rex Dieter rdieter@math.unl.edu --- oh, sorry, ignore item 6. Please do honor item 3, there are no shared libraries here, so no need for ldconfig scriplets at all.
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #11 from Dan Mashal dan.mashal@gmail.com --- chrpath is needed.. package was failing when i was building with out it.. ill double check in a bit.
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #12 from Rex Dieter rdieter@math.unl.edu --- prior to suggesting it, I tested that it built fine for me without chrpath on my box.
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #13 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #11)
chrpath is needed.. package was failing when i was building with out it.. ill double check in a bit.
The koji buildsystem doesn't require it to build. Did you add it to fix a local build issue on your PC?
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #14 from Dan Mashal dan.mashal@gmail.com --- Yeah that's why I said I need to debug. I'm still sitting in bed recovering from last night's hackathon. :) LOL
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #15 from Dan Mashal dan.mashal@gmail.com ---
- MUST remove
export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/:/usr/local/share/pkgconfig/ but I won't consider it a blocker here, but please do remove prior to doing any >official builds
Builds fail without this. Please check it.
- SHOULD remove
%pre /sbin/ldconfig this scriptlet is only required in %post and %postun
Done
- SHOULD add
Requires: mate-icon-theme for /usr/share/icons/mate parent dir ownership (or can you think of some place >lower in the stack to add this dependency?)
Done, no I can't.
- SHOULD remove rpath hacks
chrpath --delete %{buildroot}%{_libdir}/mate-settings-daemon-1.4.0/*.so chrpath --delete %{buildroot}%{_libexecdir}/msd-locate-pointer they're not needed
Done but rpmlint still complains.
- MUST own
%{_libdir}/mate-settings-daemon-1.4.0/ I'd suggest simplifying the %files list to just ^^ , and not list each item >under it individually.
Done.
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #16 from Dan Mashal dan.mashal@gmail.com --- Spec URL: http://vicodan.fedorapeople.org/matespec/mate-settings-daemon.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-settings-daemon-1.4.0-4.... Description: MATE Desktop settings daemon
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #17 from Rex Dieter rdieter@math.unl.edu --- Thanks, looks good, APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #18 from Dan Mashal dan.mashal@gmail.com --- New Package SCM Request ======================= Package Name: mate-settings-daemon Short Description: MATE Desktop settings daemon Owners: rdieter vicodan Branches: f16 f17 f18
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #19 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |860515 (mate-themes)
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #20 from Rex Dieter rdieter@math.unl.edu --- fyi, imported, building for rawhide now.
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|860515 (mate-themes) |
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- mate-settings-daemon-1.4.0-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-settings-daemon-1.4.0-5.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=853692
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- mate-settings-daemon-1.4.0-5.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=853692
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-10-14 20:49:30
--- Comment #23 from Dan Mashal dan.mashal@gmail.com --- not sure why bodhi isn't closing bugs but both f18 and f17 packages have been pushed to stable.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla