[Bug 645277] New: Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: puddletag - Feature rich, easy to use tag editor

https://bugzilla.redhat.com/show_bug.cgi?id=645277

           Summary: Review Request: puddletag - Feature rich, easy to use
                    tag editor
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: terjeros(a)phys.ntnu.no
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


spec: http://terjeros.fedorapeople.org/puddletag/puddletag.spec
srpm: http://terjeros.fedorapeople.org/puddletag/puddletag-0.9.6-1.fc12.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2546420
Description:

Puddletag is a audio tag editor similar program Mp3tag.

Unlike most taggers, it uses a spreadsheet-like layout so that all the
tags you want to edit by hand are visible and easily editable.

The usual tag editor features are supported like extracting tag
information from filenames, renaming files based on their tags by
using patterns (that you define, not crappy, uneditable ones).

Then there're Functions, which can do things like replace text, trim,
change the case of tags, etc. Actions can automate repetitive
tasks. You can import your QuodLibet library, lookup tags using
MusicBrainz, FreeDB or Amazon (though it's only good for cover art)
and more.

Supported formats: ID3v1, ID3v2 (mp3), MP4 (mp4, m4a, etc.),
VorbisComments (ogg, flac), Musepack (mpc), Monkey's Audio (.ape) and
WavPack (wv).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

Terje Røsten <terjeros(a)phys.ntnu.no&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |495324

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

Bug 645277 depends on bug 495324, which changed state.

Bug 495324 Summary: New version of pyparsing is available (1.5.1)
https://bugzilla.redhat.com/show_bug.cgi?id=495324

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |MODIFIED
             Status|MODIFIED                    |ON_QA
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #1 from Terje Røsten <terjeros(a)phys.ntnu.no&gt; 2010-12-06 04:44:00 EST
---
Update to latest release 0.9.7:

spec: http://terjeros.fedorapeople.org/puddletag/puddletag.spec
srpm: http://terjeros.fedorapeople.org/puddletag/puddletag-0.9.7-1.fc14.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2646294

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

Michael Schwendt <mschwendt(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt(a)gmail.com

--- Comment #2 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2010-12-27 13:46:14 EST
---
>  License:        GPLv2 
App's Help dialog says "GPLv2", but multiple source files are GPLv2+. Hence
the
full tag would be "GPLv2 and GPLv2+":

$ grep "any later version" * -R|grep .py
puddlestuff/tagmodel.py:#(at your option) any later version.
puddlestuff/puddlesettings.py:#(at your option) any later version.
puddlestuff/findfunc.py:#(at your option) any later version.
puddlestuff/actiondlg.py:#(at your option) any later version.
puddlestuff/puddleobjects.py:#(at your option) any later version.
puddlestuff/audioinfo/ogg.py:#(at your option) any later version.
puddlestuff/audioinfo/__init__.py:#(at your option) any later version.
puddlestuff/audioinfo/musepack.py:#(at your option) any later version.
puddlestuff/audioinfo/flac.py:#(at your option) any later version.
puddlestuff/audioinfo/mp4.py:#(at your option) any later version.
puddlestuff/audioinfo/apev2.py:#(at your option) any later version.
puddlestuff/audioinfo/wma.py:#(at your option) any later version.
puddlestuff/audioinfo/wavpack.py:#(at your option) any later version.
puddlestuff/audioinfo/util.py:#(at your option) any later version.
puddlestuff/helperwin.py:#(at your option) any later version.
puddlestuff/webdb.py:#(at your option) any later version.


>  URL:            http://puddletag.sourceforge.net 
0.9.11 has been released.


>  BuildRoot:     
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 
Note that several details related to BuildRoot are no longer needed since
Fedora 13: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag


>  Requires:       python >= 2.5 
This one is wrong actually, since the dep on python(abi) is automatic already
and Python is newer than 2.5 for current Fedora dists anyway:

$ rpm -qpR puddletag-0.9.7-1.fc14.noarch.rpm|grep abi
python(abi) = 2.7


>  Requires:       PyQt4
>  Requires:       pyparsing >= 1.5.5
>  Requires:       python-mutagen
>  Requires:       python-imaging
>  Requires:       python-configobj
>  Requires:       python-musicbrainz2  
Even if it may be known that dependencies on Python modules are not automatic,
the spec file ought to explain that in a comment:
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

e.g.

# Dependencies on Python modules are not automatic yet.
Requires:       PyQt4
[...]


>  %description
>  Puddletag is a audio tag editor. 
...is an audio tag editor.



>  %setup -q
>  %{__chmod} 0644 NEWS
>  %{__sed} -i -e '1d' \
>     puddlestuff/{webdb,puddlesettings,puddletag,puddleobjects,releasewidget}.py 
This sed command is unacceptable IMO. You should at least use a proper match
that guards against deleting unexpected changes in those files. Currently,
there is a hashbang in those files. You cannot assume that future updates of
the package won't be missing the hashbang. In that case you would either delete
the UTF-8 encoding or valid code.


>  %files 
[...]
>  %{python_sitelib}/puddlestuff 
As a hint, more readable is to add a trailing slash to make clear that this is
a directory tree and not a single file:

%{python_sitelib}/puddlestuff/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

--- Comment #3 from Terje Røsten <terjeros(a)phys.ntnu.no&gt; 2010-12-27 14:58:44 EST
---
Thanks, updated package:
- 0.9.11
- fix license
- add comment about py reqs
- add slash to dir in files
- fix typo in description
- remove buildroot tag
- remove define of python macro
- remove python req
- fix sed expression

spec: http://terjeros.fedorapeople.org/puddletag/puddletag.spec
srpm:
http://terjeros.fedorapeople.org/puddletag/puddletag-0.9.11-1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

--- Comment #4 from Terje Røsten <terjeros(a)phys.ntnu.no&gt; 2010-12-27 17:42:07 EST
---
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2690582

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

Michael Schwendt <mschwendt(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody(a)fedoraproject.org    |mschwendt(a)gmail.com

--- Comment #5 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2010-12-28 04:38:51 EST
---
Good.

[...]

I've played a bit more with the run-time aspects of the app and have run into
two problems:

First, trouble testing the Music Library feature. A "yum install quodlibet" was
necessary to make sense of the "Tools > Import Music Library" menu, which
only
said:

 | No supported music libraries were found. Most likely the
 | required dependencies aren't installed. Visit the puddletag
 | website, puddletag.sourceforge.net for more details.

Then reselecting the menu and loading QuodLibet made puddletag freeze (will
attach the Python exception). Turned out one has to actually run the quodlibet
app first to init some files. To reproduce:

 1. rm -rf $HOME/.quodlibet
 2. puddletag
 3. open menu "Tools > Import Music Library"
 4. select QuodLibet and load it

[...]

Second issue was that the preferences default to using "amarok -p" as audio
player. On systems where Amarok is not installed (all Fedora non-KDE default
installs!), no error/warning dialog is displayed when trying to play a file. If
one enters the preferences and removes the default "amarok -p" setting, there
is a warning, at least.

I wonder whether there could be a default better than "amarok -p"? Maybe use
"xdg-open" (and a dependency on it)?

[...]

Apart from that: APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

--- Comment #6 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2010-12-28 04:39:42 EST
---
Created attachment 470930
  --> https://bugzilla.redhat.com/attachment.cgi?id=470930
puddletag exception freeze with non-initialized quodlibet

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

Michael Schwendt <mschwendt(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

Terje Røsten <terjeros(a)phys.ntnu.no&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #7 from Terje Røsten <terjeros(a)phys.ntnu.no&gt; 2010-12-28 16:13:07 EST
---
Thanks! I will have a look at these issues before pushing to stable.


New Package SCM Request
=======================
Package Name: puddletag
Short Description: Feature rich, easy to use tag editor
Owners: terjeros
Branches: f13 f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

--- Comment #8 from Kevin Fenzi <kevin(a)tummy.com&gt; 2011-01-02 15:11:40 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645277

Terje Røsten <terjeros(a)phys.ntnu.no&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2011-01-06 14:22:12

--- Comment #9 from Terje Røsten <terjeros(a)phys.ntnu.no&gt; 2011-01-06 14:22:12 EST
---
Imported, built and pushed to testing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.