[Bug 494195] New: Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: drascula - The Vampire Strikes Back - Adventure Game

https://bugzilla.redhat.com/show_bug.cgi?id=494195

Summary: Review Request: drascula - The Vampire Strikes Back -
                    Adventure Game
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://people.atrpms.net/~hdegoede/drascula.spec
SRPM URL: http://people.atrpms.net/~hdegoede/drascula-1.0-1.fc11.src.rpm
Description:
You play John Hacker, an estate agent accompanying Count Drascula as he
attempts to negotiate the sale of a property in Transylvania. Little does
Hacker know Drascula's vampire secret, and so his adventure quickly becomes a
whole lot more complicated than he imagined.

Notice that music for the game is available as an addon in the separate
drascula-music package. As are Spanish, German, French and Italian subtitles  
in the drascula-international package.

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |494197

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |494199

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

--- Comment #1 from Hans de Goede   2009-04-05 10:40:52 EDT ---
Note the music package review is bug 494197, and the subtitle package review is
bug 494199.

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

Lucian Langa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Lucian Langa   2009-04-05 13:19:51 EDT ---
Hans,
I've already packaged drascula:
https://bugzilla.redhat.com/show_bug.cgi?id=465694
https://admin.fedoraproject.org/pkgdb/packages/name/drascula

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Mamoru Tasaka   2009-04-05 13:30:11 EDT ---
Well, as Ralf pointed out, the readme.txt file says:

3) You may not charge a fee for the game itself. This includes reselling the
game as an individual item.

I think this is definitely non-free and not permittable
on Fedora.

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |DUPLICATE

--- Comment #4 from Hans de Goede   2009-04-05 13:33:05 EDT ---
(In reply to comment #2)
> Hans,
> I've already packaged drascula:
> https://bugzilla.redhat.com/show_bug.cgi?id=465694
> https://admin.fedoraproject.org/pkgdb/packages/name/drascula

Oh, suck. I did do a bugzilla search for drascula and that returned nothing.
Still does not return your review request, so the default search box only
searches for open requests <sigh>.

Ah well, I'll close this as a dup of your drascula package.

Can you make 2 changes to your package? :

1) Add the following to the description:
"Notice that music for the game is available as an addon in the separate
drascula-music package. As are Spanish, German, French and Italian subtitles
in the drascula-international package."

(Those are the other 2 drascula packages I did, which luckily seem to
 still be valid).

2) Remove drascula.dat from the package, since scummvm-0.12.0 the
.dat files are shipped to-gether with scummvm. Yes this is not
documented very well.

p.s.

I would appreciate a review of the 2 add on packages, they are quite simple.

*** This bug has been marked as a duplicate of 465694 ***

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

--- Comment #5 from Hans de Goede   2009-04-05 13:42:11 EDT ---
(In reply to comment #3)
> Well, as Ralf pointed out, the readme.txt file says:
> You may not charge a fee for the game itself. This includes reselling the
>
> game as an individual item.
>
> I think this is definitely non-free and not permittable
> on Fedora.

The readme.txt contains the *exact* same license text as many other
games set free in cooperation between the original right holders and
the scummvm project, and this license has been approved for Fedora,
see:
http://www.redhat.com/archives/fedora-extras-list/2006-November/msg00020.htm...

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

--- Comment #6 from Lucian Langa   2009-04-05 15:46:01 EDT ---
(In reply to comment #4)
> Can you make 2 changes to your package? :
> Add the following to the description:
>
> "Notice that music for the game is available as an addon in the separate
> drascula-music package. As are Spanish, German, French and Italian subtitles
> in the drascula-international package."

I've added the music pack to the main package. Game seems incomplete without it
(eg. description Piano Playing). The music pack enlarges the main package with
~30M I could probably remove it but I do not like users installing 2 separate
packages.
> Remove drascula.dat from the package, since scummvm-0.12.0 the
>
> .dat files are shipped to-gether with scummvm. Yes this is not
> documented very well.

will do.

[Bug 494195] Review Request: drascula - The Vampire Strikes Back - Adventure Game

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=494195

--- Comment #7 from Hans de Goede   2009-04-06 03:49:44 EDT ---
(In reply to comment #6)
> (In reply to comment #4)
> > Can you make 2 changes to your package? :
> > Add the following to the description:
> >
> > "Notice that music for the game is available as an addon in the separate
> > drascula-music package. As are Spanish, German, French and Italian subtitles
> > in the drascula-international package."
>
> I've added the music pack to the main package. Game seems incomplete without it
> (eg. description Piano Playing). The music pack enlarges the main package with
> ~30M I could probably remove it but I do not like users installing 2 separate
> packages.

Oh, I didn't know you included the music in the main package, I personally
would like to see this split, for example on the games live dvd we are short
on space and thus do not install any of the -music packages. Also this seems
the right thing to me as two seperate upstream tarbals should be 2 separate
packages, so that if one of them changes the user does not need to redownload
the other (unchanged) package.
> > Remove drascula.dat from the package, since scummvm-0.12.0 the
> >
> > .dat files are shipped to-gether with scummvm. Yes this is not
> > documented very well.
>
> will do.

Thanks.