https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Bug ID: 1878260 Summary: Review Request: rust-picky - Portable X.509, Jose and PKI implementation Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pbrobinson@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SPEC: https://pbrobinson.fedorapeople.org/rust-picky.spec SRPM: https://pbrobinson.fedorapeople.org/rust-picky-5.1.1-1.fc32.src.rpm
Description: Portable X.509, Jose and PKI implementation
FAS: pbrobinson
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1859994 (PARSEC) Depends On| |1878236 | |(rust-picky-asn1-der), | |1878234 (rust-picky-asn1), | |1878237 | |(rust-picky-asn1-x509), | |1878257 (rust-aes-gcm) Alias| |rust-picky Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1859994 [Bug 1859994] Support PARSEC https://bugzilla.redhat.com/show_bug.cgi?id=1878234 [Bug 1878234] Review Request: rust-picky-asn1 - Provide ASN.1 simple types https://bugzilla.redhat.com/show_bug.cgi?id=1878236 [Bug 1878236] Review Request: rust-picky-asn1-der - ASN.1-DER subset for serde https://bugzilla.redhat.com/show_bug.cgi?id=1878237 [Bug 1878237] Review Request: rust-picky-asn1-x509 - Provides ASN1 types defined by X.509 related RFCs https://bugzilla.redhat.com/show_bug.cgi?id=1878257 [Bug 1878257] Review Request: rust-aes-gcm - Rust implementation of the AES-GCM (Galois/Counter Mode) Authenticated Encryption
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2020-09-14 17:52:25
--- Comment #1 from Peter Robinson pbrobinson@gmail.com --- While parsec had a dep on this is doesn't actually use it.
https://bugzilla.redhat.com/show_bug.cgi?id=1878260 Bug 1878260 depends on bug 1878257, which changed state.
Bug 1878257 Summary: Review Request: rust-aes-gcm - Rust implementation of the AES-GCM (Galois/Counter Mode) Authenticated Encryption https://bugzilla.redhat.com/show_bug.cgi?id=1878257
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX
https://bugzilla.redhat.com/show_bug.cgi?id=1878260 Bug 1878260 depends on bug 1878234, which changed state.
Bug 1878234 Summary: Review Request: rust-picky-asn1 - Provide ASN.1 simple types https://bugzilla.redhat.com/show_bug.cgi?id=1878234
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1878260 Bug 1878260 depends on bug 1878236, which changed state.
Bug 1878236 Summary: Review Request: rust-picky-asn1-der - ASN.1-DER subset for serde https://bugzilla.redhat.com/show_bug.cgi?id=1878236
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1878260 Bug 1878260 depends on bug 1878237, which changed state.
Bug 1878237 Summary: Review Request: rust-picky-asn1-x509 - Provides ASN1 types defined by X.509 related RFCs https://bugzilla.redhat.com/show_bug.cgi?id=1878237
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2328628 (rust-aes-kw)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2328628 [Bug 2328628] Review Request: rust-aes-kw - NIST 800-38F AES Key Wrap (KW) and Key Wrap with Padding (KWP) modes
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcandre.lureau@redhat.com Blocks| |2329181 (rust-sspi)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2329181 [Bug 2329181] Review Request: rust-sspi - Rust implementation of the Security Support Provider Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|WONTFIX |--- Keywords| |Reopened
--- Comment #2 from Marc-Andre Lureau marcandre.lureau@redhat.com --- reopening for sspi packaging
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
--- Comment #3 from Marc-Andre Lureau marcandre.lureau@redhat.com --- Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/r... SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/fedora-r... Description: Portable X.509, PKI, JOSE and HTTP signature implementation. Fedora Account System Username: elmarco
https://bugzilla.redhat.com/show_bug.cgi?id=1878260 Bug 1878260 depends on bug 2328628, which changed state.
Bug 2328628 Summary: Review Request: rust-aes-kw - NIST 800-38F AES Key Wrap (KW) and Key Wrap with Padding (KWP) modes https://bugzilla.redhat.com/show_bug.cgi?id=2328628
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Cole Robinson crobinso@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |crobinso@redhat.com Flags| |fedora-review? | |needinfo?(pbrobinson@gmail. | |com) Status|NEW |ASSIGNED Blocks|1859994 (PARSEC) | CC| |crobinso@redhat.com Depends On|1878234 (rust-picky-asn1), | |1878236 | |(rust-picky-asn1-der), | |1878237 | |(rust-picky-asn1-x509), | |1878257 (rust-aes-gcm), | |2328628 (rust-aes-kw) |
--- Comment #4 from Cole Robinson crobinso@redhat.com --- I'll take this. Content is basically straight `rust2rpm picky@7.0.0-rc.11` so nothing controversial. Looks like -rc.12 was released in the meantime though. Can you resubmit with that version, and using rust2rpm v27, and I'll finish review
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1859994 [Bug 1859994] Support PARSEC https://bugzilla.redhat.com/show_bug.cgi?id=1878234 [Bug 1878234] Review Request: rust-picky-asn1 - Provide ASN.1 simple types https://bugzilla.redhat.com/show_bug.cgi?id=1878236 [Bug 1878236] Review Request: rust-picky-asn1-der - ASN.1-DER subset for serde https://bugzilla.redhat.com/show_bug.cgi?id=1878237 [Bug 1878237] Review Request: rust-picky-asn1-x509 - Provides ASN1 types defined by X.509 related RFCs https://bugzilla.redhat.com/show_bug.cgi?id=1878257 [Bug 1878257] Review Request: rust-aes-gcm - Rust implementation of the AES-GCM (Galois/Counter Mode) Authenticated Encryption https://bugzilla.redhat.com/show_bug.cgi?id=2328628 [Bug 2328628] Review Request: rust-aes-kw - NIST 800-38F AES Key Wrap (KW) and Key Wrap with Padding (KWP) modes
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Cole Robinson crobinso@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pbrobinson@gmail. |needinfo?(marcandre.lureau@ |com) |redhat.com)
--- Comment #5 from Cole Robinson crobinso@redhat.com --- My bad, I set incorrect NEEDINFO. Fixing
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(marcandre.lureau@ | |redhat.com) |
--- Comment #6 from Marc-Andre Lureau marcandre.lureau@redhat.com --- Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/r... SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-bui... Description: Portable X.509, PKI, JOSE and HTTP signature implementation. Fedora Account System Username: elmarco
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Cole Robinson crobinso@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(marcandre.lureau@ | |redhat.com)
--- Comment #7 from Cole Robinson crobinso@redhat.com --- There's some install problems with optional dependencies:
Problem 1: conflicting requests - nothing provides (crate(cab/default) >= 0.6.0 with crate(cab/default) < 0.7.0~) needed by rust-picky+ctl_http_fetch-devel-7.0.0~rc.12-1.fc42.noarch from @commandline Problem 2: conflicting requests - nothing provides (crate(lexical-sort/default) >= 0.3.0 with crate(lexical-sort/default) < 0.4.0~) needed by rust-picky+ssh-devel-7.0.0~rc.12-1.fc42.noarch from @commandline Problem 3: package rust-picky+putty-devel-7.0.0~rc.12-1.fc42.noarch from @commandline requires crate(picky/ssh) = 7.0.0~rc.12, but none of the providers can be installed - conflicting requests - nothing provides (crate(lexical-sort/default) >= 0.3.0 with crate(lexical-sort/default) < 0.4.0~) needed by rust-picky+ssh-devel-7.0.0~rc.12-1.fc42.noarch from @commandline
Do any of your uses need ctl_http_fetch, ssh, or putty features? If not you can patch them out. Use `rust2rpm --patch` to interactively generate a patch and rip out the [features] sections, and the lexical-sort and cab dependency sections. Then I'd suggest renaming that patch, stuffing it into rust2rpm.toml extra-patches section, with a comment describing the change. Example: https://bugzilla.redhat.com/show_bug.cgi?id=2332550#c3
If you go the rust2rpm.toml route, please also provide that in next update, so I can regenerate the package myself.
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(marcandre.lureau@ | |redhat.com) |
--- Comment #8 from Marc-Andre Lureau marcandre.lureau@redhat.com --- Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/r... SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-bui... Description: Portable X.509, PKI, JOSE and HTTP signature implementation. Fedora Account System Username: elmarco
Do any of your uses need ctl_http_fetch, ssh, or putty features? If not you can patch them out.
done
I used [features] hide =... which seems to be better for this case.
See https://github.com/elmarco/ironrdp-fedora/tree/master/rust-picky
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Cole Robinson crobinso@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #9 from Cole Robinson crobinso@redhat.com --- (In reply to Marc-Andre Lureau from comment #8)
I used [features] hide =... which seems to be better for this case.
See https://github.com/elmarco/ironrdp-fedora/tree/master/rust-picky
ooo yeah, that's much nicer.
Looks good to me now and everything is installing correctly. Setting fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2343680
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2343680 [Bug 2343680] Review Request: rust-picky - Portable X.509, Jose and PKI implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1878260
Cole Robinson crobinso@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Flags|fedora-review+ | Status|POST |CLOSED Last Closed|2020-09-14 17:52:25 |2025-02-09 16:52:47
--- Comment #10 from Cole Robinson crobinso@redhat.com --- This was addressed in bug 2343680
*** This bug has been marked as a duplicate of bug 2343680 ***
package-review@lists.fedoraproject.org