[Bug 1286980] New: Review Request: perl-File-Zglob - Extended globs

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286980

Bug ID: 1286980
           Summary: Review Request: perl-File-Zglob - Extended globs
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://jplesnik.fedorapeople.org/perl-File-Zglob/perl-File-Zglob.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-File-Zglob/perl-File-Zglob-0.11-1.fc2...
Description:
Provides a traditional Unix glob(3) functionality; returns a list of
pathnames that matches the given pattern.

Fedora Account System Username: [e-mail]

[Bug 1286980] Review Request: perl-File-Zglob - Extended globs

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286980

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1286980] Review Request: perl-File-Zglob - Extended globs

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286980

--- Comment #1 from Petr Šabata  ---
* What's the reason for line 41?  The only executable file is author/test.pl;
  why would you care about it?

* Missing some BRs
  - coreutils, `rm' on line 39, `chmod' on line 41
  - sed, `sed' line 40

* The summary is very brief but acceptable.  However, I would correct the
  grammar in the description: s/matches/match/

* The package attempts to run the author tests (xt/*).  They're all skipped
  because of the missing dependencies but this could lead to an unexpected
  FTBFS if some of them make it into the buildroot.
  Either disable them (removing the author_test() call from Makefile.PL
  should work) or declare the missing optional BRs.

[Bug 1286980] Review Request: perl-File-Zglob - Extended globs

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286980

--- Comment #2 from Jitka Plesnikova  ---
(In reply to Petr Šabata from comment #1)
> What's the reason for line 41?  The only executable file is author/test.pl;
> why would you care about it?

It was just for prevention. Removed it.
> Missing some BRs
> coreutils, `rm' on line 39, `chmod' on line 41
> sed, `sed' line 40

Added.
> The summary is very brief but acceptable.  However, I would correct the
> grammar in the description: s/matches/match/

Updated
> The package attempts to run the author tests (xt/*).  They're all skipped
> because of the missing dependencies but this could lead to an unexpected
> FTBFS if some of them make it into the buildroot.
> Either disable them (removing the author_test() call from Makefile.PL
> should work) or declare the missing optional BRs.

Disabled author_test.

Updated files are on the same link

[Bug 1286980] Review Request: perl-File-Zglob - Extended globs

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286980

Petr Šabata  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Petr Šabata  ---
(In reply to Jitka Plesnikova from comment #2)
> (In reply to Petr Šabata from comment #1)
> > What's the reason for line 41?  The only executable file is author/test.pl;
> > why would you care about it?
>
> It was just for prevention. Removed it.

Okay.
> > Missing some BRs
> > coreutils, `rm' on line 39, `chmod' on line 41
> > sed, `sed' line 40
>
> Added.

Ack.
> > The summary is very brief but acceptable.  However, I would correct the
> > grammar in the description: s/matches/match/
>
> Updated

Ack.
> > The package attempts to run the author tests (xt/*).  They're all skipped
> > because of the missing dependencies but this could lead to an unexpected
> > FTBFS if some of them make it into the buildroot.
> > Either disable them (removing the author_test() call from Makefile.PL
> > should work) or declare the missing optional BRs.
>
> Disabled author_test.

Ack.

Approving.

[Bug 1286980] Review Request: perl-File-Zglob - Provide extended Unix glob

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286980

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |perl-File-Zglob - Extended  |perl-File-Zglob - Provide
                   |globs                       |extended Unix glob

[Bug 1286980] Review Request: perl-File-Zglob - Provide extended Unix glob

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286980

--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/perl-File-Zglob

[Bug 1286980] Review Request: perl-File-Zglob - Provide extended Unix glob

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286980

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |perl-File-Zglob-0.11-1.fc24
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2015-12-02 02:37:37

--- Comment #5 from Jitka Plesnikova  ---
Thank you for the review and the repository.