Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review request: ns-3 Network Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Summary: Review request: ns-3 Network Simulator Product: Fedora Version: 17 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rivanvx@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
This is F17 feature: http://fedoraproject.org/wiki/Features/Ns3
We are a bit late on the schedule because of coordination with upstream regarding building with GCC 4.7. It should mostly work now. Since this is not an invasive change, it shouldn't be a problem.
Package wise, ns-3 is a C++ library; aside from the fact that upstream requested versioned SONAMEs and packaging both debug and optimized libs, there is not much special stuff to see here.
I would like some general comments on the approach and structure. I know that specfile isn't ready for inclusion since too much is commented out and it needs substantial cleanup; I'm aware of that, that's the easy part that I will do once I get green light on this approach to packaging.
Be warned, since we are still packaging pre-relase stuff, the source code archive is quite large since it contains hg/bzr repodata. This will definitely be sorted out before inclusion.
spec: http://inf2.ffri.hr/~vedranm/ns3fedora17/SPECS/ SRPM: http://inf2.ffri.hr/~vedranm/ns3fedora17/SRPMS/ x86_64 RPM: http://inf2.ffri.hr/~vedranm/ns3fedora17/RPMS/x86_64/
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Reiner Rottmann reiner@rottmann.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |reiner@rottmann.it
--- Comment #1 from Reiner Rottmann reiner@rottmann.it --- Above links are broken.
As no SRPM is available, I've downloaded the ns3 spec file from the F17 feature page and the source code mentioned in the spec file.
The rpmbuild fails:
(...) Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgsl.so.0()(64bit) libgslcblas.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libns3.14-antenna-optimized.so()(64bit) libns3.14-aodv-optimized.so()(64bit) libns3.14-applications-optimized.so()(64bit) libns3.14-bridge-optimized.so()(64bit) libns3.14-buildings-optimized.so()(64bit) libns3.14-config-store-optimized.so()(64bit) libns3.14-core-optimized.so()(64bit) libns3.14-csma-layout-optimized.so()(64bit) libns3.14-csma-optimized.so()(64bit) libns3.14-dsdv-optimized.so()(64bit) libns3.14-emu-optimized.so()(64bit) libns3.14-energy-optimized.so()(64bit) libns3.14-flow-monitor-optimized.so()(64bit) libns3.14-internet-optimized.so()(64bit) libns3.14-lte-optimized.so()(64bit) libns3.14-mesh-optimized.so()(64bit) libns3.14-mobility-optimized.so()(64bit) libns3.14-mpi-optimized.so()(64bit) libns3.14-netanim-optimized.so()(64bit) libns3.14-network-optimized.so()(64bit) libns3.14-nix-vector-routing-optimized.so()(64bit) libns3.14-olsr-optimized.so()(64bit) libns3.14-point-to-point-layout-optimized.so()(64bit) libns3.14-point-to-point-optimized.so()(64bit) libns3.14-propagation-optimized.so()(64bit) libns3.14-spectrum-optimized.so()(64bit) libns3.14-stats-optimized.so()(64bit) libns3.14-tap-bridge-optimized.so()(64bit) libns3.14-test-optimized.so()(64bit) libns3.14-tools-optimized.so()(64bit) libns3.14-topology-read-optimized.so()(64bit) libns3.14-uan-optimized.so()(64bit) libns3.14-virtual-net-device-optimized.so()(64bit) libns3.14-wifi-optimized.so()(64bit) libns3.14-wimax-optimized.so()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libpython2.7.so.1.0()(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libxml2.so.2()(64bit) python(abi) = 2.7 rtld(GNU_HASH) Processing files: ns-core-3.14-0.1hg7804.fc17.x86_64 Provides: libns3.14-core-debug.so()(64bit) libns3.14-core-optimized.so()(64bit) pkgconfig(libns3.14-core-debug) = 3.14 pkgconfig(libns3.14-core-optimized) = 3.14 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig Requires: /usr/bin/pkg-config libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgsl.so.0()(64bit) libgslcblas.so.0()(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libpthread.so.0(GLIBC_2.3.2)(64bit) librt.so.1()(64bit) librt.so.1(GLIBC_2.2.5)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.15)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) rtld(GNU_HASH) Processing files: ns-core-devel-3.14-0.1hg7804.fc17.x86_64 error: File not found: /home/rottmrei/rpmbuild/BUILDROOT/ns-3.14-0.1hg7804.fc17.x86_64/usr/include/ns3.14/ns3/ns2-calendar-scheduler.h
RPM build errors: File not found: /home/rottmrei/rpmbuild/BUILDROOT/ns-3.14-0.1hg7804.fc17.x86_64/usr/include/ns3.14/ns3/ns2-calendar-scheduler.h
https://bugzilla.redhat.com/show_bug.cgi?id=807821
--- Comment #2 from Vedran Miletić rivanvx@gmail.com --- Sorry Reiner, I this was ignored for a long time and I forgot to update it.
Anyway, specfile is now updated and can be found here: http://www.inf.uniri.hr/~vmiletic/ns-3/ns.spec
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #3 from Mario Blättermann mario.blaettermann@gmail.com --- (In reply to comment #2)
The link is dead. Don't know if temporarily, but no connection to that server can be established, you should have a look at it. Moreover, you should also provide a srpm.
I can't find your name or mail address in the packagers group, are you a new packager and need a sponsor?
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
--- Comment #4 from Mario Blättermann mario.blaettermann@gmail.com --- Adding FE-NEEDSPONSOR. Please remove it once you are sponsored.
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Vedran Miletić rivanvx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|17 |rawhide
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=807821
--- Comment #5 from Vedran Miletić rivanvx@gmail.com --- Created attachment 670114 --> https://bugzilla.redhat.com/attachment.cgi?id=670114&action=edit ns-3.16 RPM spec file
Massive update for 3.16.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=807821
--- Comment #6 from Vedran Miletić rivanvx@gmail.com --- Created attachment 670115 --> https://bugzilla.redhat.com/attachment.cgi?id=670115&action=edit Required patches
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=807821
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@fabian-affolter.ch Blocks| |563471 (FE-SECLAB)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=807821
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |ns
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=807821
--- Comment #7 from Robin Lee robinlee.sysu@gmail.com --- SRPM is required for package review. Dropbox is even a choice for SPEC and SRPM hosting.
I tried to build the RPM on Fedora 18 x86_64, but finally it failed with:
RPM build errors: File not found: /home/cheese/rpmbuild/BUILDROOT/ns-3.16-1.fc18.x86_64/usr/lib64/libnsc0.5.3-linux2.6.18.so File not found: /home/cheese/rpmbuild/BUILDROOT/ns-3.16-1.fc18.x86_64/usr/lib64/libnsc0.5.3-linux2.6.26.so
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=807821
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(rivanvx@gmail.com | |)
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rivanvx@gmail.com Flags| |needinfo?(rivanvx@gmail.com | |)
--- Comment #8 from Christopher Meng cickumqt@gmail.com --- Well, from 17->20, this feature still not implemented yet.
I require this package, too.
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Vedran Miletić rivanvx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(rivanvx@gmail.com | |) | |needinfo?(rivanvx@gmail.com | |) |
--- Comment #9 from Vedran Miletić rivanvx@gmail.com --- Christopher, it is true, it wasn't pushed into Fedora. However, biggest part of the job is done. Are you willing to take over and do the rest? Unfortunately I don't have time to finish it now.
https://bugzilla.redhat.com/show_bug.cgi?id=807821
--- Comment #10 from Christopher Meng cickumqt@gmail.com --- I may have a try, but can you provide your spec/SRPM?
https://bugzilla.redhat.com/show_bug.cgi?id=807821
--- Comment #11 from Vedran Miletić rivanvx@gmail.com --- (In reply to Christopher Meng from comment #10)
I may have a try, but can you provide your spec/SRPM?
Both are here: http://inf2.uniri.hr/~vedranm/ns3fedora/
Most of the plumbing work has been done, but it needs an update to ns-3.17, review against the guidelines, and a lot of testing.
Feel free to finish it and push it.
https://bugzilla.redhat.com/show_bug.cgi?id=807821
--- Comment #12 from Christopher Meng cickumqt@gmail.com --- Ok.
But this depends on my spare time.
Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Michael Schwendt bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Mosaab Alzoubi moceap@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |moceap@hotmail.com Alias|ns |ns3
https://bugzilla.redhat.com/show_bug.cgi?id=807821
Vedran Miletić rivanvx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #670114|0 |1 is obsolete| |
--- Comment #13 from Vedran Miletić rivanvx@gmail.com --- Created attachment 986850 --> https://bugzilla.redhat.com/attachment.cgi?id=986850&action=edit ns-3.16 RPM spec file
This is the latest version of spec file I produced back in 2013. I'm just posting it here in case anyone wants to resume work.
I might need this in April-May timeframe, so if noone takes over I could do it myself. No promises however.
https://bugzilla.redhat.com/show_bug.cgi?id=807821
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |james.hogarth@gmail.com Flags| |needinfo?(rivanvx@gmail.com | |)
--- Comment #14 from James Hogarth james.hogarth@gmail.com --- Vedran are you interested in picking this back up again?
If not let's close it as a dead review so that others can see it's not in active progression and can open a fresh ticket if they are interested.
https://bugzilla.redhat.com/show_bug.cgi?id=807821
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR), |201449 (FE-DEADREVIEW) |563471 (FE-SECLAB) | Resolution|--- |NOTABUG Flags|needinfo?(rivanvx@gmail.com | |) | Last Closed| |2015-12-11 11:17:10
--- Comment #15 from James Hogarth james.hogarth@gmail.com --- It's been over a week with no response from the requestor to the NeedsInfo flag.
Closing as per policy.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages
package-review@lists.fedoraproject.org