[Bug 1610925] New: Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

Bug ID: 1610925
           Summary: Re-Review Request: rubygem-factory_bot - Framework and
                    DSL for defining and using model instance factories
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://src.fedoraproject.org/fork/pvalena/rpms/rubygem-factory_girl/blob/re...
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/2659/28762659/rubygem-factory...
Description: Framework and DSL for defining and using factories - less
error-prone, more explicit, and all-around easier to work with than fixtures.

Fedora Account System Username: pvalena

Scratch-Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28762658
Changes Proposed:
https://src.fedoraproject.org/rpms/rubygem-factory_girl/pull-request/1#reque...

This is a re-review request for a package rename.
Original package name: rubygem-factory_girl

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

Pavel Valena  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(jar.prokop@volny.
                   |                            |cz)

--- Comment #1 from Pavel Valena  ---
Jarku, could you take a look?

Note: I'm following a guide:
https://fedoraproject.org/wiki/Package_Renaming_Process

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

--- Comment #2 from Pavel Valena  ---
New scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28767271

--- rubygem-factory_bot-new.spec    2018-08-01 15:02:49.000000000 +0200
+++ rubygem-factory_bot-old.spec 2018-08-01 15:21:44.573155613 +0200
@@ -22 +21,0 @@
-BuildRequires: rubygem(mocha) >= 0.12.8

Was not needed (dependency removed upstream).

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

Jaroslav Prokop  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
              Flags|needinfo?(jar.prokop@volny. |fedora-review?
                   |cz)                         |

--- Comment #3 from Jaroslav Prokop  ---
I'll take this.

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

Jaroslav Prokop  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

--- Comment #4 from Jaroslav Prokop  ---
I reviewed the package and found no offense. But for clarity I would appreciate
srpm and raw spec urls which will be uploaded.

rpmlint out:
~~~
rubygem-factory_bot.spec: W: invalid-url Source2:
factory_bot-4.10.0-features.tar.gz
rubygem-factory_bot.spec: W: invalid-url Source1:
factory_bot-4.10.0-specs.tar.gz
rubygem-factory_bot.noarch: W: obsolete-not-provided rubygem-factory_girl
rubygem-factory_bot.noarch: W: no-documentation
rubygem-factory_bot.src: W: invalid-url Source2:
factory_bot-4.10.0-features.tar.gz
rubygem-factory_bot.src: W: invalid-url Source1:
factory_bot-4.10.0-specs.tar.gz
3 packages and 1 specfiles checked; 0 errors, 6 warnings.
~~~

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

--- Comment #5 from Pavel Valena  ---
(In reply to Jaroslav Prokop from comment #4)
> I reviewed the package and found no offense. But for clarity I would
> appreciate srpm and raw spec urls which will be uploaded.

They're available in the description/comments, but I can reiterate:

SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/7272/28767272/rubygem-factory...
Spec:
https://src.fedoraproject.org/fork/pvalena/rpms/rubygem-factory_girl/raw/reb...
> rpmlint out:
> rubygem-factory_bot.spec: W: invalid-url Source2:
> factory_bot-4.10.0-features.tar.gz
> rubygem-factory_bot.spec: W: invalid-url Source1:
> factory_bot-4.10.0-specs.tar.gz
> rubygem-factory_bot.noarch: W: obsolete-not-provided rubygem-factory_girl
> rubygem-factory_bot.noarch: W: no-documentation
> rubygem-factory_bot.src: W: invalid-url Source2:
> factory_bot-4.10.0-features.tar.gz
> rubygem-factory_bot.src: W: invalid-url Source1:
> factory_bot-4.10.0-specs.tar.gz
> 3 packages and 1 specfiles checked; 0 errors, 6 warnings.

Regarding the sources- it's a false positive.
Please check the comments in .spec file. The procedure used to create the file
is there (you can also 'unpack' it from srpm to check the content itself).

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

Jaroslav Prokop  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Jaroslav Prokop  ---
(In reply to Pavel Valena from comment #5)
> They're available in the description/comments, but I can reiterate:

Thanks :).
> Regarding the sources- it's a false positive.
> Please check the comments in .spec file. The procedure used to create the
> file is there (you can also 'unpack' it from srpm to check the content
> itself).

I am aware of that.

Package is otherwise OK. Package approved!

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

Pavel Valena  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

--- Comment #7 from Pavel Valena  ---
Thanks for the review!

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

--- Comment #8 from Igor Gnatenko  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-factory_bot

[Bug 1610925] Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories

https://bugzilla.redhat.com/show_bug.cgi?id=1610925

Pavel Valena  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
   Fixed In Version|                            |rubygem-factory_bot-4.10.0-
                   |                            |1.fc29
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2018-08-03 14:28:24