Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: zaz - A puzzle game where the player has to arrange balls in triplets
https://bugzilla.redhat.com/show_bug.cgi?id=542463
Summary: Review Request: zaz - A puzzle game where the player has to arrange balls in triplets Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: musuruan@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://musuruan.fedorapeople.org/zaz.spec SRPM URL: http://musuruan.fedorapeople.org/zaz-0.3.0-1.fc12.src.rpm Description: Zaz is an arcade action puzzle game where the goal is to get rid of all incoming balls by rearranging their order and making triplets. It currently includes 6 different levels. The game's name is recursive and stands for "Zaz ain't Z". Notes: F12+ only. It requires digna-fonts.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
Andrea Musuruane musuruan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |542461
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
--- Comment #1 from Andrea Musuruane musuruan@gmail.com 2009-12-12 05:30:21 EDT --- Spec URL: http://musuruan.fedorapeople.org/zaz.spec SRPM URL: http://musuruan.fedorapeople.org/zaz-0.3.0-2.fc12.src.rpm
Changelog: - Now Requires renamed Digna font package (BZ #542461)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
Bug 542463 depends on bug 542461, which changed state.
Bug 542461 Summary: Review Request: digna-fonts - Handwriting font https://bugzilla.redhat.com/show_bug.cgi?id=542461
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |xavier@bachelot.org Flag| |fedora-review+
--- Comment #2 from Xavier Bachelot xavier@bachelot.org 2009-12-20 17:46:05 EDT --- OK: spec file is properly named OK: package is properly named OK: Spec is legible NOK: use of macros is consistent OK: tarball match upstream : d0e625ee9b8d4823955686048ac69d0a zaz-0.3.0.tar.gz OK: License field match the actual license and is acceptable Ok: BuildRoot is correct OK: BuildRequires and Requires are correct OK: no bundled copied of libraries OK: Desktop file is validated and installed OK: scriplets are correct. OK: locales are properly handled OK: defattr is correct OK: %doc is correct Ok: builds in mock OK: all files and directories are properly packaged Ok: doesn't own dirs it shouldn't OK: files/dirs perms are correct OK; rpmlint output is clean ; zaz.i686: W: dangling-symlink /usr/share/zaz/FreeSans.ttf /usr/share/fonts/gnu-free/FreeSans.ttf zaz.i686: W: dangling-symlink /usr/share/zaz/font1.ttf /usr/share/fonts/oflb-dignas-handwriting/phranzysko_-_Digna_s_Handwriting.ttf zaz.i686: W: dangling-symlink /usr/share/zaz/FreeMonoBold.ttf /usr/share/fonts/gnu-free/FreeMonoBold.ttf 3 packages and 0 specfiles checked; 0 errors, 3 warnings. These 3 are expected and can be ignored. Ok: final provides and requires are correct
Note : typo in %prep section : # Fix premissions ^^
Please fix use of macros, there is a spurious %{buildroot} when installing the icon, then this package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
--- Comment #3 from Andrea Musuruane musuruan@gmail.com 2009-12-21 04:53:00 EDT --- Thank you for your review. I'll update this package to fix the small issues you found before committing it to cvs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
Andrea Musuruane musuruan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Andrea Musuruane musuruan@gmail.com 2009-12-21 04:54:31 EDT --- New Package CVS Request ======================= Package Name: zaz Short Description: A puzzle game where the player has to arrange balls in triplets Owners: musuruan Branches: F-12 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2009-12-21 15:02:15 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542463
Andrea Musuruane musuruan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #6 from Andrea Musuruane musuruan@gmail.com 2009-12-22 15:06:36 EDT --- Built and published. Closing.
package-review@lists.fedoraproject.org