https://bugzilla.redhat.com/show_bug.cgi?id=1155495
Bug ID: 1155495 Summary: Review Request: python-yappi - Yet Another Python Profiler Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: smizrahi@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://smizrahi.fedorapeople.org/yappi/yappi.spec SRPM URL: https://smizrahi.fedorapeople.org/yappi/python-yappi-0.92-1.fc21.src.rpm Description: CPython standard distribution is coming with three profilers. cProfile, Profile and hotshot. cProfile module is implemented as a C module based on lsprof, Profile is in pure Python and the hotshot can be seen as a small subset of a cProfile. The motivation to implement a new profiler is that all of these profilers lacks the support of multi-threaded programs. If you want to profile a multi-threaded application, you must give an entry point to these profilers and then maybe merge the outputs. None of these profilers is designed to work on long-running multi-threaded application. While implementing a game server, it turns out that is is impossible to profile an application retrieve the statistics then stop and then start later on on the fly(without affecting the profiled application). With the experience of implementing a game server in Python, we have identified most of the problems, tricky parts regarding profiler usage and so, we have come up with simple but powerful requirements.
Fedora Account System Username: smizrahi
https://bugzilla.redhat.com/show_bug.cgi?id=1155495
--- Comment #1 from Saggi Mizrahi smizrahi@redhat.com --- It has come to my attention that it's better to use the tip than the stable release so I modified the specfile.
Spec URL: https://smizrahi.fedorapeople.org/yappi/yappi.spec SRPM URL: https://smizrahi.fedorapeople.org/yappi/https://smizrahi.fedorapeople.org/ya...
https://bugzilla.redhat.com/show_bug.cgi?id=1155495
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@gmail.com
--- Comment #2 from Piotr Popieluch piotr1212@gmail.com --- Some comments:
Errors: - spec filename does not match package name, rename yappi.spec to python-yappi.spec - Source0 url gives 404: https://pypi.python.org/packages/source/y/yappi/1d187cc9e455d3d11915da135937... - No files markes as %doc. Add "%doc README.md LICENSE" to %files section - mock build fails missing BuildRequires. Add BuildRequires: python-setuptools
Suggestions: - %description is a bit long and is more a motivation than description. - Could you add a python3 module?
https://bugzilla.redhat.com/show_bug.cgi?id=1155495
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |piotr1212@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1155495
Douglas Schilling Landgraf dougsland@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |smizrahi@redhat.com Flags| |needinfo?(smizrahi@redhat.c | |om)
https://bugzilla.redhat.com/show_bug.cgi?id=1155495
--- Comment #4 from Piotr Popieluch piotr1212@gmail.com --- Saggi Mizrahi, are you still interested in packaging this?
Could you please resolve the issues, then we can continue the review. If there is no response soon I will have to close this bug according to: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
https://bugzilla.redhat.com/show_bug.cgi?id=1155495
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed| |2015-06-06 18:01:51
--- Comment #5 from Piotr Popieluch piotr1212@gmail.com --- no response, closing bug
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org