[Bug 672205] New: Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pynag - Python Nagios plugin and configuration environment

https://bugzilla.redhat.com/show_bug.cgi?id=672205

Summary: Review Request: pynag - Python Nagios plugin and
                    configuration environment
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://pynag.googlecode.com/svn/trunk/pynag.spec
SRPM URL: http://pynag.googlecode.com/files/pynag-0.3-1.src.rpm
Description: Python libraries for managing nagios configuration files and
writing python nagios plugins.

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

Tomas Edwardsson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |177841(FE-NEEDSPONSOR)

--- Comment #1 from Tomas Edwardsson  2011-01-25 19:00:59 EST ---
A couple of notes, I am a maintainer of pynag and I am also seeking a sponsor.

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

--- Comment #2 from Tomas Edwardsson  2011-01-25 19:58:48 EST ---
Rolled a new version according to input from rpmlint:

SRPM URL: http://pynag.googlecode.com/files/pynag-0.3-2.src.rpm

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

PRABIN KUMAR DATTA  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from PRABIN KUMAR DATTA  2011-04-20 20:26:43 EDT ---
^ This is an Informal Review. ^

* MUST: rpmlint must be run on every package                           [Fix  ]

$ rpmlint -i SRPMS/pynag-0.3-2.src.rpm 
pynag.src: W: non-coherent-filename pynag-0.3-2.src.rpm
pynag-0.3-2.fc13.src.rpm
The file which contains the package should be named
<NAME>-<VERSION>-<RELEASE>.<ARCH>.rpm.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i RPMS/noarch/pynag-0.3-2.fc14.noarch.rpm 
pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/remove_host_from_group.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/find_orphans.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/network_scan.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_contactgroup.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/parse_files.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_hostgroup.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_service_info.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/check_cpu.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_servicegroup.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/optimize_config.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/list_services.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/remove_host.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_command.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_service.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_contact.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_host.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_timeperiod.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/suggest_optimizations.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/list_hosts_groups.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

1 packages and 0 specfiles checked; 0 errors, 19 warnings.

* MUST: The package must be named according to the Package Naming    [Fix   ] 
  Guidelines
Check rpmlint output for pynag-0.3-2.src.rpm

* MUST: The spec file for the package MUST be legible.               [Fix   ]

* Must: Spec file matches base package                               [OK   ]

* Must: License must be licensed with a Fedora approved license and meet the
  Licensing Guidelines                                               [OK   ]

* Must: License in spec must match actual license                    [OK   ]

* Must: License file included in %doc                                [OK   ]

* Must: Spec file written in American English                        [OK   ]

* Must: Tar ball matches upstream                                    [OK   ]

* Must: Package successfully builds binary RPMs                      [OK   ]
local build -(f14)
Koji build -(f15) http://koji.fedoraproject.org/koji/taskinfo?taskID=3014787

* Must: No duplicate files                                           [OK   ]

* Must: Macro use must be consistant                                 [OK   ]
Thou, for example:
%dir %{python_sitelib}/pynag
Can be written as
%dir %{python_sitelib}/%{name}

* Must: At the beginning of %install, each package MUST run rm -rf %{buildroot}
                                                                     [OK   ]

* Must: All filenames in rpm packages must be valid UTF-8            [OK   ]

* Other: %clean section and rm -fr $RPM_BUILD_ROOT are not required for F-13
and above. http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

--- Comment #4 from PRABIN KUMAR DATTA  2011-04-20 20:53:48 EDT ---
Also,
This is unnecessary, and in fact improper,: 
%doc AUTHORS README LICENSE CHANGES examples

It should be (^correct me if I am wrong^): 
%doc AUTHORS README LICENSE CHANGES
%doc examples

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

--- Comment #5 from Tomas Edwardsson  2011-04-27 19:25:13 EDT ---
Thanks for the review, I broke up the examples into a seperate package,
pynag-examples. New src.rpm at
http://pynag.googlecode.com/files/pynag-0.3-3.src.rpm which should address all
these issues.

I'm pretty sure the package conforms to naming, maybe a problem with running
rpmlint against a src.rpm ?

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

Kevin Kofler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)
         Depends on|177841(FE-NEEDSPONSOR)      |

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

--- Comment #6 from Tomas Edwardsson  2011-08-10 14:38:24 EDT ---
New version released. http://pynag.googlecode.com/files/pynag-0.4-3.el6.src.rpm

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

--- Comment #7 from Tomas Edwardsson  2012-01-19 15:51:53 EST ---
Anything more I can do to move this along?

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

Matthias Runge  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Matthias Runge  2012-03-02 15:08:24 EST ---
Hi Tomas,

to get sponsored into the packager group, you must convince a sponsor to
support you (or have somebody else to convince a sponsor....)

please read
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
and do some informal reviews.

You should note the bugzilla numbers here (as a reference for your sponsor).

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

Matthias Runge  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |Stalled Submitter

--- Comment #9 from Matthias Runge  2012-03-24 14:34:27 EDT ---
Any progress?

[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

--- Comment #10 from Tomas Edwardsson  2012-04-16 21:10:28 EDT ---
Hi Matthias

I've done 2 informal reviews on bug 800105 and 812121. Will look into doing
more reviews in the next few days.