[Bug 1558578] New: Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

Bug ID: 1558578
           Summary: Review Request: python-copr-common - Python code used
                    by Copr
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/dturecek/python-copr-common/...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/dturecek/python-copr-common/...
Description: COPR is lightweight build system. It allows you to create new
project in WebUI, and submit new builds and COPR will create yum repository
from latest builds. This package contains python code used by other Copr
packages. Mostly useful for developers only.
Fedora Account System Username: dturecek

This is my first package and I am an upstream maintainer of this as well.

Here's a link to a scratch build in Koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25833660

[Bug 1558578] Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

[Bug 1558578] Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1558578] Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

--- Comment #1 from Miroslav Suchý  ---
> BuildRequires: python2-devel
> BuildRequires: python3-devel

This should be wrapped with:
  %if 0%{?with_python3}
  %if 0%{?with_python2}
> %check

It is empty, therefore no need to specify it at all.

[Bug 1558578] Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

--- Comment #2 from Miroslav Suchý  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x] : Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

So only issues are those mentioned in #1. Fix them and you are good.

[Bug 1558578] Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

--- Comment #3 from Dominik Turecek  ---
I have fixed the issues.

URL to the new spec:
https://copr-be.cloud.fedoraproject.org/results/dturecek/python-copr-common/...

[Bug 1558578] Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |
              Flags|                            |fedora-review+

--- Comment #4 from Miroslav Suchý  ---
APPROVED

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1558578] Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-copr-common

[Bug 1558578] Review Request: python-copr-common - Python code used by Copr

https://bugzilla.redhat.com/show_bug.cgi?id=1558578

Dominik Turecek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2018-06-28 03:14:25