[Bug 2387553] New: Review Request: greenboot-rs - Generic Health Check Framework for systemd
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Bug ID: 2387553 Summary: Review Request: greenboot-rs - Generic Health Check Framework for systemd Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: saypaul@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Sayan saypaul@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged |
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9396583 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Not a valid SPDX expression 'LGPLv2+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #2 from Sayan saypaul@redhat.com --- Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Sayan saypaul@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged CC| |pwhalen@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2103240 --> https://bugzilla.redhat.com/attachment.cgi?id=2103240&action=edit The .spec file difference from Copr build 9396583 to 9396750
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged |
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9396750 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #5 from Sayan saypaul@redhat.com --- ``` Found issues:
- Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip... ``` necessary: %post,%preun, %postuns is used correctly
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |pbrobinson@gmail.com Status|NEW |ASSIGNED CC| |pbrobinson@gmail.com
--- Comment #6 from Peter Robinson pbrobinson@gmail.com --- I'll review this.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #7 from Sayan saypaul@redhat.com --- Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Sayan saypaul@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2103349 --> https://bugzilla.redhat.com/attachment.cgi?id=2103349&action=edit The .spec file difference from Copr build 9396750 to 9404787
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/%%7Brepo_o | |wner}/%{name} Keywords|AutomationTriaged |
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9404787 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #10 from Sayan saypaul@redhat.com --- Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9440137 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- greenboot-rs-0.16.0-025b6e4.spec should be greenboot-rs.spec Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming - Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #12 from Peter Robinson pbrobinson@gmail.com --- Reviewing.
Looking at the output of the copr bit there's few minor bits that need fixing, the main one is the spec file name, I am presuming that is for review (it should here be the proper one for future reference).
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #13 from Peter Robinson pbrobinson@gmail.com ---
Found issues:
- greenboot-rs-0.16.0-025b6e4.spec should be greenboot-rs.spec Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming
- Systemd service file(s) in greenboot, greenboot-default-health-checks Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/ #_scriptlets
These two issues ^^^ need to be double checked, else all the rest looks fine.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #14 from Sayan saypaul@redhat.com ---
Spec URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/greenboot-rs/fedo... Description: Generic Health Check Framework for systemd Fedora Account System Username: saypaul
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #15 from Sayan saypaul@redhat.com ---
Found issues:
- greenboot-rs-0.16.0-025b6e4.spec should be greenboot-rs.spec Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming
Fixed in last build:https://bugzilla.redhat.com/show_bug.cgi?id=2387553#c14
- Systemd service file(s) in greenboot, greenboot-default-health-checks Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/ #_scriptlets
greenboot has the required scriptlets, greenboot-default-health-checks does not require any scriptlets as it installs only the health check scripts.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #16 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9448121 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Systemd service file(s) in greenboot, greenboot-default-health-checks Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #17 from Peter Robinson pbrobinson@gmail.com --- LGTM Approved!
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #18 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/greenboot-rs
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #19 from Fabio Valentini decathorpe@gmail.com --- There's quite a few things from a Rust packaging POV that aren't really up to date in this spec file, it probably shouldn't have been approved as-is. I offered help with the packaging side of things in the discussion thread for the Change proposal, but I don't think anybody has reached out to the Rust SIG?
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #20 from Sayan saypaul@redhat.com --- discussed and identified the the missing best practices, will push the changes shortly.
https://bugzilla.redhat.com/show_bug.cgi?id=2387553
--- Comment #21 from Sayan saypaul@redhat.com --- Fixes addressed in: 0.16.0-3
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com