[Bug 448745] New: Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=448745

Summary: Review Request: ext3grep - Recovery tool for ext3
                    filesystems
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://mjakubicek.fedorapeople.org/ext3grep/ext3grep.spec
SRPM URL: http://mjakubicek.fedorapeople.org/ext3grep/ext3grep-0.6.0-1.fc9.src.rpm
Description: A tool to investigate an ext3 file system for deleted content and possibly recover it.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=632237

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-05-28 19:55 EST -------
MD5Sum:
aabd3b85e5862cddc284a37f300df186  ext3grep-0.6.0.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Rpmlint produces no warnings or errors
* Package builds fine in koji.
* Package installs and uninstalls cleanly

Minor (non-blocker):
* you should package the LICENSE.GPL2 file.

+1 Approved

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

------- Additional Comments From [e-mail]  2008-05-29 02:46 EST -------
(In reply to comment #1)
> Minor (non-blocker):
> you should package the LICENSE.GPL2 file.

Isn't this (as it is done now) the supposed way?:

%doc NEWS README LICENSE.GPL2
> +1 Approved

Thanks for your review.

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-05-29 09:48 EST -------
New Package CVS Request
=======================
Package Name: ext3grep
Short Description: Recovery tool for ext3 filesystems
Owners: mjakubicek
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-05-30 16:24 EST -------
cvs done.

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

------- Additional Comments From [e-mail]  2008-05-31 16:12 EST -------
ext3grep-0.6.0-1.fc8 has been submitted as an update for Fedora 8

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

------- Additional Comments From [e-mail]  2008-05-31 16:14 EST -------
ext3grep-0.6.0-1.fc9 has been submitted as an update for Fedora 9

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

------- Additional Comments From [e-mail]  2008-06-03 03:30 EST -------
ext3grep-0.6.0-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE
   Fixed In Version|                            |0.6.0-1.fc9

[Bug 448745] Review Request: ext3grep - Recovery tool for ext3 filesystems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=448745

------- Additional Comments From [e-mail]  2008-06-03 03:33 EST -------
ext3grep-0.6.0-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.