[Bug 1275005] New: Review Request: nodejs-tough-cookie - RFC6265 Cookies and Cookie Jar for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
Bug ID: 1275005 Summary: Review Request: nodejs-tough-cookie - RFC6265 Cookies and Cookie Jar for Node.js Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: piotr1212@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://piotrp.fedorapeople.org/nodejs-tough-cookie.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-tough-cookie-2.2.0-1.fc22.src.rpm Description: RFC6265 Cookies and Cookie Jar for Node.js Fedora Account System Username: piotrp
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |994934
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=994934 [Bug 994934] nodejs-request-2.65.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tom@compton.nu Assignee|nobody@fedoraproject.org |tom@compton.nu Flags| |fedora-review?
--- Comment #1 from Tom Hughes tom@compton.nu --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "*No copyright* MPL (v2.0)", "Unknown or generated", "MPL (v2.0) BSD (3 clause)". 9 files have unknown license. Detailed output of licensecheck in /home/tom/1275005-nodejs-tough- cookie/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-tough-cookie-2.2.0-1.fc24.noarch.rpm nodejs-tough-cookie-2.2.0-1.fc24.src.rpm nodejs-tough-cookie.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-tough-cookie.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-tough-cookie.noarch: W: only-non-binary-in-usr-lib nodejs-tough-cookie.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-tough-cookie.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nodejs-tough-cookie.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires -------- nodejs-tough-cookie (rpmlib, GLIBC filtered): nodejs(engine)
Provides -------- nodejs-tough-cookie: nodejs-tough-cookie npm(tough-cookie)
Source checksums ---------------- https://github.com/SalesforceEng/tough-cookie/archive/fb1456177c9b51445afa34... : CHECKSUM(SHA256) this package : 55970b1b9a94d5c7a3ca45f4fedef87e47be1a978390d490ba925144f61ffbf1 CHECKSUM(SHA256) upstream package : 55970b1b9a94d5c7a3ca45f4fedef87e47be1a978390d490ba925144f61ffbf1
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1275005 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
--- Comment #2 from Tom Hughes tom@compton.nu --- The test failure is because our vows is too old. If you use 0.8.1 then it passes.
My only concern here is licensing the lib/pubsuffix.js code is generated from the public_suffix_list.dat file, which is under MPL 2.0 so the license tag on the RPM should reflect that.
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
--- Comment #3 from Piotr Popieluch piotr1212@gmail.com --- Thanks, updated package, same urls.
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Tom Hughes tom@compton.nu --- Great. Package approved then.
I've got an updated vows building in rawhide now (http://koji.fedoraproject.org/koji/taskinfo?taskID=11577813) so once that is done you should be able to enable the tests as well.
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
--- Comment #5 from Piotr Popieluch piotr1212@gmail.com --- Nice, will enable tests. Thank you!
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodejs-tough-cookie-2.2.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-0ab123b9c9
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-tough-cookie-2.2.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update nodejs-tough-cookie' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-0ab123b9c9
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodejs-tough-cookie-2.2.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1275005
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2015-11-04 15:52:39
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla