[Bug 2051062] New: Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062

            Bug ID: 2051062
           Summary: Review Request: river - Dynamic tiling Wayland
                    compositor
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: alebastr89(a)gmail.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Spec URL:
https://download.copr.fedorainfracloud.org/results/alebastr/river/fedora-...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/alebastr/river/fedora-...
COPR URL: https://copr.fedorainfracloud.org/coprs/alebastr/river/

Description:
river is a dynamic tiling wayland compositor that takes inspiration
from dwm and bspwm.

Design goals:
 * Simplicity and minimalism, river should not overstep the bounds
   of a window manager.
 * Window management based on a stack of views and tags.
 * Dynamic layouts generated by external, user-written executables.
   (A default rivertile layout generator is provided.)
 * Scriptable configuration and control through a custom wayland
   protocol and separate riverctl binary implementing it.

Fedora Account System Username: alebastr


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062

Jakub Kadlčík <jkadlcik(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |jkadlcik(a)redhat.com



--- Comment #1 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
Hello Aleksei,
thank you for the package.

I tried to install and run it, and I think it works - I got a blue
screen and a mouse cursor. Maybe if you are a river developer, you might 
want to describe the default key bindings in some README because I don't 
know how to launch any applications :D. But that's outside of the 
package-review scope.


Just for the record, the package fails to build for F35 but it will
be EOL soon, so I think we don't care about it anymore.


>  Source100:      %{name}.desktop 
Why not Source3?


>  # bundled sources
>  Provides:       bundled(zig-pixman)
>  Provides:       bundled(zig-wayland)
>  Provides:       bundled(zig-wlroots)
>  Provides:       bundled(zig-xkbcommon) 
My apologies, I have zero experience with Zig programming language and
with compiled programming languages overall, for that matter.

Is it absolutely necessary to bundle these? Packaging guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
tells us to make every effort to avoid bundling.


>  %description 
I just wanted to say that I like the well-written description


>  %zig_build \
>    -Dxwayland
>
>
>  %zig_install \
>     -Dxwayland 
A bit unnecessary to wrap the linen there but I don't mind


>  %license LICENSE
>  %doc README.md 
Maybe we can add %doc CONTRIBUTING.md as well?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062

Jakub Kadlčík <jkadlcik(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|nobody(a)fedoraproject.org    |jkadlcik(a)redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #2 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
>  Issues:
>  =======
>  - Package installs a %{name}.desktop using desktop-file-install or desktop-
>    file-validate if there is such a file. 
The fedora-review tool complains about this. I think we need to do
something like

    %check
    desktop-file-validate
%{buildroot}%{_datadir}/wayland-sessions/%{name}.desktop


>  NTP License (legal disclaimer) Historical Permission Notice and
> Disclaimer - sell variant
>
> -----------------------------------------------------------------------------------------
>
> /home/jkadlcik/2051062-river/upstream-unpacked/Source0/river-0.1.3/deps/zig-wlroots/protocol/wlr-layer-shell-unstable-v1.xml
>
> /home/jkadlcik/2051062-river/upstream-unpacked/Source0/river-0.1.3/protocol/wlr-layer-shell-unstable-v1.xml
This license isn't mentioned in the License field but I am not sure if
it is necessary.


>  [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/river 
There is

    %{_datadir}/%{name}/init.example

in the %files section. We need to change it or add a new line for the
whole directory.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #3 from Aleksei Bavshin <alebastr89(a)gmail.com&gt; ---
(In reply to Jakub Kadlčík from comment #1)
>  Hello Aleksei,
>  thank you for the package. 
Thanks for the review!

>  
>  I tried to install and run it, and I think it works - I got a blue
>  screen and a mouse cursor. Maybe if you are a river developer, you might 
>  want to describe the default key bindings in some README because I don't 
>  know how to launch any applications :D. But that's outside of the 
>  package-review scope.
>   
The upstream developer strongly believe that the user should write their
own configuration based on the example they provide and don't have any
support for the default config (in fact support for the default system
config was removed at some point just before the initial release).
Which means there's no default keybindings :(

README.md describes how to start in the Usage section, but I agree that it
raises the entry barrier a bit higher than usual even for tiling WMs.

>  Just for the record, the package fails to build for F35 but it will
>  be EOL soon, so I think we don't care about it anymore. 
I assume that's because f35 does not have required version of wlroots.
All wlroots releases so far have been API- and ABI-breaking and the
compositors based on the library or the language bindings to wlroots
support only an exact minor version.

>  
>  
>  > Source100:      %{name}.desktop
>  
>  Why not Source3? 
No particular reason, just wanted a clean separation from the sources
provided by upstream. I'll change that to Source3.

>  
>  > # bundled sources
>  > Provides:       bundled(zig-pixman)
>  > Provides:       bundled(zig-wayland)
>  > Provides:       bundled(zig-wlroots)
>  > Provides:       bundled(zig-xkbcommon)
>  
>  My apologies, I have zero experience with Zig programming language and
>  with compiled programming languages overall, for that matter.
>  
>  Is it absolutely necessary to bundle these? Packaging guidelines
>  https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
>  tells us to make every effort to avoid bundling. 
Ah, here comes the complicated part:
zig, being still actively developed and designed, does not have any
support for sharing the code yet. Think rust with its unstable ABI,
but without a package manager or a standard library location.

So all the bundled code is embedded to the repo as git submodules
and the paths are hardcoded in the buildsystem. Plus some details
of the build system which make it even more inconvenient.

Tl;dr: I don't want to deal with that until the Zig toolchain evolves
to offer some package/code reuse solution. And until we have support
for that in zig-rpm-macros.

>  > %description
>  
>  I just wanted to say that I like the well-written description
>  
>  
>  > %zig_build \
>  >   -Dxwayland
>  >
>  >
>  > %zig_install \
>  >    -Dxwayland
>  
>  A bit unnecessary to wrap the linen there but I don't mind
>  
>  
>  > %license LICENSE
>  > %doc README.md
>  
>  Maybe we can add %doc CONTRIBUTING.md as well? 
I did not see any value for the end user in this file; any prospective
contributor to the project will find the same info in the git repository.

>  > Issues:
>  > =======
>  > - Package installs a %{name}.desktop using desktop-file-install or desktop-
>  >   file-validate if there is such a file.
>  
>  The fedora-review tool complains about this. I think we need to do
>  something like
>  
>      %check
>      desktop-file-validate
>  %{buildroot}%{_datadir}/wayland-sessions/%{name}.desktop 
I assumed that we don't do that for desktop session files, but sure, will add.

>  
>  > NTP License (legal disclaimer) Historical Permission Notice and Disclaimer - sell
> variant
>  >
> -----------------------------------------------------------------------------------------
>  >
> /home/jkadlcik/2051062-river/upstream-unpacked/Source0/river-0.1.3/deps/zig-wlroots/protocol/wlr-layer-shell-unstable-v1.xml
>  >
> /home/jkadlcik/2051062-river/upstream-unpacked/Source0/river-0.1.3/protocol/wlr-layer-shell-unstable-v1.xml
>  
>  This license isn't mentioned in the License field but I am not sure if
>  it is necessary. 
In the Callaway licensing scheme this license was handled as one of the
variants of MIT. I should update the tag to

    GPL-3.0-or-later AND ISC AND HPND-sell-variant

and ask upstream about the license of the code generated with zig-wayland
from the protocol descriptions.

>  > [ ]: Package must own all directories that it creates.
>  >     Note: Directories without known owners: /usr/share/river
>  
>  There is
>  
>      %{_datadir}/%{name}/init.example
>  
>  in the %files section. We need to change it or add a new line for the
>  whole directory. 
Will add %dir entry, thanks for catching that!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #4 from Aleksei Bavshin <alebastr89(a)gmail.com&gt; ---
Spec URL: https://alebastr.fedorapeople.org/review/river/river.spec
SRPM URL:
https://alebastr.fedorapeople.org/review/river/river-0.1.3-1.fc38.src.rpm

>  I assumed that we don't do that for desktop session files 
And that is why:

    error: file contains key "DesktopNames" in group "Desktop Entry",
but keys
extending the format should start with "X-"

The session file is not a desktop entry, even if it's named like one and may
look exactly like one :(


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #5 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
Thank you for the changes,

>  The upstream developer strongly believe that the user should write
> their
>  own configuration based on the example they provide and don't have any
>  support for the default config (in fact support for the default system
>  config was removed at some point just before the initial release).
>  Which means there's no default keybindings :(
>  
>  README.md describes how to start in the Usage section, but I agree that it
>  raises the entry barrier a bit higher than usual even for tiling WMs. 
Yep, that's a bit strange decision to me but my opinion isn't important
here, nor it is important for the package review. But thank you for the
explanation :-)


>  Ah, here comes the complicated part:
>  zig, being still actively developed and designed, does not have any
>  support for sharing the code yet. Think rust with its unstable ABI,
>  but without a package manager or a standard library location.
>  
>  So all the bundled code is embedded to the repo as git submodules
>  and the paths are hardcoded in the buildsystem. Plus some details
>  of the build system which make it even more inconvenient.
>  
>  Tl;dr: I don't want to deal with that until the Zig toolchain evolves
>  to offer some package/code reuse solution. And until we have support
>  for that in zig-rpm-macros. 
Aha, makes sense, thank you. The bundling is AFAIK done correctly and
I asked on #fedora-devel if it is okay to bundle in this case and got
their blessing.

I like that you put an explanation into the spec file.


>  I did not see any value for the end user in this file; any
> prospective
>  contributor to the project will find the same info in the git repository. 
Ok, no problem

>  error: file contains key "DesktopNames" in group
> "Desktop Entry",
>  but keys extending the format should start with "X-"  
Ah, :-/
Well, at least we tried.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #6 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
Okay, the package looks good to me now,
thank you very much.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated", "*No
     copyright* ISC License GNU General Public License v3.0 only", "GNU
     General Public License, Version 3", "ISC License", "NTP License
(legal
     disclaimer) Historical Permission Notice and Disclaimer - sell
     variant", "MIT License", "*No copyright* MIT License",
"BSD 0-Clause
     License", "*No copyright* [generated file]". 110 files have unknown
     license. Detailed output of licensecheck in
     /home/jkadlcik/2051062-river/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/fish(dub, flatpak,
     darkman, ffsend, pipx, filesystem, bfs, bat, poetry, fd-find, gh,
     ripgrep, swaylock, ikona-cli-fish-completions, fish, wlogout,
     hyperfine, exercism, alacritty, mako, vultr-cli, exa, python-launcher,
     zola, ocrmypdf, task, ansible-core, stratis-cli, grim, gitleaks,
     cpu-x, foot, gopass, docker-compose, tealdeer, swayidle, hub, youtube-
     dl, sway, httpie, hcloud, just),
     /usr/share/fish/vendor_completions.d(flatpak, darkman, ffsend, pipx,
     filesystem, bfs, bat, poetry, fd-find, gh, ripgrep, swaylock, fish,
     hyperfine, exercism, alacritty, mako, vultr-cli, exa, environment-
     modules, python-launcher, zola, ocrmypdf, ansible-core, stratis-cli,
     grim, gitleaks, cpu-x, skopeo, podman-remote, flameshot, foot, gopass,
     docker-compose, tealdeer, swayidle, podman, sway, httpie, hcloud,
     just), /usr/share/zsh(xss-lock, awscli, dub, darkman, ffsend,
     filesystem, bfs, bat, poetry, fd-find, gh, ripgrep, etckeeper,
     swaylock, croc, wlogout, profile-cleaner, hyperfine, exercism, pcp,
     alacritty, zsh, vcsh, caddy, catimg, fuzzel, mako, snapd, vultr-cli,
     git-delta, libinput, polybar, yambar, vagrant, exa, zola, creds, kde-
     connect, mercurial, jo, pdfgrep, python3-wstool, stratis-cli, task,
     pulseaudio, gitleaks, gpaste, cpu-x, why3, curl, playerctl, tldr,
     osmium-tool, bubblewrap, foot, gopass, docker-compose, swayidle, mpv,
     ninja-build, hub, youtube-dl, sway, skim, hcloud, reprepro),
     /usr/share/zsh/site-functions(poetry, gh, fd-find, exercism, xpanes,
     creds, stratis-cli, pulseaudio, podman-remote, playerctl, rubygem-
     ronn-ng, docker-compose, xss-lock, filesystem, wlogout, salt, pcp,
     caddy, ddgr, fuzzel, vultr-cli, khard, environment-modules, mercurial,
     jo, gpaste, cpu-x, skopeo, imgp, gopass, ninja-build, sway, kompose,
     darkman, python3-streamlink, just, dub, nheko, profile-sync-daemon,
     ffsend, bat, croc, profile-cleaner, hyperfine, alacritty, vcsh, mako,
     snapd, git-delta, libinput, polybar, yambar, exa, zola, fzf,
     python3-wstool, task, gitleaks, curl, tldr, osmium-tool, swayidle,
     mpv, podman, arch-install-scripts, restic, buku, hcloud, lastpass-cli,
     reprepro, awscli, flatpak, firewalld, bfs, swaylock, ripgrep, nnn,
     zsh, catimg, googler, kde-connect, pdfgrep, why3, flameshot,
     bubblewrap, foot, hub, youtube-dl, skim)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in river-
     protocols-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: Source 3 is not passed to gpgverify.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

river-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/.dwz/river-0.1.3-1.fc38.x86_64
river-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/usr/bin/river-0.1.3-1.fc38.x86_64.debug
river-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/usr/bin/riverctl-0.1.3-1.fc38.x86_64.debug
river-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/usr/bin/rivertile-0.1.3-1.fc38.x86_64.debug
river-debuginfo.x86_64: E: statically-linked-binary
/usr/lib/debug/.dwz/river-0.1.3-1.fc38.x86_64
river-debuginfo.x86_64: W: position-independent-executable-suggested
/usr/lib/debug/usr/bin/river-0.1.3-1.fc38.x86_64.debug
river-debuginfo.x86_64: W: position-independent-executable-suggested
/usr/lib/debug/usr/bin/riverctl-0.1.3-1.fc38.x86_64.debug
river-debuginfo.x86_64: W: position-independent-executable-suggested
/usr/lib/debug/usr/bin/rivertile-0.1.3-1.fc38.x86_64.debug
river.x86_64: W: position-independent-executable-suggested /usr/bin/river
river.x86_64: W: position-independent-executable-suggested /usr/bin/riverctl
river.x86_64: W: position-independent-executable-suggested /usr/bin/rivertile
river-debuginfo.x86_64: W: no-documentation
river-debugsource.x86_64: W: no-documentation
river-protocols-devel.x86_64: W: no-documentation
river-debuginfo.x86_64: E: missing-PT_GNU_STACK-section
/usr/lib/debug/.dwz/river-0.1.3-1.fc38.x86_64
river-debuginfo.x86_64: E: ldd-failed
/usr/lib/debug/usr/bin/river-0.1.3-1.fc38.x86_64.debug /usr/bin/bash: warning:
setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for
`/usr/lib/debug/usr/bin/river-0.1.3-1.fc38.x86_64.debug'

river-debuginfo.x86_64: E: ldd-failed
/usr/lib/debug/usr/bin/riverctl-0.1.3-1.fc38.x86_64.debug /usr/bin/bash:
warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for
`/usr/lib/debug/usr/bin/riverctl-0.1.3-1.fc38.x86_64.debug'

river-debuginfo.x86_64: E: ldd-failed
/usr/lib/debug/usr/bin/rivertile-0.1.3-1.fc38.x86_64.debug /usr/bin/bash:
warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for
`/usr/lib/debug/usr/bin/rivertile-0.1.3-1.fc38.x86_64.debug'

river-debuginfo.x86_64: W: invalid-license GPL-3.0-only
river-debuginfo.x86_64: W: invalid-license HPND-sell-variant
river-debugsource.x86_64: W: invalid-license GPL-3.0-only
river-debugsource.x86_64: W: invalid-license HPND-sell-variant
river.x86_64: W: invalid-license GPL-3.0-only
river.x86_64: W: invalid-license HPND-sell-variant
river-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
river-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
river-debugsource.x86_64: W: files-duplicate
/usr/src/debug/river-0.1.3-1.fc38.x86_64/zig-cache/o/b86a54816b82db1d1b6d464d8cd17915/builtin.zig
/usr/src/debug/river-0.1.3-1.fc38.x86_64/zig-cache/o/3032910e6e155732784c14ef1e1ba5a5/builtin.zig:/usr/src/debug/river-0.1.3-1.fc38.x86_64/zig-cache/o/65b388f6e01a38b1a4d0f831c451e0d0/builtin.zig
 4 packages and 0 specfiles checked; 5 errors, 22 warnings, 5 badness; has
taken 0.5 s



Source checksums
----------------
https://isaacfreund.com/public_key.txt#/gpgkey-86DED400DDFD7A11.gpg :
  CHECKSUM(SHA256) this package     :
b09f93a85ccb01e2eef8cf044e41308957e9acb7ccb419588a3df9fd975de9e8
  CHECKSUM(SHA256) upstream package :
b09f93a85ccb01e2eef8cf044e41308957e9acb7ccb419588a3df9fd975de9e8
https://github.com/riverwm/river/releases/download/v0.1.3/river-0.1.3.tar...
:
  CHECKSUM(SHA256) this package     :
114290f235f65a5cecd98c3214071f8fc5ed36dc1607646b15ece6afa49c4806
  CHECKSUM(SHA256) upstream package :
114290f235f65a5cecd98c3214071f8fc5ed36dc1607646b15ece6afa49c4806
https://github.com/riverwm/river/releases/download/v0.1.3/river-0.1.3.tar.gz :
  CHECKSUM(SHA256) this package     :
f63444c300ab554ef3ca0d904a6b124a832c8397d474ef067bdde911c981c79f
  CHECKSUM(SHA256) upstream package :
f63444c300ab554ef3ca0d904a6b124a832c8397d474ef067bdde911c981c79f


Requires
--------
river (rpmlib, GLIBC filtered):
    /usr/bin/sh
    libc.so.6()(64bit)
    libevdev.so.2()(64bit)
    libevdev.so.2(LIBEVDEV_1)(64bit)
    libinput.so.10()(64bit)
    libinput.so.10(LIBINPUT_0.12.0)(64bit)
    libinput.so.10(LIBINPUT_0.14.0)(64bit)
    libinput.so.10(LIBINPUT_0.19.0)(64bit)
    libinput.so.10(LIBINPUT_0.21.0)(64bit)
    libinput.so.10(LIBINPUT_1.1)(64bit)
    libinput.so.10(LIBINPUT_1.2)(64bit)
    libinput.so.10(LIBINPUT_1.5)(64bit)
    libm.so.6()(64bit)
    libpixman-1.so.0()(64bit)
    libwayland-client.so.0()(64bit)
    libwayland-server.so.0()(64bit)
    libwlroots.so.10()(64bit)
    libxkbcommon.so.0()(64bit)
    libxkbcommon.so.0(V_0.5.0)(64bit)

river-protocols-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config

river-debuginfo (rpmlib, GLIBC filtered):

river-debugsource (rpmlib, GLIBC filtered):



Provides
--------
river:
    bundled(zig-pixman)
    bundled(zig-wayland)
    bundled(zig-wlroots)
    bundled(zig-xkbcommon)
    river
    river(x86-64)

river-protocols-devel:
    pkgconfig(river-protocols)
    river-protocols-devel
    river-protocols-devel(x86-64)

river-debuginfo:
    river-debuginfo
    river-debuginfo(x86-64)

river-debugsource:
    river-debugsource
    river-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2051062
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: SugarActivity, Perl, R, Haskell, Java, Python, Ocaml, PHP,
fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #7 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
Ah, I am sorry, I forgot to mark this fedora-review+ :-/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062

Jakub Kadlčík <jkadlcik(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #8 from Kevin Fenzi <kevin(a)scrye.com&gt; ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/river


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED



--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2022-7c6c2c1f62 has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-7c6c2c1f62


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2022-af294de87c has been submitted as an update to Fedora 36.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-af294de87c


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2022-7c6c2c1f62 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2022-7c6c2c1f62 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-7c6c2c1f62

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2022-af294de87c has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2022-af294de87c \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-af294de87c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-10-08 17:33:32



--- Comment #13 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2022-af294de87c has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051062

[Bug 2051062] Review Request: river - Dynamic tiling Wayland compositor

https://bugzilla.redhat.com/show_bug.cgi?id=2051062



--- Comment #14 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2022-7c6c2c1f62 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051062