Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: plasma-mobile - A Plasma Active mobile workspace
https://bugzilla.redhat.com/show_bug.cgi?id=752447
Summary: Review Request: plasma-mobile - A Plasma Active mobile workspace Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jreznik@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile-0.2-1.f... Description: A touch enabled Plasma Active workspace aiming on different (not only) mobile devices.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Alias| |plasma-mobile Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
--- Comment #1 from Rex Dieter rdieter@math.unl.edu 2011-11-09 12:00:17 EST --- A couple of concerns off the top of my head.
1. desktop-file-validate %check fails. (I'll attach a patch that fixes it for me on f16), upstreamed these fixes already to git.kde.org
2. %{_qt4_plugindir}/inputmethods/plasmainputcontextplugin.so will get multilib'd, so probably want to make -libs package for this item
3. file /usr/lib64/kde4/imports/org/kde/plasma/mobilecomponents is not owned by any package. can probably just recursively own that dir, instead of enumerating the items under it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
--- Comment #2 from Rex Dieter rdieter@math.unl.edu 2011-11-09 12:01:01 EST --- Created attachment 532620 --> https://bugzilla.redhat.com/attachment.cgi?id=532620 fix desktop-file-validate errors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
--- Comment #3 from Jaroslav Reznik jreznik@redhat.com 2011-11-10 08:47:32 EST --- Spec URL: http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile-0.2-2.f...
(In reply to comment #1)
A couple of concerns off the top of my head.
- desktop-file-validate %check fails. (I'll attach a patch that fixes it for
me on f16), upstreamed these fixes already to git.kde.org
Ah, I had these patches locally, forgot to add to SPEC/SRPM - in your patch, there's still one error, I'll take a look if I can upstream it
- %{_qt4_plugindir}/inputmethods/plasmainputcontextplugin.so
will get multilib'd, so probably want to make -libs package for this item
Ok, added -libs.
- file /usr/lib64/kde4/imports/org/kde/plasma/mobilecomponents is not owned
by any package. can probably just recursively own that dir, instead of enumerating the items under it.
Fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2011-11-11 11:35:50 EST --- Looking good.
naming: ok
sources: ok md5sum *.bz2 ec5560f243a861ea3eedcfc4103cf6d6 plasma-mobile-0.2.tar.bz2
licensing: ok
macros: ok
scriptlets: ok
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Jaroslav Reznik jreznik@redhat.com 2011-11-16 05:59:14 EST --- New Package SCM Request ======================= Package Name: plasma-mobile Short Description: A Plasma Active mobile workspace Owners: jreznik rdieter kkofler than rnovacek ltinkl Branches: f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2011-11-16 07:09:26 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-11-29 11:05:51
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla