https://bugzilla.redhat.com/show_bug.cgi?id=1299558
Bug ID: 1299558 Summary: Review Request: python-inifile - A small INI library for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: cstratak@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/cstratak/python-inifile/pytho... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/cstratak/python-inifile/fedo... Description: Review request for python-inifile. This library is required for the Lektor framework from Armin Ronacher (which is to be packaged on a later date) Fedora Account System Username: cstratak
My first package, so a sponsor will be needed.
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
cstratak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
Robert Kuska rkuska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rkuska@redhat.com Assignee|nobody@fedoraproject.org |rkuska@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #1 from Robert Kuska rkuska@redhat.com --- The check phase in specfile is redudant, no tests are run nor present in package.
"Ran 0 tests in 0.000s"
It's probably better to use %{version} macro in Source0 so you don't have to edit the link everytime you update the package.
Also you've defined %{sum} macro and used it only in main package description even though both subpackages could use it as well in their description.
These are just minor issues and otherwise it looks nice! :)
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #2 from cstratak@redhat.com --- Update:
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/cstratak/python-inifile/pytho...
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/cstratak/python-inifile/fedo...
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
Robert Kuska rkuska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert Kuska rkuska@redhat.com --- Looks good, approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@redhat.com Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #4 from Miroslav Suchý msuchy@redhat.com --- Looks good to me as well.
APPROVED
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-inifile
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-843bee847e
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-98638e0778
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-18c1b36a18
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-843bee847e
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-18c1b36a18
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-98638e0778
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-01-30 13:22:21
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1299558
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-inifile-0.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org