[Bug 524707] New: Review Request: A measurement, management and statistics sport testing tool

List overview All Threads
Download

newer

older

[Bug 462530] New: Review Request:...

[Bug 492834] New: Review Request:...

Red Hat Bugzilla

21 Sep 2009 21 Sep '09

8:15 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: A measurement, management and statistics sport testing tool

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Summary: Review Request: A measurement, management and statistics sport testing tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ismael@olea.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://olea.org/tmp/chronojump.spec SRPM URL: http://olea.org/paquetes-rpm/fedora-11/chronojump-0.8.10-1.fc11.src.rpm

Description:

ChronoJump is an open hardware, free software, multiplatform complete system for measurement, management and statistics of sport short-time tests.

Chronojump uses a contact platform and/or photocells, and also a chronometer printed circuit designed ad-hoc in order to obtain precise and trustworthy measurements.

Chronojump is used by trainers, teachers and students.

CJ is an awarded project supported by the active research work of Xavier de Blas

$ rpmlint -iv chronojump-0.8.10-1.fc11.src.rpm chronojump.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -iv chronojump-0.8.10-1.fc11.i586.rpm chronojump.i586: I: checking chronojump.i586: W: devel-file-in-non-devel-package /usr/lib/chronojump/libchronopic.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -iv chronojump-doc-0.8.10-1.fc11.i586.rpm chronojump-doc.i586: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

I know it's expected to have clean rpmlint but it's weird for me to create an devel package for libchronopic.so only, specially considering is not expected to be used for developing.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

21 Sep 21 Sep

11:42 p.m.

New subject: [Bug 524707] Review Request: A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Michel Alexandre Salim michael.silvanus@gmail.com changed:

--- Comment #1 from Michel Alexandre Salim michael.silvanus@gmail.com 2009-09-21 19:42:35 EDT ---

...

$ rpmlint -iv chronojump-0.8.10-1.fc11.i586.rpm chronojump.i586: I: checking chronojump.i586: W: devel-file-in-non-devel-package /usr/lib/chronojump/libchronopic.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package.

If this is not meant for other software to use, then it can be ignored, yes.

...

I know it's expected to have clean rpmlint but it's weird for me to create an devel package for libchronopic.so only, specially considering is not expected to be used for developing.

Most Mono packages don't have clean rpmlint outputs either, just because rpmlint does not consider .dll and .exe to be libraries and executables :)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Sep 22 Sep

12:32 a.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Jason Tibbitts tibbs@math.uh.edu changed:

--- Comment #2 from Jason Tibbitts tibbs@math.uh.edu 2009-09-21 20:32:42 EDT --- Please try to follow the usual format for review tickets; we need to be able to search the ticket summary for the package name.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:51 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

--- Comment #3 from Michel Alexandre Salim michael.silvanus@gmail.com 2009-09-22 13:51:56 EDT --- Looks good so far! There are several minor things to fix, and one major thing -- the launcher script is broken on 64-bit archs -- the latter is a common problem with our Mono apps, so I guess it's a good thing it's caught during review anyway.

Fix them and I can approve this.

Koji F-12 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1698459

ReviewTemplate

MUST

OK rpmlint

$ rpmlint ~/rpmbuild/SRPMS/chronojump-0.8.10-1.fc11.src.rpm ./chronojump* error checking signature of /home/michel/rpmbuild/SRPMS/chronojump-0.8.10-1.fc11.src.rpm chronojump.x86_64: W: devel-file-in-non-devel-package /usr/lib64/chronojump/libchronopic.so 4 packages and 0 specfiles checked; 0 errors, 1 warnings.

Internal use only, warning can be ignored

OK package name OK spec file name OK package guideline-compliant OK license complies with guidelines OK license field accurate OK license file not deleted OK spec in US English OK spec legible OK source matches upstream OK builds under >= 1 archs, others excluded: Koji ? build dependencies complete over-complete: you can drop BR on mono-core since you already BR: mono-devel OK locales handled using %find_lang, no %{_datadir}/locale FIX library -> ldconfig since your package does not install any library in the normal ld.so path and does not extend the path (see /etc/ld.so.conf*), running ldconfig is unnecessary (this also gives you the exception from the .so-in-devel rule)

FIX own all directories must depend on hicolor-icon-theme for the installed icon OK no dupes in %files OK permission OK %clean RPM_BUILD_ROOT OK macros used consistently not really about macros, but about scriplets. See the guideline about how to

OK Package contains code ? large docs => -doc -doc should be in group "Documentation"

Also, you can make -doc noarch, starting from RPM 4.6 (i.e. F-10 and above) and since Mono is not available on RHEL, you can just go ahead and declare the subpackage to be noarch without testing for the Fedora/RHEL version first

e.g. %package doc ... BuildArch: noarch

OK doc not runtime dependent NA if contains *.pc, req pkgconfig NA if libfiles are suffixed, the non-suffixed goes to devel OK desktop file uses desktop-file-install OK clean buildroot before install OK filenames UTF-8

SHOULD OK package build in mock on all architectures FIX package functioned as described the launcher script is hardcoded to look for the .exe under /usr/lib instead of %{_libdir}: $ chronojump Cannot open assembly '/usr/lib/chronojump/Chronojump.exe': No such file or directory.

Unfortunately, a common problem in Mono apps, since Novell's openSUSE is also multilib-capable (like Fedora) and thus they intentionally hard-code /usr/lib because they consider Mono to be noarch, and we don't make that assumption :(

FIX scriplets are sane icon cache not updated; see http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache OK other subpackages should require versioned base OK require package not files

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:26 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

--- Comment #4 from Ismael Olea ismael@olea.org 2009-09-22 18:26:06 EDT --- (In reply to comment #3)

...

Fix them and I can approve this.

Everything has been fixed. I've added the scriplets for update-desktop-database

I don't have an x64 system so I can't test the launcher script but I think it's working right.

Spec URL: http://olea.org/tmp/chronojump.spec SRPM URL: http://olea.org/paquetes-rpm/fedora-11/chronojump-0.8.10-2.olea.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

29 Sep 29 Sep

9:37 a.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

--- Comment #5 from Ismael Olea ismael@olea.org 2009-09-29 05:37:10 EDT --- Updated to 0.8.11:

Spec URL: http://olea.org/tmp/chronojump.spec SRPM URL: http://olea.org/paquetes-rpm/fedora-11/chronojump-0.8.11-1.fc11.src.rpm

If I understood right today would be the last day for get into F12. Any news about the revision?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:02 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

--- Comment #6 from Michel Alexandre Salim michael.silvanus@gmail.com 2009-09-29 14:02:44 EDT --- Sorry about the delay. And no, you can still get it into F-12, you just have to get your package manually tagged. I'll help you through that if you want.

There is one fix you need to make: in src/util.cs, GetManualDir() returns GetPrefixDir() + "share/doc/chronojump"; the latter should really be

"share/doc/chronojump-doc-%{version}"

you'd probably need to fix it with sed, in the %prep section, since the version number will change each time.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4 Oct 4 Oct

1:23 a.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

--- Comment #7 from Ismael Olea ismael@olea.org 2009-10-03 21:23:20 EDT --- Spec URL: http://olea.org/tmp/chronojump.spec SRPM URL: http://koji.fedoraproject.org/koji/getfile?taskID=1726288&name=chronojum...

fixed!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:05 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Michel Alexandre Salim michael.silvanus@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #8 from Michel Alexandre Salim michael.silvanus@gmail.com 2009-10-04 17:05:38 EDT --- Just one thing -- rather than creating a tempfile, sed-ing into it and then renaming the temp, why not use sed -i (in-place) instead?

Also, sed can use different separator tokens, so when the string you want to replace is full of slashes, use something else -- say pipe -- instead

sed -i 's|share/doc/chronojump|share/doc/chronojump-%{version}|g' src/utils.cs

Otherwise, you might want to use $(mktemp) rather than `mktemp` -- backquote is a bash-ism (I just noticed it being frowned on in the Python merge review).

The program's output is *very* noisy, but I guess that's more of an upstream problem.

But you can make these changes when you commit the files to CVS -- everything else looks good.

APPROVED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:41 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Ismael Olea ismael@olea.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #9 from Ismael Olea ismael@olea.org 2009-10-04 17:41:55 EDT --- New Package CVS Request ======================= Package Name: Chronojump Short Description: A measurement, management and statistics sport testing tool Owners: olea Branches: F-10 F-11 F-12 InitialCC: salimma

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:42 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

--- Comment #10 from Ismael Olea ismael@olea.org 2009-10-04 17:42:47 EDT --- (In reply to comment #8)

I take note of your suggestion

...

APPROVED

Thanks!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Oct 6 Oct

5:44 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |

--- Comment #11 from Kevin Fenzi kevin@tummy.com 2009-10-06 13:44:26 EDT --- You have a uppercase "Chronojump" in your request, but the package seems to be "chronojump" can you confirm the correct case and reset the fedora-cvs flag to ? when you are ready?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:32 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Ismael Olea ismael@olea.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #12 from Ismael Olea ismael@olea.org 2009-10-06 16:32:28 EDT --- New Package CVS Request ======================= Package Name: chronojump Short Description: A measurement, management and statistics sport testing tool Owners: olea Branches: F-10 F-11 F-12 InitialCC: salimma

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:33 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

--- Comment #13 from Ismael Olea ismael@olea.org 2009-10-06 16:33:01 EDT --- (In reply to comment #11)

...

You have a uppercase "Chronojump" in your request, but the package seems to be "chronojump" can you confirm the correct case and reset the fedora-cvs flag to ? when you are ready?

Sorry!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:30 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #14 from Kevin Fenzi kevin@tummy.com 2009-10-06 17:30:46 EDT --- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:43 p.m.

New subject: [Bug 524707] Review Request: chronojump - A measurement, management and statistics sport testing tool

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=524707

Ismael Olea ismael@olea.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5768

Age (days ago)

5783

Last active (days ago)

package-review@lists.fedoraproject.org

15 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla