https://bugzilla.redhat.com/show_bug.cgi?id=2064132
Bug ID: 2064132 Summary: Review Request: rust-bytes-cast-derive - Safely re-interpreting &[u8] bytes as custom structs without copying, for efficiently reading structured binary data Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: alebastr89@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://alebastr.fedorapeople.org/review/mercurial-rs/rust-bytes-cast-derive... SRPM URL: https://alebastr.fedorapeople.org/review/mercurial-rs/rust-bytes-cast-derive... Description: Safely re-interpreting &[u8] bytes as custom structs without copying, for efficiently reading structured binary data. Procedural macro for compile-time soundness checking. Fedora Account System Username: alebastr
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2064133
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2064133 [Bug 2064133] Review Request: rust-bytes-cast - Safely re-interpreting &[u8] bytes as custom structs without copying, for efficiently reading structured binary data
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
Mads Kiilerich mads@kiilerich.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2063941 Doc Type|--- |If docs needed, set a value CC| |mads@kiilerich.com
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2063941 [Bug 2063941] Feature request: Enable Mercurial rust extensions
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
--- Comment #1 from Mads Kiilerich mads@kiilerich.com --- I verified that the spec and source is exactly as generated with "rust2rpm -as bytes-cast-derive".
The "zlib or ASL 2.0 or MIT" license is OK.
The package builds locally on f35 x86_64, installs, and works for a local build of Mercurial with Rust extensions.
rpmlint is clean, except "W: no-documentation" and "E: summary-too-long". I don't think the 116 character summary will be a real problem, and certainly not worth deviating from upstream and making a first edit to the generated spec file.
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
Mads Kiilerich mads@kiilerich.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
Mads Kiilerich mads@kiilerich.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mads@kiilerich.com
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bytes-cast-derive
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c7ededf903 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-c7ededf903 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2064132
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-05-07 04:17:24
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org