https://bugzilla.redhat.com/show_bug.cgi?id=1771089
Bug ID: 1771089 Summary: Review Request: nodejs-dreamopt - Command-line parser with readable syntax from your sweetest dreams Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 956806 (nodejs-reviews) Target Milestone: --- Classification: Fedora
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-dreamopt/nodejs-dreamopt.sp... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-dreamopt/nodejs-dreamopt-0.... Description: Command-line parser with readable syntax from your sweetest dreams Fedora Account System Username: jsmith
FWIW, this is a re-review of a previously orphaned package
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1771089
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1736200
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1736200 [Bug 1736200] nodejs-esprima: FTBFS in Fedora rawhide/f31
https://bugzilla.redhat.com/show_bug.cgi?id=1771089
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Tests fail:
265 passing (136ms) 41 failing
1) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given [""] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"argv":[]}, expected = {"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
2) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["-a"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"AAA":true,"argv":[]}, expected = {"AAA":true,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
3) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["-b","10"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"BBB":10,"argv":[]}, expected = {"BBB":10,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
4) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["-b10"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"BBB":10,"argv":[]}, expected = {"BBB":10,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
5) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["-ac"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"AAA":true,"ccc":true,"argv":[]}, expected = {"AAA":true,"ccc":true,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
6) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["-ab","10"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"AAA":true,"BBB":10,"argv":[]}, expected = {"AAA":true,"BBB":10,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
7) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["-ab10"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"AAA":true,"BBB":10,"argv":[]}, expected = {"AAA":true,"BBB":10,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
8) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["--AAA"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"AAA":true,"argv":[]}, expected = {"AAA":true,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
9) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["--no-AAA"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"AAA":false,"argv":[]}, expected = {"AAA":false,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
10) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["--ccc"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"ccc":true,"argv":[]}, expected = {"ccc":true,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
11) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["--no-ccc"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"ccc":false,"argv":[]}, expected = {"ccc":false,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
12) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["--BBB","10"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"BBB":10,"argv":[]}, expected = {"BBB":10,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
13) dreamopt with a syntax as simple as -a/--AAA, -b/--BBB COUNT, -c/--ccc when given ["--BBB=10"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"BBB":10,"argv":[]}, expected = {"BBB":10,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
14) dreamopt with a syntax that has two positional arguments and one option (-v/--verbose) when given [] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"argv":[]}, expected = {"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
15) dreamopt with a syntax that has two positional arguments and one option (-v/--verbose) when given ["-v"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"verbose":true,"argv":[]}, expected = {"verbose":true,"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
16) dreamopt with a syntax that has two positional arguments and one option (-v/--verbose) when given ["foo"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"first":"foo","argv":["foo"]}, expected = {"argv":["foo"],"first":"foo"} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
17) dreamopt with a syntax that has two positional arguments and one option (-v/--verbose) when given ["foo","bar"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"first":"foo","second":"bar","argv":["foo","bar"]}, expected = {"argv":["foo","bar"],"first":"foo","second":"bar"} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
18) dreamopt with a syntax that has two positional arguments and one option (-v/--verbose) when given ["-v","foo"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"verbose":true,"first":"foo","argv":["foo"]}, expected = {"argv":["foo"],"first":"foo","verbose":true} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
19) dreamopt with a syntax that has two positional arguments and one option (-v/--verbose) when given ["foo","-v"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"verbose":true,"first":"foo","argv":["foo"]}, expected = {"argv":["foo"],"first":"foo","verbose":true} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
20) dreamopt with a syntax that has two positional arguments and one option (-v/--verbose) when given ["-v","foo","bar"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"verbose":true,"first":"foo","second":"bar","argv":["foo","bar"]}, expected = {"argv":["foo","bar"],"first":"foo","second":"bar","verbose":true} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
21) dreamopt with a syntax that has two positional arguments, both of which have default values when given [] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"first":10,"second":20,"argv":[10,20]}, expected = {"argv":[10,20],"first":10,"second":20} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
22) dreamopt with a syntax that has two positional arguments, both of which have default values when given ["foo"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"first":"foo","second":20,"argv":["foo",20]}, expected = {"argv":["foo",20],"first":"foo","second":20} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
23) dreamopt with a syntax that has two positional arguments, both of which have default values when given ["foo","bar"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"first":"foo","second":"bar","argv":["foo","bar"]}, expected = {"argv":["foo","bar"],"first":"foo","second":"bar"} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
24) dreamopt with a syntax that has two positional arguments, one of which is required when given ["foo"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"first":"foo","second":20,"argv":["foo",20]}, expected = {"argv":["foo",20],"first":"foo","second":20} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
25) dreamopt with a syntax that has two positional arguments, one of which is required when given ["foo","bar"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"first":"foo","second":"bar","argv":["foo","bar"]}, expected = {"argv":["foo","bar"],"first":"foo","second":"bar"} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
26) dreamopt with a syntax that has a required option when given ["--src","xxx"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"src":"xxx","argv":[]}, expected = {"src":"xxx","argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
27) dreamopt with a syntax that has a required option when given ["--src","xxx","zzz"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"src":"xxx","first":"zzz","argv":["zzz"]}, expected = {"src":"xxx","first":"zzz","argv":["zzz"]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
28) dreamopt with a syntax that has a required option when given ["zzz","--src","xxx"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"src":"xxx","first":"zzz","argv":["zzz"]}, expected = {"src":"xxx","first":"zzz","argv":["zzz"]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
29) dreamopt with a syntax that has a list option when given [] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"src":[],"argv":[]}, expected = {"src":[],"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
30) dreamopt with a syntax that has a list option when given ["--src","xxx"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"src":["xxx"],"argv":[]}, expected = {"src":["xxx"],"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
31) dreamopt with a syntax that has a list option when given ["--src","xxx","--src","yyy"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"src":["xxx","yyy"],"argv":[]}, expected = {"src":["xxx","yyy"],"argv":[]} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
32) dreamopt with a syntax that has two subcommands when given ["foo"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"command":"foo","argv":[]}, expected = {"argv":[],"command":"foo"} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
33) dreamopt with a syntax that has two subcommands when given ["bar"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"command":"bar","argv":[],"bbbar":42}, expected = {"argv":[],"command":"bar","bbbar":42} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
34) dreamopt with a syntax that has a subcommand with local options when given ["foo"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"command":"foo","argv":[]}, expected = {"argv":[],"command":"foo"} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
35) dreamopt with a syntax that has a subcommand with local options when given ["-v","foo"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"verbose":true,"command":"foo","argv":[]}, expected = {"argv":[],"command":"foo","verbose":true} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
36) dreamopt with a syntax that has a subcommand with local options when given ["foo","-v"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"command":"foo","verbose":true,"argv":[]}, expected = {"argv":[],"command":"foo","verbose":true} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
37) dreamopt with a syntax that has a subcommand with local options when given ["bar"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"command":"bar","argv":[]}, expected = {"argv":[],"command":"bar"} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
38) dreamopt with a syntax that has a subcommand with local options when given ["bar","--boz"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"command":"bar","boz":true,"argv":[]}, expected = {"argv":[],"command":"bar","boz":true} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
39) dreamopt with a syntax that has a subcommand with local options when given ["-v","bar","--boz"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"verbose":true,"command":"bar","boz":true,"argv":[]}, expected = {"argv":[],"command":"bar","boz":true,"verbose":true} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
40) dreamopt with a syntax that has a subcommand with local options when given ["bar","--boz","-v"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"command":"bar","boz":true,"verbose":true,"argv":[]}, expected = {"argv":[],"command":"bar","boz":true,"verbose":true} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
41) dreamopt with a git-style syntax when given ["push"] should not return any other option keys: AssertionError [ERR_ASSERTION]: Extra keys found in expected: , actual = {"command":"push","argv":[]}, expected = {"argv":[],"command":"push"} at Context.<anonymous> (test/dreamopt_test.js:48:23) at processImmediate (internal/timers.js:439:21)
error: Bad exit status from /var/tmp/rpm-tmp.xsGsSv (%check)
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Jared Smith jsmith.fedora@gmail.com's needinfo: Bug 1771089: Review Request: nodejs-dreamopt - Command-line parser with readable syntax from your sweetest dreams https://bugzilla.redhat.com/show_bug.cgi?id=1771089
--- Comment #3 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
package-review@lists.fedoraproject.org