Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-jabberbot - A simple jabber (XMPP) bot framework
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Summary: Review Request: python-jabberbot - A simple jabber (XMPP) bot framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian@bernewireless.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-jabberbot.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-jabberbot-0.8-1.fc12.src.r...
Project URL: http://thpinfo.com/2007/python-jabberbot/
Description: This is python-jabberbot, a Jabber bot framework for Python that enables you to easily write simple Jabber bots. You can use your Jabber bots to provide information about your running systems, to make your website interact with your visitors or notify you about updates or changes you monitor with your Python scripts.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1882194
rpmlint output: [fab@localhost noarch]$ rpmlint python-jabberbot-0.8-1.fc12.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[fab@localhost SRPMS]$ rpmlint python-jabberbot-0.8-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@fedoraproject.org AssignedTo|nobody@fedoraproject.org |tomspur@fedoraproject.org Flag| |fedora-review+
--- Comment #1 from Thomas Spura tomspur@fedoraproject.org 2009-12-20 18:32:19 EDT --- Review:
Good: - name ok - %files section ok - permissions ok - rpmlint clean - macros everywhere - %clean is there - %doc ok - no *.la files - no libs - no gui -> no desktop file - no translations - group ok
Needswork: - Have you queried upstream to include a COPYING file? If not yet, please do so. - BR: python-devel is not needed - --prefix=%{_prefix} is not needed in %install - License is GPLv3+ not GPLv3 only
#######################
These are only minor issues, which are fixed easily -> appoving
#######################
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
--- Comment #2 from Fabian Affolter fabian@bernewireless.net 2009-12-21 04:43:16 EDT --- Thanks for the review Thomas.
(In reply to comment #1)
Needswork:
- Have you queried upstream to include a COPYING file? If not yet, please do so.
I'm waiting for an answer from upstream about that issue.
- BR: python-devel is not needed
The Guidelines says 'python-devel' must be added because it's no longer in the default package set. Am I wrong?
http://fedoraproject.org/wiki/Packaging:Python
- --prefix=%{_prefix} is not needed in %install
Will be removed
- License is GPLv3+ not GPLv3 only
Will be fixed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Fabian Affolter fabian@bernewireless.net 2009-12-21 11:59:20 EDT --- New Package CVS Request ======================= Package Name: python-jabberbot Short Description: A simple jabber (XMPP) bot framework Owners: fab Branches: F-11 F-12 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Toshio Ernie Kuratomi a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@gmail.com
--- Comment #4 from Toshio Ernie Kuratomi a.badger@gmail.com 2009-12-21 14:43:29 EDT --- python-devel is needed to build python packages. I'm remember precisely what the issue with that was, however, so it's possible that the python package in Fedora-13 has fixed this (dmalcolm fixed one issue with python-devel being needed in F-13's package). Fedora 12 and below still need it to build, though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Toshio Ernie Kuratomi a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Toshio Ernie Kuratomi a.badger@gmail.com 2009-12-21 15:04:36 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-12-24 06:16:11 EDT --- python-jabberbot-0.8-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-jabberbot-0.8-2.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-12-24 06:16:16 EDT --- python-jabberbot-0.8-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-jabberbot-0.8-2.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-12-24 15:37:31 EDT --- python-jabberbot-0.8-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-jabberbot'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13620
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-12-24 15:44:54 EDT --- python-jabberbot-0.8-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-jabberbot'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13674
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-01-01 22:27:58 EDT --- python-jabberbot-0.8-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.8-2.fc12 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-01-01 22:34:13 EDT --- python-jabberbot-0.8-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=549198
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.8-2.fc12 |0.8-2.fc11
package-review@lists.fedoraproject.org