Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ibus-input-pad - Input Pad for IBus
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Summary: Review Request: ibus-input-pad - Input Pad for IBus Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tfujiwar@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/ibus-input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/ibus-input-pad-0.1.0.2... Description: Input Pad for IBus This module can enable Input Pad with IBus.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #1 from fujiwara tfujiwar@redhat.com 2010-06-16 00:55:02 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=2252863
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #2 from fujiwara tfujiwar@redhat.com 2010-06-21 00:26:40 EDT --- Any sponsors?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2010-06-21 05:08:04 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2261364 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) fa51b69bd89a53e821b30002287c62eadcaccb66 ibus-input-pad-0.1.0.20100611.tar.gz fa51b69bd89a53e821b30002287c62eadcaccb66 ibus-input-pad-0.1.0.20100611.tar.gz.srpm
+ package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application
Suggestions: 1) %description should be The input-pad engine for IBus platform.
2) Like all other ibus-* engines in Fedora, this should Requires: ibus
3) you don't need following BuildRequires: pkgconfig
See a successful koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2261603 without it.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review+ |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #4 from Parag AN(पराग) panemade@gmail.com 2010-06-22 04:44:18 EDT --- fujiwara is in need of some explanations for above suggestions. therefore I am revoking approval as he seems not satisfied with my suggestions specifically on 2nd suggestion.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #5 from fujiwara tfujiwar@redhat.com 2010-06-22 06:39:33 EDT --- After I investigated 2) suggestion, I found ibus-libs doesn't have the dependency of ibus. Now I accepted the 2) suggestion.
1) and 3) seem recommendations but not requirements in Fedora packaging. http://fedoraproject.org/wiki/PackagingGuidelines#Pkgconfig_Files
Updated the spec file: http://github.com/fujiwarat/ibus-input-pad/commit/09563be22d1936b1966c19a52b...
Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/ibus-input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/ibus-input-pad-0.1.0.2...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Parag AN(पराग) panemade@gmail.com 2010-06-23 01:06:11 EDT --- Thanks for understanding suggestions. I am getting mixed replies on fedora-devel channel and fedora packaging mailing list like removing BR: pkgconfig is not creating any harm and someone said we should have it.
I am approving new SRPM. If someone sees any problem, please report here.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2266521
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
fujiwara tfujiwar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
fujiwara tfujiwar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #7 from fujiwara tfujiwar@redhat.com 2010-06-23 01:30:30 EDT --- New Package CVS Request ======================= Package Name: ibus-input-pad Short Description: Input Pad for IBus Owners: fujiwara Branches: F-12 F-13 InitialCC: i18n-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #8 from Jens Petersen petersen@redhat.com 2010-06-25 04:15:41 EDT --- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #9 from Jens Petersen petersen@redhat.com 2010-06-28 01:55:42 EDT --- Thanks for this!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Reopened Status|CLOSED |ASSIGNED Resolution|NEXTRELEASE |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
fujiwara tfujiwar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_DEV
--- Comment #10 from fujiwara tfujiwar@redhat.com 2010-06-30 03:41:33 EDT --- Most interfaces are committed. http://koji.fedoraproject.org/koji/taskinfo?taskID=2282442
I'll integrate this in f12/f13 tomorrow.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
fujiwara tfujiwar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_DEV |MODIFIED
--- Comment #11 from fujiwara tfujiwar@redhat.com 2010-07-01 22:00:08 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=2288658 http://koji.fedoraproject.org/koji/taskinfo?taskID=2288662
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-07-01 22:05:24 EDT --- ibus-input-pad-0.1.0.20100630-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ibus-input-pad-0.1.0.20100630-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-07-01 22:05:29 EDT --- ibus-input-pad-0.1.0.20100630-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ibus-input-pad-0.1.0.20100630-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-07-05 18:03:39 EDT --- ibus-input-pad-0.1.0.20100630-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ibus-input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ibus-input-pad-0.1.0.20100630-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-07-05 18:07:03 EDT --- ibus-input-pad-0.1.0.20100630-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ibus-input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ibus-input-pad-0.1.0.20100630-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-07-07 13:38:34 EDT --- ibus-input-pad-0.1.0.20100630-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |ibus-input-pad-0.1.0.201006 | |30-1.fc13 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-07-07 13:51:08 EDT --- ibus-input-pad-0.1.0.20100630-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604500
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|ibus-input-pad-0.1.0.201006 |ibus-input-pad-0.1.0.201006 |30-1.fc13 |30-1.fc12
package-review@lists.fedoraproject.org