Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-SocksiPy - A Python SOCKS module
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Summary: Review Request: python-SocksiPy - A Python SOCKS module Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lystor@lystor.org.ua QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/python-SocksiPy.spec SRPM URL: http://repo.lystor.org.ua/fedora/12/SRPMS/python-SocksiPy-1.00-1.fc12.src.rp...
Description: This Python module allows you to create TCP connections through a SOCKS proxy without any special effort.
$ rpmlint {i386,x86_64,SRPMS}/python-SocksiPy* 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
This package builds successfully by mock on i686/x86_64 architectures.
This is one from my first packages and I'm looking for a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Nikolay Ulyanitsky lystor@lystor.org.ua changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #1 from Nikolay Ulyanitsky lystor@lystor.org.ua 2010-02-19 04:42:49 EST --- Builds successfully in mock on Fedora 11 with i386/x86_64 architectures.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #2 from Nikolay Ulyanitsky lystor@lystor.org.ua 2010-02-19 07:53:03 EST --- Builds successfully in mock on Fedora 13 with i386/x86_64 architectures.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Nikolay Ulyanitsky lystor@lystor.org.ua changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |566412
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-03-04 14:38:15 EST --- Well, very simple package. Some notes:
* Please fix SourceURL * %python_sitearch macro is used nowhere.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #4 from Nikolay Ulyanitsky lystor@lystor.org.ua 2010-03-05 04:36:46 EST --- Thank you for starting the review.
Please fix SourceURL
What error is in the SourceURL?
$ spectool -g python-SocksiPy.spec --2010-03-05 11:15:26-- http://downloads.sourceforge.net/project/socksipy/socksipy/SocksiPy%201.00/S... ... HTTP request sent, awaiting response... 302 Found
%python_sitearch macro is used nowhere.
Removed.
Spec diff: @@ -1,11 +1,10 @@ %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} -%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif
Name: python-SocksiPy Version: 1.00 -Release: 1%{?dist} +Release: 2%{?dist} Summary: A Python SOCKS module
Group: Development/Languages @@ -31,7 +30,9 @@
# Fix file end-of-line encoding for f in README BUGS LICENSE; do - %{__sed} -i 's/\r//' $f + %{__sed} 's/\r//' $f > $f.new + touch -r $f $f.new + %{__mv} -f $f.new $f done
%build @@ -55,5 +56,9 @@
%changelog +* Fri Mar 05 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.00-2 +- Remove the unused python_sitearch macro +- Preserve timestamps on documentation files + * Sun Feb 14 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.00-1 - Initial package build
$ rpmlint {RPMS/noarch,SRPMS}/python-SocksiPy* 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/python-SocksiPy.spec SRPM URL: http://repo.lystor.org.ua/fedora/12/SRPMS/python-SocksiPy-1.00-2.fc12.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-03-05 04:46:57 EST --- (In reply to comment #4)
Please fix SourceURL
What error is in the SourceURL?
As I explained in the other review request, please follow https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #6 from Nikolay Ulyanitsky lystor@lystor.org.ua 2010-03-05 05:17:14 EST ---
As I explained in the other review request, please follow https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
Thx
Please fix SourceURL
Template http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.... is not valid for this project.
Spec diff: Name: python-SocksiPy Version: 1.00 -Release: 2%{?dist} +Release: 3%{?dist} Summary: A Python SOCKS module
Group: Development/Languages License: BSD URL: http://socksipy.sourceforge.net/ -Source0: http://downloads.sourceforge.net/project/socksipy/socksipy/SocksiPy%20%%7Bve... +Source0: http://downloads.sourceforge.net/socksipy/SocksiPy%20%%7Bversion%7D/SocksiPy... # https://sourceforge.net/tracker/?func=detail&aid=2954091&group_id=18... Source1: python-SocksiPy-setup.py BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) @@ -56,6 +56,9 @@
%changelog +* Fri Mar 05 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.00-3 +- Fixed the Source0 URL
Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/python-SocksiPy.spec SRPM URL: http://repo.lystor.org.ua/fedora/12/SRPMS/python-SocksiPy-1.00-3.fc12.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+
--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-03-07 04:23:09 EST ---
-------------------------------------------------------------- This package (python-SocksiPy) is APPROVED by mtasaka --------------------------------------------------------------
As I wrote in the other review request, please follow http://fedoraproject.org/wiki/PackageMaintainers/Join
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Nikolay Ulyanitsky lystor@lystor.org.ua changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Nikolay Ulyanitsky lystor@lystor.org.ua 2010-03-07 08:19:09 EST --- New Package CVS Request ======================= Package Name: python-SocksiPy Short Description: A Python SOCKS module Owners: lystor Branches: F-11 F-12 F-13 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2010-03-09 01:15:40 EST --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-03-10 02:46:44 EST --- python-SocksiPy-1.00-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-SocksiPy-1.00-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-03-10 02:47:24 EST --- python-SocksiPy-1.00-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-SocksiPy-1.00-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-03-10 02:48:38 EST --- python-SocksiPy-1.00-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-SocksiPy-1.00-3.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #13 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-03-10 11:30:19 EST --- Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-03-31 21:45:29 EDT --- python-SocksiPy-1.00-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |python-SocksiPy-1.00-3.fc11 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-03-31 21:52:18 EDT --- python-SocksiPy-1.00-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-SocksiPy-1.00-3.fc11 |python-SocksiPy-1.00-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-04-08 23:52:46 EDT --- python-SocksiPy-1.00-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566409
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-SocksiPy-1.00-3.fc12 |python-SocksiPy-1.00-3.fc13
package-review@lists.fedoraproject.org