[Bug 2131838] New: Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

Bug ID: 2131838
           Summary: Review Request: QXlsx - Excel file(*.xlsx)
                    reader/writer library using Qt 5 or 6
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

SRPM: https://fedorapeople.org/~limb/review/QXlsx/QXlsx-1.4.4-1.fc37.src.rpm
SPEC: https://fedorapeople.org/~limb/review/QXlsx/QXlsx.spec

Description: QXlsx is excel file(*.xlsx) reader/writer library.

[Bug 2131838] Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

Gwyn Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2131498
           Doc Type|---                         |If docs needed, set a value

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2131498
[Bug 2131498] stellarium-1.0 is available

[Bug 2131838] Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]

[Bug 2131838] Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

--- Comment #1 from Dan Horák  ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK      source files match upstream:
            3b2aa8449ca7050b864e8cd18ed89cb44706fb08  QtXslx-1.4.4.tar.gz
OK      package meets naming and versioning guidelines.
OK*     specfile is properly named, is cleanly written and uses macros
consistently.
OK      dist tag is present.
OK      license field matches the actual license.
OK      license is open source-compatible (MIT). License text included in
package.
OK      latest version is being packaged.
OK      BuildRequires are proper.
OK      compiler flags are appropriate.
OK      package builds in mock (Rawhide/ppc64le).
OK      debuginfo package looks complete.
OK      rpmlint is silent.
BAD     final provides and requires look sane.
OK*     %check is present and all tests pass.
OK      shared libraries are added to the regular linker search paths.
OK      owns the directories it creates.
OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      no scriptlets present.
OK      code, not content.
OK      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.
OK      headers in devel subpackage
OK      no pkgconfig files.
OK      no libtool .la droppings.
OK      not a GUI app.

- Source0 could be simplified to
%{url}/archive/v%{version}/%{name}-%{version}.tar.gz
- perhaps the Summary could be shortened/modified to eg. "Excel/XLSX file
reader/writer library for Qt"
- /usr/lib64/cmake/QXlsx should belong to the devel subpackage I believe, QXlsx
now provides "cmake(QXlsx)", which sounds wrong
- there is a call with ctest, but it says "No tests were found!!!"

QXlsx-1.4.4/QXlsx/QXlsx.pri contains very wrong "64-bit" check, I hope our
build would override the LIB setting. Or I guess it's not used at all when
building with cmake ...

[Bug 2131838] Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

--- Comment #2 from Gwyn Ciesla  ---
SRPM: https://fedorapeople.org/~limb/review/QXlsx/QXlsx-1.4.4-2.fc37.src.rpm
SPEC: https://fedorapeople.org/~limb/review/QXlsx/QXlsx.spec

Thanks, addressed all but the test issues since there are none.

[Bug 2131838] Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Dan Horák  ---
Thanks, please update the Requires in the devel subpackage per
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_p...
(%{_isa} is missing) during the initial import.

The package is APPROVED.

[Bug 2131838] Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

--- Comment #4 from Gwyn Ciesla  ---
Thank you!

[Bug 2131838] Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

--- Comment #5 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/QXlsx

[Bug 2131838] Review Request: QXlsx - Excel file(*.xlsx) reader/writer library using Qt 5 or 6

https://bugzilla.redhat.com/show_bug.cgi?id=2131838

Gwyn Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2022-10-05 19:29:13